)]}'
{"nova/virt/ironic/driver.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"b1db12ac5bbe86eedd3346fed907fe6e27b96409","unresolved":false,"context_lines":[{"line_number":716,"context_line":"            instance.default_ephemeral_device \u003d \u0027/dev/sda1\u0027"},{"line_number":717,"context_line":"            instance.save()"},{"line_number":718,"context_line":"            # NOTE(bnemec): Ironic ignores the block device mapping generated"},{"line_number":719,"context_line":"            # by Nova, which means the path returned by the metadata server"},{"line_number":720,"context_line":"            # won\u0027t exist. Until some way to synchronize the Nova value with"},{"line_number":721,"context_line":"            # what Ironic actually uses exists, just override the first"},{"line_number":722,"context_line":"            # ephemeral device to match the default_ephemeral_device set"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_4972fb12","line":719,"updated":"2015-09-02 23:59:44.000000000","message":"What was the old behavior? Nova didn\u0027t generate the bdm before?","commit_id":"01716413047674fb95054a6a8c4e3d96aa1b54fc"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"ca9b0c5b6a2f7b0e6ec94bc7c6c84122c98c5a17","unresolved":false,"context_lines":[{"line_number":716,"context_line":"            instance.default_ephemeral_device \u003d \u0027/dev/sda1\u0027"},{"line_number":717,"context_line":"            instance.save()"},{"line_number":718,"context_line":"            # NOTE(bnemec): Ironic ignores the block device mapping generated"},{"line_number":719,"context_line":"            # by Nova, which means the path returned by the metadata server"},{"line_number":720,"context_line":"            # won\u0027t exist. Until some way to synchronize the Nova value with"},{"line_number":721,"context_line":"            # what Ironic actually uses exists, just override the first"},{"line_number":722,"context_line":"            # ephemeral device to match the default_ephemeral_device set"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_646846bb","line":719,"in_reply_to":"da20952f_4972fb12","updated":"2015-09-03 00:11:00.000000000","message":"I realized that\u0027s a vague question. I\u0027m trying to understand how this fixes things for Ironic. Did Ironic not use a bdm before? How did you have the correct bdm device name before the Nova change that broke Tripleo? I hope that makes sense.","commit_id":"01716413047674fb95054a6a8c4e3d96aa1b54fc"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"f4866f51e7499f7ad149c2e9adab5c1465ab8eda","unresolved":false,"context_lines":[{"line_number":716,"context_line":"            instance.default_ephemeral_device \u003d \u0027/dev/sda1\u0027"},{"line_number":717,"context_line":"            instance.save()"},{"line_number":718,"context_line":"            # NOTE(bnemec): Ironic ignores the block device mapping generated"},{"line_number":719,"context_line":"            # by Nova, which means the path returned by the metadata server"},{"line_number":720,"context_line":"            # won\u0027t exist. Until some way to synchronize the Nova value with"},{"line_number":721,"context_line":"            # what Ironic actually uses exists, just override the first"},{"line_number":722,"context_line":"            # ephemeral device to match the default_ephemeral_device set"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_5ed36a38","line":719,"in_reply_to":"da20952f_646846bb","updated":"2015-09-03 17:42:59.000000000","message":"Crud, I had a typo in my commit message that causes the SHA1 to not be found in Gerrit.  Basically, yes, a BDM was not created before https://review.openstack.org/#/c/83516/ so the metadata would return the default as set in https://github.com/openstack/nova/blob/master/nova/virt/ironic/driver.py#L747\n\nThis is because the block mapping reads the default as ephemeral0: https://github.com/openstack/nova/blob/e36585bc6a8d3b9bff72e967a098391c3364e2e4/nova/block_device.py#L524 but then when a BDM exists it overwrites it at https://github.com/openstack/nova/blob/e36585bc6a8d3b9bff72e967a098391c3364e2e4/nova/block_device.py#L556  In Ironic\u0027s case, this overwritten value is always wrong AFAICT because Ironic makes the ephemeral storage a partition on the first device rather than a whole second device.","commit_id":"01716413047674fb95054a6a8c4e3d96aa1b54fc"}]}