)]}'
{"nova/scheduler/filters/aggregate_multitenancy_isolation.py":[{"author":{"_account_id":1007,"name":"Nathanael I Burton","email":"nathanael.i.burton.work@gmail.com","username":"mathrock"},"change_message_id":"805daec5a4484cd17d99f5d03f00a3279837b4b6","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        metadata \u003d db.aggregate_metadata_get_by_host(context, host_state.host)"},{"line_number":41,"context_line":"        metadata_filter_tenant_id \u003d metadata.get(\"filter_tenant_id\", None)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        if metadata_filter_tenant_fid !\u003d None:"},{"line_number":44,"context_line":"            for val in metadata_filter_tenant_id:"},{"line_number":45,"context_line":"                if tenant_id \u003d\u003d val:"},{"line_number":46,"context_line":"                    break"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FWF8%3D","line":43,"updated":"2013-01-27 17:36:54.000000000","message":"Should be metadata_filter_tenant_id","commit_id":"017ced04f06571e24e3caa7c6c8c97d5b176077c"},{"author":{"_account_id":1007,"name":"Nathanael I Burton","email":"nathanael.i.burton.work@gmail.com","username":"mathrock"},"change_message_id":"805daec5a4484cd17d99f5d03f00a3279837b4b6","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        if metadata_filter_tenant_fid !\u003d None:"},{"line_number":44,"context_line":"            for val in metadata_filter_tenant_id:"},{"line_number":45,"context_line":"                if tenant_id \u003d\u003d val:"},{"line_number":46,"context_line":"                    break"},{"line_number":47,"context_line":"            else:"},{"line_number":48,"context_line":"            \tLOG.debug(_(\"%(host_state)s fails tenant id on aggregate\"), "},{"line_number":49,"context_line":"                    locals())"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FWF4%3D","line":46,"updated":"2013-01-27 17:36:54.000000000","message":"I would personally have this return True here instead of the break. Then get rid of the else below and if the tenant_id was not in the list of metadata_filter_tenant_id\u0027s then log the debug message and return False. Otherwise metadata_filter_tenant_id is None so we should allow all tenant_id\u0027s and return True like you do.","commit_id":"017ced04f06571e24e3caa7c6c8c97d5b176077c"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"649eaece115a63eefcf23f9a6b332d600785a24e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2011-2012 OpenStack, LLC."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FUvQ%3D","line":1,"updated":"2013-01-28 23:36:26.000000000","message":"2013?","commit_id":"4aab5752f414cccb0cceddf63cd44e8e05a733f2"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"649eaece115a63eefcf23f9a6b332d600785a24e","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def host_passes(self, host_state, filter_properties):"},{"line_number":27,"context_line":"        \"\"\"Return a list of hosts that can create instances for"},{"line_number":28,"context_line":"        a specific tenant."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"        If a host is in an aggregate that has the metadata key"},{"line_number":31,"context_line":"        \"filter_tenant_id\" it can only create instances from that tenant(s)."}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FUvM%3D","line":28,"updated":"2013-01-28 23:36:26.000000000","message":"doesn\u0027t return a list","commit_id":"4aab5752f414cccb0cceddf63cd44e8e05a733f2"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"649eaece115a63eefcf23f9a6b332d600785a24e","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        tenant_id \u003d props.get(\u0027project_id\u0027)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        context \u003d filter_properties[\u0027context\u0027].elevated()"},{"line_number":42,"context_line":"        metadata \u003d db.aggregate_metadata_get_by_host(context, host_state.host)"},{"line_number":43,"context_line":"        metadata_filter_tenant_id \u003d metadata.get(\"filter_tenant_id\", None)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        if metadata_filter_tenant_id !\u003d None:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FUu0%3D","line":42,"updated":"2013-01-28 23:36:26.000000000","message":"you can use the key option  here so you don\u0027t need the line below","commit_id":"4aab5752f414cccb0cceddf63cd44e8e05a733f2"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"2a9b700937bb79e9c0ef353c2a3139ac63a849a7","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        context \u003d filter_properties[\u0027context\u0027].elevated()"},{"line_number":39,"context_line":"        metadata \u003d db.aggregate_metadata_get_by_host(context, host_state.host)"},{"line_number":40,"context_line":"        metadata_filter_tenant_id \u003d metadata.get(\"filter_tenant_id\", None)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        if metadata_filter_tenant_id !\u003d None:"},{"line_number":43,"context_line":"            if tenant_id not in metadata_filter_tenant_id:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FLNQ%3D","line":40,"updated":"2013-02-04 20:01:16.000000000","message":"Why get all the metadata here and not just the data for the specific key?","commit_id":"4eccec030817ec6370e38f853c89f352d52b3481"},{"author":{"_account_id":2033,"name":"Belmiro Moreira","email":"moreira.belmiro.email.lists@gmail.com","username":"moreira-belmiro-email-lists"},"change_message_id":"ab452d58324b439e262df11d3e897549ef367b3d","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        context \u003d filter_properties[\u0027context\u0027].elevated()"},{"line_number":39,"context_line":"        metadata \u003d db.aggregate_metadata_get_by_host(context, host_state.host)"},{"line_number":40,"context_line":"        metadata_filter_tenant_id \u003d metadata.get(\"filter_tenant_id\", None)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        if metadata_filter_tenant_id !\u003d None:"},{"line_number":43,"context_line":"            if tenant_id not in metadata_filter_tenant_id:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FFj0%3D","line":40,"in_reply_to":"AAAAM3%2F%2FLNQ%3D","updated":"2013-02-07 15:24:42.000000000","message":"You\u0027re right. Thanks, I will update asap.","commit_id":"4eccec030817ec6370e38f853c89f352d52b3481"}]}