)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"576f18a1c0f670cb9410faa7a5ec5f939789dd46","unresolved":false,"context_lines":[{"line_number":14,"context_line":"Changed get_floating_ip_by_address() in FlatManager to return a dict"},{"line_number":15,"context_line":"with expected keys for a floating ip, rather than None."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Updated patch from Andrew Laski and added unit tests."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I4ee1f5cf986b6f3411605aae5c1bc4e8cc2377b1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAM3%2F%2FU5k%3D","line":17,"updated":"2013-01-28 21:57:02.000000000","message":"You can omit this line, though I appreciate the attribution :)","commit_id":"cdf30e75293ef0a2ca9612f44c883a63cd18b20f"}],"nova/network/manager.py":[{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"576f18a1c0f670cb9410faa7a5ec5f939789dd46","unresolved":false,"context_lines":[{"line_number":2054,"context_line":"    @wrap_check_policy"},{"line_number":2055,"context_line":"    def allocate_floating_ip(self, context, project_id, pool):"},{"line_number":2056,"context_line":"        \"\"\"Gets a floating ip from the pool.\"\"\""},{"line_number":2057,"context_line":"        return None"},{"line_number":2058,"context_line":""},{"line_number":2059,"context_line":"    @wrap_check_policy"},{"line_number":2060,"context_line":"    def deallocate_floating_ip(self, context, address,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FU4c%3D","line":2057,"updated":"2013-01-28 21:57:02.000000000","message":"I would move these above migrate_instance_*() and update_dns() so they can fall under the NOTE() on line 2003.","commit_id":"cdf30e75293ef0a2ca9612f44c883a63cd18b20f"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"68f0539d3ed84fce99621e3a96efcc6faa84829a","unresolved":false,"context_lines":[{"line_number":2020,"context_line":""},{"line_number":2021,"context_line":"    def get_floating_ip_by_address(self, context, address):"},{"line_number":2022,"context_line":"        \"\"\"Returns a floating IP as a dict.\"\"\""},{"line_number":2023,"context_line":"        return {"},{"line_number":2024,"context_line":"            \u0027id\u0027: None,"},{"line_number":2025,"context_line":"            \u0027address\u0027: None,"},{"line_number":2026,"context_line":"            \u0027pool\u0027: None,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FCgk%3D","line":2023,"updated":"2013-02-09 23:38:25.000000000","message":"I don\u0027t like this change at all. I don\u0027t think this is a sensible return in the not found case.\n\nLet\u0027s go address where this could return None in the code, and not iterate over a fake none object.","commit_id":"a4865d87fce6a78a479040e5f13327ce519640e0"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"f81772b4f2f77bcaaf51a7d49088a16413b2e150","unresolved":false,"context_lines":[{"line_number":1450,"context_line":"    def get_floating_ip_by_address(self, context, address):"},{"line_number":1451,"context_line":"        \"\"\"Returns a floating IP as a dict.\"\"\""},{"line_number":1452,"context_line":"        # NOTE(vish): This is no longer used but can\u0027t be removed until"},{"line_number":1453,"context_line":"        #             we major version the network_rpcapi to 2.0."},{"line_number":1454,"context_line":"        return None"},{"line_number":1455,"context_line":""},{"line_number":1456,"context_line":"    def get_floating_ips_by_project(self, context):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2B8Rs%3D","line":1453,"updated":"2013-02-13 19:35:20.000000000","message":"By not modifying this there are still errors so the bug is not fully addressed.  It looks like api/openstack/compute/contrib/floating_ips.py and api/ec2/cloud.py make calls that will error because they assume this is a dict with certain keys.  They\u0027ll need to be modified to handle None.","commit_id":"5640dab952b13a4ff7864a74d103e3d14b736b9e"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"b6b76f6e2bba5d453251dd1f5de45a944c03bdb8","unresolved":false,"context_lines":[{"line_number":1450,"context_line":"    def get_floating_ip_by_address(self, context, address):"},{"line_number":1451,"context_line":"        \"\"\"Returns a floating IP as a dict.\"\"\""},{"line_number":1452,"context_line":"        # NOTE(vish): This is no longer used but can\u0027t be removed until"},{"line_number":1453,"context_line":"        #             we major version the network_rpcapi to 2.0."},{"line_number":1454,"context_line":"        return None"},{"line_number":1455,"context_line":""},{"line_number":1456,"context_line":"    def get_floating_ips_by_project(self, context):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2B3vc%3D","line":1453,"in_reply_to":"AAAAM3%2F%2B3xU%3D","updated":"2013-02-15 21:59:45.000000000","message":"Ha, I guess the NOTE right above should have clued me in.  I was just going back to what I remembered from my original work.","commit_id":"5640dab952b13a4ff7864a74d103e3d14b736b9e"},{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"6e85114fd2d01e788dd29fc09a2137424df9a3b1","unresolved":false,"context_lines":[{"line_number":1450,"context_line":"    def get_floating_ip_by_address(self, context, address):"},{"line_number":1451,"context_line":"        \"\"\"Returns a floating IP as a dict.\"\"\""},{"line_number":1452,"context_line":"        # NOTE(vish): This is no longer used but can\u0027t be removed until"},{"line_number":1453,"context_line":"        #             we major version the network_rpcapi to 2.0."},{"line_number":1454,"context_line":"        return None"},{"line_number":1455,"context_line":""},{"line_number":1456,"context_line":"    def get_floating_ips_by_project(self, context):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2B3xU%3D","line":1453,"in_reply_to":"AAAAM3%2F%2B8Rs%3D","updated":"2013-02-15 21:48:33.000000000","message":"These are actually now done in network/api and so no rpc will occur for these commands. I think we\u0027re fine leaving these","commit_id":"5640dab952b13a4ff7864a74d103e3d14b736b9e"}]}