)]}'
{"nova/virt/libvirt/volume/volume.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"bb21a9eef6355224f4ebef3d432efcb6471b56ce","unresolved":false,"context_lines":[{"line_number":285,"context_line":"        self._delete_secret_by_name(connection_info)"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"class LibvirtRBDVolumeDriver(LibvirtNetVolumeDriver):"},{"line_number":289,"context_line":"    \"\"\"Driver to attach encrypted rbd volumes to libvirt. When the volume is not"},{"line_number":290,"context_line":"       encrypted we fall back to LibvirtNetVolumeDriver as libvirt has native"},{"line_number":291,"context_line":"       support for such volumes."}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_5bcd18b6","line":288,"updated":"2015-07-30 17:45:31.000000000","message":"This should live in it\u0027s own module now, nova.virt.libvirt.volume.rbd, like the series here:\n\nhttps://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/consolidate-libvirt-fs-volume-drivers,n,z","commit_id":"cbbfe451617bacdd3b657fe405d31738c3e79954"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"bb21a9eef6355224f4ebef3d432efcb6471b56ce","unresolved":false,"context_lines":[{"line_number":300,"context_line":"        super(LibvirtRBDVolumeDriver, self).__init__(connection)"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"    def get_config(self, connection_info, disk_info):"},{"line_number":303,"context_line":"        if connection_info[\u0027data\u0027][\u0027encrypted\u0027] is True:"},{"line_number":304,"context_line":"            self.is_block_dev \u003d True"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"            conf \u003d super(LibvirtNetVolumeDriver,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_db67e8b5","line":303,"updated":"2015-07-30 17:45:31.000000000","message":"Depending on the version of cinder-volume, you may not have \u0027enabled\u0027 in \u0027data\u0027 so I\u0027d do:\n\nif connection_info[\u0027data\u0027].get(\u0027encrypted\u0027, False)\n\nAlso, don\u0027t need \u0027is True\u0027.","commit_id":"cbbfe451617bacdd3b657fe405d31738c3e79954"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"bb21a9eef6355224f4ebef3d432efcb6471b56ce","unresolved":false,"context_lines":[{"line_number":314,"context_line":"                         self).get_config(connection_info, disk_info)"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"    def connect_volume(self, connection_info, disk_info):"},{"line_number":317,"context_line":"        if connection_info[\u0027data\u0027][\u0027encrypted\u0027] is True:"},{"line_number":318,"context_line":"            utils.execute(\u0027rbd\u0027,"},{"line_number":319,"context_line":"                          \u0027--id\u0027, connection_info[\u0027data\u0027][\u0027auth_username\u0027],"},{"line_number":320,"context_line":"                          \u0027map\u0027, connection_info[\u0027data\u0027][\u0027name\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_dbfe08ae","line":317,"updated":"2015-07-30 17:45:31.000000000","message":"ditto","commit_id":"cbbfe451617bacdd3b657fe405d31738c3e79954"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"bb21a9eef6355224f4ebef3d432efcb6471b56ce","unresolved":false,"context_lines":[{"line_number":315,"context_line":""},{"line_number":316,"context_line":"    def connect_volume(self, connection_info, disk_info):"},{"line_number":317,"context_line":"        if connection_info[\u0027data\u0027][\u0027encrypted\u0027] is True:"},{"line_number":318,"context_line":"            utils.execute(\u0027rbd\u0027,"},{"line_number":319,"context_line":"                          \u0027--id\u0027, connection_info[\u0027data\u0027][\u0027auth_username\u0027],"},{"line_number":320,"context_line":"                          \u0027map\u0027, connection_info[\u0027data\u0027][\u0027name\u0027],"},{"line_number":321,"context_line":"                           run_as_root\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_dbecc8f5","line":318,"updated":"2015-07-30 17:45:31.000000000","message":"This stuff should probably all exist in os-brick now and then nova just interfaces with os-brick.","commit_id":"cbbfe451617bacdd3b657fe405d31738c3e79954"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"bb21a9eef6355224f4ebef3d432efcb6471b56ce","unresolved":false,"context_lines":[{"line_number":334,"context_line":"    def disconnect_volume(self, connection_info, disk_dev):"},{"line_number":335,"context_line":"        super(LibvirtRBDVolumeDriver,"},{"line_number":336,"context_line":"              self).disconnect_volume(connection_info, disk_dev)"},{"line_number":337,"context_line":"        if connection_info[\u0027data\u0027][\u0027encrypted\u0027] is True:"},{"line_number":338,"context_line":"            symlink_dev \u003d \u0027/dev/disk/by-path/rbd-volume-%s\u0027 % \\"},{"line_number":339,"context_line":"                            connection_info[\u0027data\u0027][\u0027volume_id\u0027]"},{"line_number":340,"context_line":"            utils.execute(\u0027rm\u0027, symlink_dev, run_as_root\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_bb18dc1f","line":337,"updated":"2015-07-30 17:45:31.000000000","message":"ditto - you might want to just create a static private method to check this rather than duplicate in all of the methods.","commit_id":"cbbfe451617bacdd3b657fe405d31738c3e79954"}]}