)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"f656cdaf038d91153f77aba37f1e77759e43c965","unresolved":false,"context_lines":[{"line_number":7,"context_line":"xenapi: Ax unecessary `block_device_info` params"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In the XenDriver, we determine which volumes to detach using the `osvol`"},{"line_number":10,"context_line":"other_config, rendering `block_device_info`."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"`destroy` still needs to take it as part of the virt-driver API, but"},{"line_number":13,"context_line":"internal functions don\u0027t need it."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAM3%2F%2FT2s%3D","line":10,"updated":"2013-01-29 15:21:50.000000000","message":"Looks like maybe you left out a word at the end of the sentence.","commit_id":"2237f653e2150a27ef59fcef9c5d79efe74fc892"}],"nova/virt/xenapi/vmops.py":[{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"f656cdaf038d91153f77aba37f1e77759e43c965","unresolved":false,"context_lines":[{"line_number":183,"context_line":"    def confirm_migration(self, migration, instance, network_info):"},{"line_number":184,"context_line":"        name_label \u003d self._get_orig_vm_name_label(instance)"},{"line_number":185,"context_line":"        vm_ref \u003d vm_utils.lookup(self._session, name_label)"},{"line_number":186,"context_line":"        return self._destroy(instance, vm_ref, network_info\u003dnetwork_info)"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    def _attach_mapped_block_devices(self, instance, block_device_info):"},{"line_number":189,"context_line":"        # We are attaching these volumes before start (no hotplugging)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FT2I%3D","line":186,"updated":"2013-01-29 15:21:50.000000000","message":"Is there a reason for passing network_info as a keyword arg now, and/or not also changing the other two?","commit_id":"2237f653e2150a27ef59fcef9c5d79efe74fc892"},{"author":{"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},"change_message_id":"2c30c4ab38a19a31f06c532a21c1569804c1b077","unresolved":false,"context_lines":[{"line_number":183,"context_line":"    def confirm_migration(self, migration, instance, network_info):"},{"line_number":184,"context_line":"        name_label \u003d self._get_orig_vm_name_label(instance)"},{"line_number":185,"context_line":"        vm_ref \u003d vm_utils.lookup(self._session, name_label)"},{"line_number":186,"context_line":"        return self._destroy(instance, vm_ref, network_info\u003dnetwork_info)"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    def _attach_mapped_block_devices(self, instance, block_device_info):"},{"line_number":189,"context_line":"        # We are attaching these volumes before start (no hotplugging)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FTug%3D","line":186,"in_reply_to":"AAAAM3%2F%2FT2I%3D","updated":"2013-01-29 16:10:05.000000000","message":"instance and vm_ref are pos args according to the signature, but network_info is a kwarg, this is just a small cleanup so the calling code is consistent w/ that fact.","commit_id":"2237f653e2150a27ef59fcef9c5d79efe74fc892"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"16492a6d8f0cafea6813fbbf3ded5b78cdf7652a","unresolved":false,"context_lines":[{"line_number":1102,"context_line":"        if rescue_vm_ref:"},{"line_number":1103,"context_line":"            self._destroy_rescue_instance(rescue_vm_ref, vm_ref)"},{"line_number":1104,"context_line":""},{"line_number":1105,"context_line":"        # NOTE(sirp): `block_device_info` is not used, information about which"},{"line_number":1106,"context_line":"        # volumes should be detached is determined by the"},{"line_number":1107,"context_line":"        # VBD.other_config[\u0027osvol\u0027] attribute"},{"line_number":1108,"context_line":"        return self._destroy(instance, vm_ref, network_info\u003dnetwork_info,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FRMo%3D","line":1105,"updated":"2013-01-30 21:04:07.000000000","message":"This comment makes sense while I\u0027m reviewing the code and see the removal of block_device_info.  But it seems like it may end up being confusing later since it references a variable that doesn\u0027t exist here or in self._destroy().","commit_id":"21b4531927ab786ec4c45ee26d94fccfb45bc951"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"3cbcb9c15f48449681be6f8faa9ce34cd5dafc16","unresolved":false,"context_lines":[{"line_number":1102,"context_line":"        if rescue_vm_ref:"},{"line_number":1103,"context_line":"            self._destroy_rescue_instance(rescue_vm_ref, vm_ref)"},{"line_number":1104,"context_line":""},{"line_number":1105,"context_line":"        # NOTE(sirp): `block_device_info` is not used, information about which"},{"line_number":1106,"context_line":"        # volumes should be detached is determined by the"},{"line_number":1107,"context_line":"        # VBD.other_config[\u0027osvol\u0027] attribute"},{"line_number":1108,"context_line":"        return self._destroy(instance, vm_ref, network_info\u003dnetwork_info,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FRIs%3D","line":1105,"in_reply_to":"AAAAM3%2F%2FRJk%3D","updated":"2013-01-30 21:50:44.000000000","message":"My mistake.  I thought this was in _destroy_vdis, due to missing the common lines in gerrit.","commit_id":"21b4531927ab786ec4c45ee26d94fccfb45bc951"},{"author":{"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},"change_message_id":"35f1efe59360524b6b6b4c9e64f3ea86346f4005","unresolved":false,"context_lines":[{"line_number":1102,"context_line":"        if rescue_vm_ref:"},{"line_number":1103,"context_line":"            self._destroy_rescue_instance(rescue_vm_ref, vm_ref)"},{"line_number":1104,"context_line":""},{"line_number":1105,"context_line":"        # NOTE(sirp): `block_device_info` is not used, information about which"},{"line_number":1106,"context_line":"        # volumes should be detached is determined by the"},{"line_number":1107,"context_line":"        # VBD.other_config[\u0027osvol\u0027] attribute"},{"line_number":1108,"context_line":"        return self._destroy(instance, vm_ref, network_info\u003dnetwork_info,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FRJk%3D","line":1105,"in_reply_to":"AAAAM3%2F%2FRMo%3D","updated":"2013-01-30 21:46:52.000000000","message":"It\u0027s not obvious from the diff in gerrit, but `block_device_info` is passed into this function (`destroy`), so the intent of that note was just to explain why we\u0027re dropping it on the floor here.","commit_id":"21b4531927ab786ec4c45ee26d94fccfb45bc951"}]}