)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"ccb654c466930fb93405a49d1fb5c16d6c9e7721","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        #             and re-document the module docstring"},{"line_number":155,"context_line":"        if not compute_driver:"},{"line_number":156,"context_line":"            compute_driver \u003d FLAGS.compute_driver"},{"line_number":157,"context_line":"        LOG.debug(\"COMPUTE DRIVER:%s\", compute_driver)"},{"line_number":158,"context_line":"        try:"},{"line_number":159,"context_line":"            self.driver \u003d utils.check_isinstance("},{"line_number":160,"context_line":"                                        utils.import_object(compute_driver),"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAADH%2F%2F%2F4E%3D","line":157,"updated":"2011-12-28 20:29:08.000000000","message":"I don\u0027t think this log message belongs here. It would make more sense to log all of the flags on startup. \n\nIf you still think this belongs here, can you at least change the text to be something like \u0027Attempting to import compute driver \u0027%s\u0027? The string itself also needs to be wrapped with _( )","commit_id":"640428aa5042e931dfb499ef26481e8bc1f9ec46"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"41dd37fc2c81f2f32d81cfee7e15488ea6b0a004","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        #             and re-document the module docstring"},{"line_number":155,"context_line":"        if not compute_driver:"},{"line_number":156,"context_line":"            compute_driver \u003d FLAGS.compute_driver"},{"line_number":157,"context_line":"        LOG.debug(\"COMPUTE DRIVER:%s\", compute_driver)"},{"line_number":158,"context_line":"        try:"},{"line_number":159,"context_line":"            self.driver \u003d utils.check_isinstance("},{"line_number":160,"context_line":"                                        utils.import_object(compute_driver),"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAD3%2F%2F%2FgU%3D","line":157,"in_reply_to":"AAAADH%2F%2F%2F4E%3D","updated":"2012-01-10 14:36:43.000000000","message":"This is just a leftover debug line. I should have removed it (I tipycally ensure there\u0027s a PEP8 violation in my debug lines, but for some reason my fingers are becoming pep8-proof!)","commit_id":"640428aa5042e931dfb499ef26481e8bc1f9ec46"}],"nova/network/linux_net.py":[{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"ccb654c466930fb93405a49d1fb5c16d6c9e7721","unresolved":false,"context_lines":[{"line_number":311,"context_line":"                self.execute(\u0027%s-restore\u0027 % (cmd,), run_as_root\u003dTrue,"},{"line_number":312,"context_line":"                             process_input\u003d\u0027\\n\u0027.join(new_filter),"},{"line_number":313,"context_line":"                             attempts\u003d5)"},{"line_number":314,"context_line":"        LOG.debug(\"IPTablesManager.Apply completed with succeess\")"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"    def _modify_rules(self, current_lines, table, binary\u003dNone):"},{"line_number":317,"context_line":"        unwrapped_chains \u003d table.unwrapped_chains"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAADH%2F%2F%2F4A%3D","line":314,"updated":"2011-12-28 20:29:08.000000000","message":"Can you wrap this sting with _( ) and make the A in Apply lowercase?","commit_id":"640428aa5042e931dfb499ef26481e8bc1f9ec46"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"41dd37fc2c81f2f32d81cfee7e15488ea6b0a004","unresolved":false,"context_lines":[{"line_number":311,"context_line":"                self.execute(\u0027%s-restore\u0027 % (cmd,), run_as_root\u003dTrue,"},{"line_number":312,"context_line":"                             process_input\u003d\u0027\\n\u0027.join(new_filter),"},{"line_number":313,"context_line":"                             attempts\u003d5)"},{"line_number":314,"context_line":"        LOG.debug(\"IPTablesManager.Apply completed with succeess\")"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"    def _modify_rules(self, current_lines, table, binary\u003dNone):"},{"line_number":317,"context_line":"        unwrapped_chains \u003d table.unwrapped_chains"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAD3%2F%2F%2FgQ%3D","line":314,"in_reply_to":"AAAADH%2F%2F%2F4A%3D","updated":"2012-01-10 14:36:43.000000000","message":"sure! (and maybe fix the typo as well!)","commit_id":"640428aa5042e931dfb499ef26481e8bc1f9ec46"}],"nova/tests/test_libvirt.py":[{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"ccb654c466930fb93405a49d1fb5c16d6c9e7721","unresolved":false,"context_lines":[{"line_number":1363,"context_line":"        self.stubs.Set(db, \u0027instance_get_fixed_addresses\u0027, get_fixed_ips)"},{"line_number":1364,"context_line":"        self.fw.prepare_instance_filter(instance_ref, network_info)"},{"line_number":1365,"context_line":"        self.fw.apply_instance_filter(instance_ref, network_info)"},{"line_number":1366,"context_line":""},{"line_number":1367,"context_line":"        in_rules \u003d filter(lambda l: not l.startswith(\u0027#\u0027),"},{"line_number":1368,"context_line":"                          self.in_filter_rules)"},{"line_number":1369,"context_line":"        for rule in in_rules:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAADH%2F%2F%2F38%3D","side":"PARENT","line":1366,"updated":"2011-12-28 20:29:08.000000000","message":"No need to do this. Try to minimize arbitrary changes to unrelated code.","commit_id":"5bcaecdc7d42b8a4aa2f16e96c064869438d6a12"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"41dd37fc2c81f2f32d81cfee7e15488ea6b0a004","unresolved":false,"context_lines":[{"line_number":1363,"context_line":"        self.stubs.Set(db, \u0027instance_get_fixed_addresses\u0027, get_fixed_ips)"},{"line_number":1364,"context_line":"        self.fw.prepare_instance_filter(instance_ref, network_info)"},{"line_number":1365,"context_line":"        self.fw.apply_instance_filter(instance_ref, network_info)"},{"line_number":1366,"context_line":""},{"line_number":1367,"context_line":"        in_rules \u003d filter(lambda l: not l.startswith(\u0027#\u0027),"},{"line_number":1368,"context_line":"                          self.in_filter_rules)"},{"line_number":1369,"context_line":"        for rule in in_rules:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAD3%2F%2F%2FgM%3D","side":"PARENT","line":1366,"in_reply_to":"AAAADH%2F%2F%2F38%3D","updated":"2012-01-10 14:36:43.000000000","message":"Sorry I did not mean to do it.","commit_id":"5bcaecdc7d42b8a4aa2f16e96c064869438d6a12"}],"nova/tests/test_xenapi.py":[{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"ccb654c466930fb93405a49d1fb5c16d6c9e7721","unresolved":false,"context_lines":[{"line_number":1306,"context_line":"        self.network \u003d utils.import_object(FLAGS.network_manager)"},{"line_number":1307,"context_line":"        self.conn \u003d xenapi_conn.get_connection(False)"},{"line_number":1308,"context_line":"        self.fw \u003d self.conn._vmops.firewall_driver"},{"line_number":1309,"context_line":"        #self.fw \u003d firewall.Dom0IptablesFirewallDriver(self.conn._session)"},{"line_number":1310,"context_line":""},{"line_number":1311,"context_line":"    def _create_instance_ref(self):"},{"line_number":1312,"context_line":"        return db.instance_create(self.context,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAADH%2F%2F%2F34%3D","line":1309,"updated":"2011-12-28 20:29:08.000000000","message":"Why is this line commented out? It should be able to be removed, along with the related \u0027firewall\u0027 import at the top of the file.","commit_id":"640428aa5042e931dfb499ef26481e8bc1f9ec46"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"41dd37fc2c81f2f32d81cfee7e15488ea6b0a004","unresolved":false,"context_lines":[{"line_number":1306,"context_line":"        self.network \u003d utils.import_object(FLAGS.network_manager)"},{"line_number":1307,"context_line":"        self.conn \u003d xenapi_conn.get_connection(False)"},{"line_number":1308,"context_line":"        self.fw \u003d self.conn._vmops.firewall_driver"},{"line_number":1309,"context_line":"        #self.fw \u003d firewall.Dom0IptablesFirewallDriver(self.conn._session)"},{"line_number":1310,"context_line":""},{"line_number":1311,"context_line":"    def _create_instance_ref(self):"},{"line_number":1312,"context_line":"        return db.instance_create(self.context,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAD3%2F%2F%2FgI%3D","line":1309,"in_reply_to":"AAAADH%2F%2F%2F34%3D","updated":"2012-01-10 14:36:43.000000000","message":"Sure","commit_id":"640428aa5042e931dfb499ef26481e8bc1f9ec46"}],"nova/tests/xenapi/stubs.py":[{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"ccb654c466930fb93405a49d1fb5c16d6c9e7721","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                  lambda s, url: cls(url))"},{"line_number":67,"context_line":"    else:"},{"line_number":68,"context_line":"        stubs.Set(xenapi_conn.XenAPISession, \u0027_create_session\u0027,"},{"line_number":69,"context_line":"                  lambda s, url: cls(url, **opt_args))"},{"line_number":70,"context_line":"    stubs.Set(xenapi_conn.XenAPISession, \u0027get_imported_xenapi\u0027,"},{"line_number":71,"context_line":"                       fake_import)"},{"line_number":72,"context_line":"    if product_version is None:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAADH%2F%2F%2F30%3D","line":69,"updated":"2011-12-28 20:29:08.000000000","message":"You should always be able to use the code in this \u0027else\u0027 block. It doesnt hurt to unpack an empty dict into the args.","commit_id":"640428aa5042e931dfb499ef26481e8bc1f9ec46"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"41dd37fc2c81f2f32d81cfee7e15488ea6b0a004","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                  lambda s, url: cls(url))"},{"line_number":67,"context_line":"    else:"},{"line_number":68,"context_line":"        stubs.Set(xenapi_conn.XenAPISession, \u0027_create_session\u0027,"},{"line_number":69,"context_line":"                  lambda s, url: cls(url, **opt_args))"},{"line_number":70,"context_line":"    stubs.Set(xenapi_conn.XenAPISession, \u0027get_imported_xenapi\u0027,"},{"line_number":71,"context_line":"                       fake_import)"},{"line_number":72,"context_line":"    if product_version is None:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAD3%2F%2F%2FgA%3D","line":69,"in_reply_to":"AAAADH%2F%2F%2F30%3D","updated":"2012-01-10 14:36:43.000000000","message":"That\u0027s right. My mind is still quite strongly-typed!","commit_id":"640428aa5042e931dfb499ef26481e8bc1f9ec46"},{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"ccb654c466930fb93405a49d1fb5c16d6c9e7721","unresolved":false,"context_lines":[{"line_number":157,"context_line":"    \"\"\" Stubs out a XenAPISession for VM tests \"\"\""},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    _fake_iptables_save_output \u003d \\"},{"line_number":160,"context_line":"    \"# Generated by iptables-save v1.4.10 on Sun Nov  6 22:49:02 2011\\n\""},{"line_number":161,"context_line":"    \"*filter\\n\""},{"line_number":162,"context_line":"    \":INPUT ACCEPT [0:0]\\n\""},{"line_number":163,"context_line":"    \":FORWARD ACCEPT [0:0]\\n\""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAADH%2F%2F%2F3w%3D","line":160,"updated":"2011-12-28 20:29:08.000000000","message":"Can you tab this block over twice?","commit_id":"640428aa5042e931dfb499ef26481e8bc1f9ec46"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"41dd37fc2c81f2f32d81cfee7e15488ea6b0a004","unresolved":false,"context_lines":[{"line_number":157,"context_line":"    \"\"\" Stubs out a XenAPISession for VM tests \"\"\""},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    _fake_iptables_save_output \u003d \\"},{"line_number":160,"context_line":"    \"# Generated by iptables-save v1.4.10 on Sun Nov  6 22:49:02 2011\\n\""},{"line_number":161,"context_line":"    \"*filter\\n\""},{"line_number":162,"context_line":"    \":INPUT ACCEPT [0:0]\\n\""},{"line_number":163,"context_line":"    \":FORWARD ACCEPT [0:0]\\n\""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAD3%2F%2F%2FgE%3D","line":160,"in_reply_to":"AAAADH%2F%2F%2F3w%3D","updated":"2012-01-10 14:36:43.000000000","message":"Definitely","commit_id":"640428aa5042e931dfb499ef26481e8bc1f9ec46"}],"nova/virt/connection.py":[{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"ccb654c466930fb93405a49d1fb5c16d6c9e7721","unresolved":false,"context_lines":[{"line_number":26,"context_line":"from nova import utils"},{"line_number":27,"context_line":"from nova.virt import driver"},{"line_number":28,"context_line":"from nova.virt import fake"},{"line_number":29,"context_line":"from nova.virt import firewall"},{"line_number":30,"context_line":"from nova.virt import hyperv"},{"line_number":31,"context_line":"from nova.virt.libvirt import connection as libvirt_conn"},{"line_number":32,"context_line":"from nova.virt import vmwareapi_conn"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAADH%2F%2F%2F3s%3D","line":29,"updated":"2011-12-28 20:29:08.000000000","message":"This doesn\u0027t apear to be used.","commit_id":"640428aa5042e931dfb499ef26481e8bc1f9ec46"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"41dd37fc2c81f2f32d81cfee7e15488ea6b0a004","unresolved":false,"context_lines":[{"line_number":26,"context_line":"from nova import utils"},{"line_number":27,"context_line":"from nova.virt import driver"},{"line_number":28,"context_line":"from nova.virt import fake"},{"line_number":29,"context_line":"from nova.virt import firewall"},{"line_number":30,"context_line":"from nova.virt import hyperv"},{"line_number":31,"context_line":"from nova.virt.libvirt import connection as libvirt_conn"},{"line_number":32,"context_line":"from nova.virt import vmwareapi_conn"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAD3%2F%2F%2Ff8%3D","line":29,"in_reply_to":"AAAADH%2F%2F%2F3s%3D","updated":"2012-01-10 14:36:43.000000000","message":"...and for this it will be eliminated!","commit_id":"640428aa5042e931dfb499ef26481e8bc1f9ec46"}],"nova/virt/libvirt/connection.py":[{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"ccb654c466930fb93405a49d1fb5c16d6c9e7721","unresolved":false,"context_lines":[{"line_number":66,"context_line":"from nova.virt import disk"},{"line_number":67,"context_line":"from nova.virt import driver"},{"line_number":68,"context_line":"from nova.virt import images"},{"line_number":69,"context_line":"from nova.virt import netutils"},{"line_number":70,"context_line":"from nova.virt.libvirt import utils as libvirt_utils"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAADH%2F%2F%2F3k%3D","line":69,"updated":"2011-12-28 20:29:08.000000000","message":"This import is not used. Please remove it.","commit_id":"640428aa5042e931dfb499ef26481e8bc1f9ec46"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"41dd37fc2c81f2f32d81cfee7e15488ea6b0a004","unresolved":false,"context_lines":[{"line_number":66,"context_line":"from nova.virt import disk"},{"line_number":67,"context_line":"from nova.virt import driver"},{"line_number":68,"context_line":"from nova.virt import images"},{"line_number":69,"context_line":"from nova.virt import netutils"},{"line_number":70,"context_line":"from nova.virt.libvirt import utils as libvirt_utils"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAD3%2F%2F%2Ff4%3D","line":69,"in_reply_to":"AAAADH%2F%2F%2F3k%3D","updated":"2012-01-10 14:36:43.000000000","message":"sure","commit_id":"640428aa5042e931dfb499ef26481e8bc1f9ec46"}],"nova/virt/libvirt/firewall.py":[{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"ccb654c466930fb93405a49d1fb5c16d6c9e7721","unresolved":false,"context_lines":[{"line_number":18,"context_line":"#    under the License."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"import nova.virt.firewall as base_firewall"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from eventlet import tpool"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAADH%2F%2F%2F3g%3D","line":21,"updated":"2011-12-28 20:29:08.000000000","message":"this import belongs down in the block of nova-specific imports below utils.","commit_id":"640428aa5042e931dfb499ef26481e8bc1f9ec46"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"41dd37fc2c81f2f32d81cfee7e15488ea6b0a004","unresolved":false,"context_lines":[{"line_number":18,"context_line":"#    under the License."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"import nova.virt.firewall as base_firewall"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from eventlet import tpool"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAD3%2F%2F%2Ff0%3D","line":21,"in_reply_to":"AAAADH%2F%2F%2F3g%3D","updated":"2012-01-10 14:36:43.000000000","message":"definitely","commit_id":"640428aa5042e931dfb499ef26481e8bc1f9ec46"}],"nova/virt/libvirt/vif.py":[{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"ccb654c466930fb93405a49d1fb5c16d6c9e7721","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from nova import flags"},{"line_number":24,"context_line":"from nova import log as logging"},{"line_number":25,"context_line":"from nova import utils"},{"line_number":26,"context_line":"from nova.network import linux_net"},{"line_number":27,"context_line":"from nova.virt import netutils"},{"line_number":28,"context_line":"from nova.virt.vif import VIFDriver"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAADH%2F%2F%2F3Y%3D","line":26,"updated":"2011-12-28 20:29:08.000000000","message":"This import was in the correct place. Please revert this change.","commit_id":"640428aa5042e931dfb499ef26481e8bc1f9ec46"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"41dd37fc2c81f2f32d81cfee7e15488ea6b0a004","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from nova import flags"},{"line_number":24,"context_line":"from nova import log as logging"},{"line_number":25,"context_line":"from nova import utils"},{"line_number":26,"context_line":"from nova.network import linux_net"},{"line_number":27,"context_line":"from nova.virt import netutils"},{"line_number":28,"context_line":"from nova.virt.vif import VIFDriver"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAD3%2F%2F%2Ffw%3D","line":26,"in_reply_to":"AAAADH%2F%2F%2F3Y%3D","updated":"2012-01-10 14:36:43.000000000","message":"Done","commit_id":"640428aa5042e931dfb499ef26481e8bc1f9ec46"}],"nova/virt/xenapi/vmops.py":[{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"ccb654c466930fb93405a49d1fb5c16d6c9e7721","unresolved":false,"context_lines":[{"line_number":427,"context_line":"        instance_name \u003d instance.name"},{"line_number":428,"context_line":"        LOG.info(_(\u0027Spawning VM %(instance_name)s created %(vm_ref)s.\u0027)"},{"line_number":429,"context_line":"                 % locals())"},{"line_number":430,"context_line":""},{"line_number":431,"context_line":"        ctx \u003d nova_context.get_admin_context()"},{"line_number":432,"context_line":"        agent_build \u003d db.agent_build_get_by_triple(ctx, \u0027xen\u0027,"},{"line_number":433,"context_line":"                              instance.os_type, instance.architecture)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAADH%2F%2F%2F3A%3D","side":"PARENT","line":430,"updated":"2011-12-28 20:29:08.000000000","message":"This change was unnecessary.","commit_id":"5bcaecdc7d42b8a4aa2f16e96c064869438d6a12"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"41dd37fc2c81f2f32d81cfee7e15488ea6b0a004","unresolved":false,"context_lines":[{"line_number":427,"context_line":"        instance_name \u003d instance.name"},{"line_number":428,"context_line":"        LOG.info(_(\u0027Spawning VM %(instance_name)s created %(vm_ref)s.\u0027)"},{"line_number":429,"context_line":"                 % locals())"},{"line_number":430,"context_line":""},{"line_number":431,"context_line":"        ctx \u003d nova_context.get_admin_context()"},{"line_number":432,"context_line":"        agent_build \u003d db.agent_build_get_by_triple(ctx, \u0027xen\u0027,"},{"line_number":433,"context_line":"                              instance.os_type, instance.architecture)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAD3%2F%2F%2Ffg%3D","side":"PARENT","line":430,"in_reply_to":"AAAADH%2F%2F%2F3A%3D","updated":"2012-01-10 14:36:43.000000000","message":"Done","commit_id":"5bcaecdc7d42b8a4aa2f16e96c064869438d6a12"},{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"ccb654c466930fb93405a49d1fb5c16d6c9e7721","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        VMHelper.XenAPI \u003d self.XenAPI"},{"line_number":97,"context_line":"        LOG.debug(\"Firewall driver:%s\", FLAGS.firewall_driver)"},{"line_number":98,"context_line":"        fw_class \u003d utils.import_class(FLAGS.firewall_driver)"},{"line_number":99,"context_line":"        LOG.debug(\"HERE-1\")"},{"line_number":100,"context_line":"        self.firewall_driver \u003d fw_class(xenapi_session\u003dself._session)"},{"line_number":101,"context_line":"        LOG.debug(\"HERE-2\")"},{"line_number":102,"context_line":"        self.vif_driver \u003d utils.import_object(FLAGS.xenapi_vif_driver)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAADH%2F%2F%2F3I%3D","line":99,"updated":"2011-12-28 20:29:08.000000000","message":"Please remove all of these debugging statements.","commit_id":"640428aa5042e931dfb499ef26481e8bc1f9ec46"},{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"8ab7e93c43b6e89b3e16124fb2edb09b66312ccc","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        VMHelper.XenAPI \u003d self.XenAPI"},{"line_number":97,"context_line":"        LOG.debug(\"Firewall driver:%s\", FLAGS.firewall_driver)"},{"line_number":98,"context_line":"        fw_class \u003d utils.import_class(FLAGS.firewall_driver)"},{"line_number":99,"context_line":"        LOG.debug(\"HERE-1\")"},{"line_number":100,"context_line":"        self.firewall_driver \u003d fw_class(xenapi_session\u003dself._session)"},{"line_number":101,"context_line":"        LOG.debug(\"HERE-2\")"},{"line_number":102,"context_line":"        self.vif_driver \u003d utils.import_object(FLAGS.xenapi_vif_driver)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAADH%2F%2F%2F4c%3D","line":99,"updated":"2011-12-29 02:57:43.000000000","message":"Probably best to remove this LOG.debug statement.","commit_id":"640428aa5042e931dfb499ef26481e8bc1f9ec46"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"41dd37fc2c81f2f32d81cfee7e15488ea6b0a004","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        VMHelper.XenAPI \u003d self.XenAPI"},{"line_number":97,"context_line":"        LOG.debug(\"Firewall driver:%s\", FLAGS.firewall_driver)"},{"line_number":98,"context_line":"        fw_class \u003d utils.import_class(FLAGS.firewall_driver)"},{"line_number":99,"context_line":"        LOG.debug(\"HERE-1\")"},{"line_number":100,"context_line":"        self.firewall_driver \u003d fw_class(xenapi_session\u003dself._session)"},{"line_number":101,"context_line":"        LOG.debug(\"HERE-2\")"},{"line_number":102,"context_line":"        self.vif_driver \u003d utils.import_object(FLAGS.xenapi_vif_driver)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAD3%2F%2F%2Ffs%3D","line":99,"in_reply_to":"AAAADH%2F%2F%2F3I%3D","updated":"2012-01-10 14:36:43.000000000","message":"Done","commit_id":"640428aa5042e931dfb499ef26481e8bc1f9ec46"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"41dd37fc2c81f2f32d81cfee7e15488ea6b0a004","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        VMHelper.XenAPI \u003d self.XenAPI"},{"line_number":97,"context_line":"        LOG.debug(\"Firewall driver:%s\", FLAGS.firewall_driver)"},{"line_number":98,"context_line":"        fw_class \u003d utils.import_class(FLAGS.firewall_driver)"},{"line_number":99,"context_line":"        LOG.debug(\"HERE-1\")"},{"line_number":100,"context_line":"        self.firewall_driver \u003d fw_class(xenapi_session\u003dself._session)"},{"line_number":101,"context_line":"        LOG.debug(\"HERE-2\")"},{"line_number":102,"context_line":"        self.vif_driver \u003d utils.import_object(FLAGS.xenapi_vif_driver)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAD3%2F%2F%2Ffo%3D","line":99,"in_reply_to":"AAAADH%2F%2F%2F4c%3D","updated":"2012-01-10 14:36:43.000000000","message":"Done","commit_id":"640428aa5042e931dfb499ef26481e8bc1f9ec46"},{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"8ab7e93c43b6e89b3e16124fb2edb09b66312ccc","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        fw_class \u003d utils.import_class(FLAGS.firewall_driver)"},{"line_number":99,"context_line":"        LOG.debug(\"HERE-1\")"},{"line_number":100,"context_line":"        self.firewall_driver \u003d fw_class(xenapi_session\u003dself._session)"},{"line_number":101,"context_line":"        LOG.debug(\"HERE-2\")"},{"line_number":102,"context_line":"        self.vif_driver \u003d utils.import_object(FLAGS.xenapi_vif_driver)"},{"line_number":103,"context_line":"        self._product_version \u003d product_version"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAADH%2F%2F%2F4U%3D","line":101,"updated":"2011-12-29 02:57:43.000000000","message":"Probably best to remove this LOG.debug statement?","commit_id":"640428aa5042e931dfb499ef26481e8bc1f9ec46"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"41dd37fc2c81f2f32d81cfee7e15488ea6b0a004","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        fw_class \u003d utils.import_class(FLAGS.firewall_driver)"},{"line_number":99,"context_line":"        LOG.debug(\"HERE-1\")"},{"line_number":100,"context_line":"        self.firewall_driver \u003d fw_class(xenapi_session\u003dself._session)"},{"line_number":101,"context_line":"        LOG.debug(\"HERE-2\")"},{"line_number":102,"context_line":"        self.vif_driver \u003d utils.import_object(FLAGS.xenapi_vif_driver)"},{"line_number":103,"context_line":"        self._product_version \u003d product_version"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAD3%2F%2F%2Ffk%3D","line":101,"in_reply_to":"AAAADH%2F%2F%2F4U%3D","updated":"2012-01-10 14:36:43.000000000","message":"Done","commit_id":"640428aa5042e931dfb499ef26481e8bc1f9ec46"}],"plugins/xenserver/xenapi/etc/xapi.d/plugins/xenhost":[{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"ccb654c466930fb93405a49d1fb5c16d6c9e7721","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    # or a sequence of string"},{"line_number":83,"context_line":"    if not hasattr(cmd,\u0027__iter__\u0027):"},{"line_number":84,"context_line":"        cmd \u003d [cmd] # make it iterable"},{"line_number":85,"context_line":"    "},{"line_number":86,"context_line":"    #Note(salvatore-orlando): the shell argument has been set to False"},{"line_number":87,"context_line":"    proc \u003d subprocess.Popen(cmd, shell\u003dFalse, stdin\u003dpipe, stdout\u003dpipe,"},{"line_number":88,"context_line":"            stderr\u003dpipe, close_fds\u003dTrue)"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAADH%2F%2F%2F20%3D","line":85,"updated":"2011-12-28 20:29:08.000000000","message":"Please remove any whitespace like this. I see 5 places in this file.","commit_id":"640428aa5042e931dfb499ef26481e8bc1f9ec46"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"41dd37fc2c81f2f32d81cfee7e15488ea6b0a004","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    # or a sequence of string"},{"line_number":83,"context_line":"    if not hasattr(cmd,\u0027__iter__\u0027):"},{"line_number":84,"context_line":"        cmd \u003d [cmd] # make it iterable"},{"line_number":85,"context_line":"    "},{"line_number":86,"context_line":"    #Note(salvatore-orlando): the shell argument has been set to False"},{"line_number":87,"context_line":"    proc \u003d subprocess.Popen(cmd, shell\u003dFalse, stdin\u003dpipe, stdout\u003dpipe,"},{"line_number":88,"context_line":"            stderr\u003dpipe, close_fds\u003dTrue)"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAAD3%2F%2F%2Ffc%3D","line":85,"in_reply_to":"AAAADH%2F%2F%2F20%3D","updated":"2012-01-10 14:36:43.000000000","message":"Done","commit_id":"640428aa5042e931dfb499ef26481e8bc1f9ec46"}]}