)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"550624603f569157bce7c9ab9eaa78af76680ce2","unresolved":false,"context_lines":[{"line_number":13,"context_line":"the boot volume to the same slot on the IDE controller."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This fixes the bug by making sure that the ephemeral disk will always"},{"line_number":16,"context_line":"attach to the first slot."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Id6772b75683528db765241d21e25fba55358afb7"},{"line_number":19,"context_line":"Closes-Bug: 1479129"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a4dcd0f_aac24151","line":16,"updated":"2015-08-12 11:00:15.000000000","message":"second slot.","commit_id":"7344b509eba28f54514e12e9bfea73b123157ea7"}],"nova/virt/hyperv/vmops.py":[{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"550624603f569157bce7c9ab9eaa78af76680ce2","unresolved":false,"context_lines":[{"line_number":313,"context_line":"            self._attach_drive(instance_name, root_vhd_path, 0, ctrl_disk_addr,"},{"line_number":314,"context_line":"                               controller_type)"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"        ctrl_disk_addr \u003d 1"},{"line_number":317,"context_line":"        if eph_vhd_path:"},{"line_number":318,"context_line":"            self._attach_drive(instance_name, eph_vhd_path, 0, ctrl_disk_addr,"},{"line_number":319,"context_line":"                               controller_type)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_a7c27c51","line":316,"updated":"2015-08-12 11:00:15.000000000","message":"yeah, this is correct. volumeops will try to attach the volume to slot 0, if the vm is generation 1 and if it\u0027s \"boot from volume\". https://github.com/openstack/nova/blob/master/nova/virt/hyperv/volumeops.py#L245\n\nhaving the bootable volume on slot 0 will assure that it will try to boot from volume first, rather than try to boot from ephemeral first. so, having ephemeral as slot 1 is good.\n\nthough, this change doesn\u0027t affect gen2 vms, as the drives are attached at the 1st available slot found.","commit_id":"7344b509eba28f54514e12e9bfea73b123157ea7"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"550624603f569157bce7c9ab9eaa78af76680ce2","unresolved":false,"context_lines":[{"line_number":316,"context_line":"        ctrl_disk_addr \u003d 1"},{"line_number":317,"context_line":"        if eph_vhd_path:"},{"line_number":318,"context_line":"            self._attach_drive(instance_name, eph_vhd_path, 0, ctrl_disk_addr,"},{"line_number":319,"context_line":"                               controller_type)"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"        # If ebs_root is False, the first volume will be attached to SCSI"},{"line_number":322,"context_line":"        # controller. Generation 2 VMs only has a SCSI controller."}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_8ae4253c","line":319,"updated":"2015-08-12 11:00:15.000000000","message":"hm, for generation 2 vm, it seems that the ephemeral drive will still be attached to slot 0. That won\u0027t prevent the vm from booting, but it will try to boot from the ephemeral disk first, according to the current state of the code (unless we add a feature in the future related to changing the boot order of the vm). This is unrelated to this bug, but I think attaching the ephemerals should occur after the volumes have been attached.\n\n This should be a different bug report.","commit_id":"7344b509eba28f54514e12e9bfea73b123157ea7"}]}