)]}'
{"nova/tests/api/openstack/compute/contrib/test_flavors_extra_specs.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"48b45bba18d92a6f3d0a376bd5a5bd2b6af770f6","unresolved":false,"context_lines":[{"line_number":175,"context_line":"        self.assertEqual(text, expected)"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"    def test_deserializer(self):"},{"line_number":178,"context_line":"        deserializer \u003d wsgi.XMLDeserializer()"},{"line_number":179,"context_line":"        expected \u003d dict(extra_specs\u003d{\"key1\": \"value1\"})"},{"line_number":180,"context_line":"        intext \u003d (\"\u003c?xml version\u003d\u00271.0\u0027 encoding\u003d\u0027UTF-8\u0027?\u003e\\n\""},{"line_number":181,"context_line":"                  \u0027\u003cextra_specs\u003e\u003ckey1\u003evalue1\u003c/key1\u003e\u003c/extra_specs\u003e\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FTDY%3D","side":"PARENT","line":178,"updated":"2013-01-29 20:48:00.000000000","message":"With the removal of this line, you also need to remove the \"import wsgi\", which is no longer used in this file.","commit_id":"e8b76d1cd62cc4974741bd08ebef8216164cb8fe"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"5292b01fa9a7258f24a0e9bb59d20011a16e7eef","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from nova.api.openstack import wsgi"},{"line_number":22,"context_line":"from nova import test"},{"line_number":23,"context_line":"from nova.tests.api.openstack import fakes"},{"line_number":24,"context_line":"import nova.wsgi"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"def return_create_flavor_extra_specs(context, flavor_id, extra_specs):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FS4A%3D","side":"PARENT","line":24,"updated":"2013-01-29 22:39:52.000000000","message":"OK, certainly nova.wsgi is not presently used in this file (that this was not cited by the unused imports check might indicate a possible bug with that check).  However, that was not the import that was causing the failure; the \"import wsgi\" line from above was.","commit_id":"d87c4517cc667e42ac35e0ffff05ea40000b183b"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"cc7c0623f7c56774608e81551cfa6db6f9e16b60","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":16,"context_line":"#    under the License."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import nova.db"},{"line_number":19,"context_line":"import webob"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from nova.api.openstack.compute.contrib import flavorextraspecs"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAM3%2F%2FRj4%3D","line":18,"updated":"2013-01-30 18:00:35.000000000","message":"nova.db is not a third-party import.  It should be in with the rest of the nova imports.","commit_id":"8041da1eabf27ffc95bf9bb1ba5cdbf4f3166e14"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"98d7ded98560f88c214aef46770d69347e5da826","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":16,"context_line":"#    under the License."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import nova.db"},{"line_number":19,"context_line":"import webob"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from nova.api.openstack.compute.contrib import flavorextraspecs"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAM3%2F%2FRYE%3D","line":18,"in_reply_to":"AAAAM3%2F%2FRbQ%3D","updated":"2013-01-30 19:37:33.000000000","message":"Yes, That\u0027s what I\u0027m looking for :)\n\n(Tip for formatting multi-line in-line comments in Gerrit: if you indent the lines, Gerrit treats the text as preformatted and displays it as is, in a fixed-width font.)","commit_id":"8041da1eabf27ffc95bf9bb1ba5cdbf4f3166e14"},{"author":{"_account_id":4598,"name":"Giampaolo Lauria","email":"lauria@us.ibm.com","username":"lauria"},"change_message_id":"182374731a4dfb810001108adea79fbe882f7198","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":16,"context_line":"#    under the License."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import nova.db"},{"line_number":19,"context_line":"import webob"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from nova.api.openstack.compute.contrib import flavorextraspecs"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAM3%2F%2FRbQ%3D","line":18,"in_reply_to":"AAAAM3%2F%2FRj4%3D","updated":"2013-01-30 19:16:11.000000000","message":"Kevin,\n\nWould moving the import after\n\"from nova.api.openstack.compute.contrib import flavorextraspecs\"\nwork?\n\nIn other words:\nimport webob\n\nfrom nova.api.openstack.compute.contrib import flavorextraspecs\nimport nova.db\nfrom nova import test\nfrom nova.tests.api.openstack import fakes\n\nThanks","commit_id":"8041da1eabf27ffc95bf9bb1ba5cdbf4f3166e14"}]}