)]}'
{"nova/objects/image_meta.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"da68c39c25701279929fae75ba5009cc537626f9","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        \u0027size\u0027: fields.IntegerField(),"},{"line_number":51,"context_line":"        \u0027virtual_size\u0027: fields.IntegerField(),"},{"line_number":52,"context_line":"        \u0027container_format\u0027: fields.StringField(),"},{"line_number":53,"context_line":"        \u0027disk_format\u0027: fields.StringField(),"},{"line_number":54,"context_line":"        \u0027created_at\u0027: fields.DateTimeField(nullable\u003dTrue),"},{"line_number":55,"context_line":"        \u0027updated_at\u0027: fields.DateTimeField(nullable\u003dTrue),"},{"line_number":56,"context_line":"        \u0027tags\u0027: fields.ListOfStringsField(),"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_681efa60","line":53,"updated":"2015-07-31 03:03:49.000000000","message":"from the comment, it looks like more than checksum:\n\n\"Notably this can occur with disk_format, container_format, name, deleted, and checksum.\"","commit_id":"5f0dadd32cc41a7441d1b06540a9a2b80216ca88"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"6ba85d8bb14befbd7138be2844d6ea3bb6a544f9","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        \u0027size\u0027: fields.IntegerField(),"},{"line_number":51,"context_line":"        \u0027virtual_size\u0027: fields.IntegerField(),"},{"line_number":52,"context_line":"        \u0027container_format\u0027: fields.StringField(),"},{"line_number":53,"context_line":"        \u0027disk_format\u0027: fields.StringField(),"},{"line_number":54,"context_line":"        \u0027created_at\u0027: fields.DateTimeField(nullable\u003dTrue),"},{"line_number":55,"context_line":"        \u0027updated_at\u0027: fields.DateTimeField(nullable\u003dTrue),"},{"line_number":56,"context_line":"        \u0027tags\u0027: fields.ListOfStringsField(),"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_28dc7273","line":53,"in_reply_to":"3a50d1a3_681efa60","updated":"2015-07-31 03:18:25.000000000","message":"We\u0027ll have to talk to the cinder folks. Just trying to get heat folks unblocked in this review since we broke them","commit_id":"5f0dadd32cc41a7441d1b06540a9a2b80216ca88"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"186ee0e4dc282669e5e2246398a0ca9c0710f029","unresolved":false,"context_lines":[{"line_number":65,"context_line":"                       (\u00271.1\u0027, \u00271.1\u0027),"},{"line_number":66,"context_line":"                       (\u00271.2\u0027, \u00271.2\u0027),"},{"line_number":67,"context_line":"                       (\u00271.3\u0027, \u00271.3\u0027),"},{"line_number":68,"context_line":"                       (\u00271.4\u0027, \u00271.4\u0027),"},{"line_number":69,"context_line":"                       ],"},{"line_number":70,"context_line":"    }"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_eda8dc22","line":68,"updated":"2015-07-31 02:54:02.000000000","message":"This should be (1.4, 1.3)","commit_id":"5f0dadd32cc41a7441d1b06540a9a2b80216ca88"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"6ba85d8bb14befbd7138be2844d6ea3bb6a544f9","unresolved":false,"context_lines":[{"line_number":65,"context_line":"                       (\u00271.1\u0027, \u00271.1\u0027),"},{"line_number":66,"context_line":"                       (\u00271.2\u0027, \u00271.2\u0027),"},{"line_number":67,"context_line":"                       (\u00271.3\u0027, \u00271.3\u0027),"},{"line_number":68,"context_line":"                       (\u00271.4\u0027, \u00271.4\u0027),"},{"line_number":69,"context_line":"                       ],"},{"line_number":70,"context_line":"    }"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_28c3128c","line":68,"in_reply_to":"3a50d1a3_eda8dc22","updated":"2015-07-31 03:18:25.000000000","message":"Done","commit_id":"5f0dadd32cc41a7441d1b06540a9a2b80216ca88"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"b326cc3e55c89f3cc00a7bdfff47f61588b4be0d","unresolved":false,"context_lines":[{"line_number":114,"context_line":"    # Version 1.0: Initial version"},{"line_number":115,"context_line":"    # Version 1.1: added os_require_quiesce field"},{"line_number":116,"context_line":"    # Version 1.2: added img_hv_type and img_hv_requested_version fields"},{"line_number":117,"context_line":"    # Version 1.3: HVSpec version 1.1"},{"line_number":118,"context_line":"    VERSION \u003d ImageMeta.VERSION"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    # Maximum number of NUMA nodes permitted for the guest topology"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_885a6629","line":117,"updated":"2015-07-31 03:05:29.000000000","message":"We should change this to \u00271.3\u0027. We needn\u0027t bump this version.","commit_id":"5f0dadd32cc41a7441d1b06540a9a2b80216ca88"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"5a0290d2e311a0fb9f2d3519f91ac65baa84b455","unresolved":false,"context_lines":[{"line_number":114,"context_line":"    # Version 1.0: Initial version"},{"line_number":115,"context_line":"    # Version 1.1: added os_require_quiesce field"},{"line_number":116,"context_line":"    # Version 1.2: added img_hv_type and img_hv_requested_version fields"},{"line_number":117,"context_line":"    # Version 1.3: HVSpec version 1.1"},{"line_number":118,"context_line":"    VERSION \u003d ImageMeta.VERSION"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    # Maximum number of NUMA nodes permitted for the guest topology"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_e818ca20","line":117,"in_reply_to":"3a50d1a3_8844a61b","updated":"2015-07-31 03:21:30.000000000","message":"on 118, I\u0027m not sure this is gerrit bug or webbrower bug... I definitely comment on line 118 :(","commit_id":"5f0dadd32cc41a7441d1b06540a9a2b80216ca88"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"6ba85d8bb14befbd7138be2844d6ea3bb6a544f9","unresolved":false,"context_lines":[{"line_number":114,"context_line":"    # Version 1.0: Initial version"},{"line_number":115,"context_line":"    # Version 1.1: added os_require_quiesce field"},{"line_number":116,"context_line":"    # Version 1.2: added img_hv_type and img_hv_requested_version fields"},{"line_number":117,"context_line":"    # Version 1.3: HVSpec version 1.1"},{"line_number":118,"context_line":"    VERSION \u003d ImageMeta.VERSION"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    # Maximum number of NUMA nodes permitted for the guest topology"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_8844a61b","line":117,"in_reply_to":"3a50d1a3_885a6629","updated":"2015-07-31 03:18:25.000000000","message":"on line 117?","commit_id":"5f0dadd32cc41a7441d1b06540a9a2b80216ca88"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"defe2860363dbb0b4c004d4976ead6e65ef11e00","unresolved":false,"context_lines":[{"line_number":114,"context_line":"    # Version 1.0: Initial version"},{"line_number":115,"context_line":"    # Version 1.1: added os_require_quiesce field"},{"line_number":116,"context_line":"    # Version 1.2: added img_hv_type and img_hv_requested_version fields"},{"line_number":117,"context_line":"    # Version 1.3: HVSpec version 1.1"},{"line_number":118,"context_line":"    VERSION \u003d ImageMeta.VERSION"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    # Maximum number of NUMA nodes permitted for the guest topology"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_c8bdced8","line":117,"updated":"2015-07-31 03:22:39.000000000","message":"We should change this, otherwise ImageMeta and ImageMetaProps will bump together.","commit_id":"05064a27f3e63dca301ad51850ec3a3facc3d1f2"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"e09e4462668a87448cf31d841c275a4ff0a7f98f","unresolved":false,"context_lines":[{"line_number":114,"context_line":"    # Version 1.0: Initial version"},{"line_number":115,"context_line":"    # Version 1.1: added os_require_quiesce field"},{"line_number":116,"context_line":"    # Version 1.2: added img_hv_type and img_hv_requested_version fields"},{"line_number":117,"context_line":"    # Version 1.3: HVSpec version 1.1"},{"line_number":118,"context_line":"    VERSION \u003d ImageMeta.VERSION"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    # Maximum number of NUMA nodes permitted for the guest topology"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_48f45e86","line":117,"in_reply_to":"3a50d1a3_28a2329b","updated":"2015-07-31 03:32:32.000000000","message":"ah right.","commit_id":"05064a27f3e63dca301ad51850ec3a3facc3d1f2"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"9dc4315d670b9c96ea60a5fc5905ef24d2fe3185","unresolved":false,"context_lines":[{"line_number":114,"context_line":"    # Version 1.0: Initial version"},{"line_number":115,"context_line":"    # Version 1.1: added os_require_quiesce field"},{"line_number":116,"context_line":"    # Version 1.2: added img_hv_type and img_hv_requested_version fields"},{"line_number":117,"context_line":"    # Version 1.3: HVSpec version 1.1"},{"line_number":118,"context_line":"    VERSION \u003d ImageMeta.VERSION"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    # Maximum number of NUMA nodes permitted for the guest topology"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_28a2329b","line":117,"in_reply_to":"3a50d1a3_c8bdced8","updated":"2015-07-31 03:28:33.000000000","message":"emm.... it comment on 117 again. This should be 118","commit_id":"05064a27f3e63dca301ad51850ec3a3facc3d1f2"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"9f42b2a39f55123516ef46f4c13494496bf79282","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    # Version 1.2: ImageMetaProps version 1.2"},{"line_number":29,"context_line":"    # Version 1.3: ImageMetaProps version 1.3"},{"line_number":30,"context_line":"    # Version 1.4: checksum is nullable 1.3"},{"line_number":31,"context_line":"    VERSION \u003d \u00271.4\u0027"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    # These are driven by what the image client API returns"},{"line_number":34,"context_line":"    # to Nova from Glance. This is defined in the glance"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_499d39ba","line":31,"updated":"2015-07-31 08:58:49.000000000","message":"I guess you might need update this https://github.com/openstack/nova/blob/master/nova/tests/unit/objects/test_objects.py#L1111","commit_id":"d696bac235812036a18e6355d9d96d726f78514c"}]}