)]}'
{"nova/db/sqlalchemy/migrate_repo/versions/299_pgsql_add_instance_system_metadata_index.py":[{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"edf2dccd6aa283ee55c16127ea5683c3c734be92","unresolved":false,"context_lines":[{"line_number":25,"context_line":"INDEX_NAME \u003d \u0027instance_system_metadata_instance_uuid_idx\u0027"},{"line_number":26,"context_line":"SYS_META_TABLE_NAME \u003d \u0027instance_system_metadata\u0027"},{"line_number":27,"context_line":"INSTANCE_TABLE_NAME \u003d \u0027instances\u0027"},{"line_number":28,"context_line":"FOREIGN_KEY_NAME \u003d \u0027instance_system_metadata_ibfk_1\u0027"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"def upgrade(migrate_engine):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_18f96b80","line":28,"updated":"2015-08-03 10:01:33.000000000","message":"This name may differ depending on the MySQL version the schema was originally created on.\n\nGiven the fact that we actually reflect the actual information on the DB schema from the RDBMS at runtime, can we use the constraint name returned by SQLAlchemy? (as we know the table name and columns involved)","commit_id":"7b10cae39cf355394ef02a2d3098b7c967f316b4"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"edf2dccd6aa283ee55c16127ea5683c3c734be92","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    # the missing indexes in PostgreSQL and SQLite have conflicting names"},{"line_number":39,"context_line":"    # that MySQL allowed."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    if migrate_engine.name in (\u0027sqlite\u0027, \u0027postgresql\u0027, \u0027ibm_db_sa\u0027):"},{"line_number":42,"context_line":"        if not utils.index_exists(migrate_engine, SYS_META_TABLE_NAME,"},{"line_number":43,"context_line":"                                  INDEX_NAME):"},{"line_number":44,"context_line":"            utils.add_index(migrate_engine, SYS_META_TABLE_NAME, INDEX_NAME,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_38c8e754","line":41,"updated":"2015-08-03 10:01:33.000000000","message":"why not make this:\n\n  if migrate_engine.name !\u003d \u0027mysql\u0027\n\n?","commit_id":"7b10cae39cf355394ef02a2d3098b7c967f316b4"},{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"4cfd5cc48bb71a637ee6a2be3f8dd3c0d28db05b","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    \"\"\"Add instance_system_metadata indexes missing on PostgreSQL and other DB."},{"line_number":28,"context_line":"    \"\"\""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    if migrate_engine.name !\u003d \u0027mysql\u0027:"},{"line_number":31,"context_line":"        # Adds index for PostgreSQL and other DB"},{"line_number":32,"context_line":"        if not utils.index_exists(migrate_engine, SYS_META_TABLE_NAME,"},{"line_number":33,"context_line":"                                  INDEX_NAME):"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a4dcd0f_d36c9c0a","line":30,"updated":"2015-08-10 13:33:37.000000000","message":"Please could you add a comment like \"this index was already added by migration NNN for MySQL\"?","commit_id":"1fb5b69c216fb1a8f4ad42b2a96dc30dee416465"}],"nova/db/sqlalchemy/migrate_repo/versions/302_pgsql_add_instance_system_metadata_index.py":[{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"46fec35c11c2fe256a4b315282ad908b1cf4448b","unresolved":false,"context_lines":[{"line_number":20,"context_line":"INDEX_COLUMNS \u003d [\u0027instance_uuid\u0027]"},{"line_number":21,"context_line":"# using the index name same with mysql"},{"line_number":22,"context_line":"INDEX_NAME \u003d \u0027instance_uuid\u0027"},{"line_number":23,"context_line":"SYS_META_TABLE_NAME \u003d \u0027instance_system_metadata\u0027"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"def upgrade(migrate_engine):"}],"source_content_type":"text/x-python","patch_set":12,"id":"da20952f_dd7ec069","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":19},"updated":"2015-09-03 05:01:33.000000000","message":"I\u0027m not sure I understand the value of the constants here. Why aren\u0027t these just in the code below?","commit_id":"715e295bae3a0fba3bef7f1d4cebf331103ebe04"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"46fec35c11c2fe256a4b315282ad908b1cf4448b","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    \"\"\"Add instance_system_metadata indexes missing on PostgreSQL and other DB."},{"line_number":28,"context_line":"    \"\"\""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    # This index was already added by migration 216 for MySQL"},{"line_number":31,"context_line":"    if migrate_engine.name !\u003d \u0027mysql\u0027:"},{"line_number":32,"context_line":"        # Adds index for PostgreSQL and other DB"},{"line_number":33,"context_line":"        if not utils.index_exists(migrate_engine, SYS_META_TABLE_NAME,"}],"source_content_type":"text/x-python","patch_set":12,"id":"da20952f_5d8b9068","line":30,"updated":"2015-09-03 05:01:33.000000000","message":"I really like this comment, thanks for doing the digging.","commit_id":"715e295bae3a0fba3bef7f1d4cebf331103ebe04"}],"nova/tests/unit/db/test_migrations.py":[{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"46fec35c11c2fe256a4b315282ad908b1cf4448b","unresolved":false,"context_lines":[{"line_number":803,"context_line":"    def _check_302(self, engine, data):"},{"line_number":804,"context_line":"        self.assertIndexMembers(engine, \u0027instance_system_metadata\u0027,"},{"line_number":805,"context_line":"                                \u0027instance_uuid\u0027,"},{"line_number":806,"context_line":"                                [\u0027instance_uuid\u0027])"},{"line_number":807,"context_line":""},{"line_number":808,"context_line":""},{"line_number":809,"context_line":"class TestNovaMigrationsSQLite(NovaMigrationsCheckers,"}],"source_content_type":"text/x-python","patch_set":12,"id":"da20952f_3de7bc41","line":806,"updated":"2015-09-03 05:01:33.000000000","message":"The line breaking is strange here, why the extra newline in the middle of the last two lines? Its a nit though.","commit_id":"715e295bae3a0fba3bef7f1d4cebf331103ebe04"}]}