)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"90a8848c22c8474f59dd1775d2dedcc5537d4399","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Replace \"all_mappings\" variable by \"block_device_mappings\""},{"line_number":10,"context_line":" to let reader more easy to read, for the variable refer it"},{"line_number":11,"context_line":" is lock_device_mapping."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ic47a2478f23c74374567d7561b532a727bde9e75"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"da20952f_58a5909f","line":11,"updated":"2015-08-31 02:11:02.000000000","message":"so is this typo : \u0027lock_device_mapping\u0027 ?","commit_id":"9d43ba33d97074186f30d584d9f4f8fdf8133fd7"}],"nova/compute/api.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"64a3adc8c33adae182a51796aec324b8c7a694e5","unresolved":false,"context_lines":[{"line_number":1224,"context_line":"        if 0 not in boot_indexes or not _subsequent_list(boot_indexes):"},{"line_number":1225,"context_line":"            raise exception.InvalidBDMBootSequence()"},{"line_number":1226,"context_line":""},{"line_number":1227,"context_line":"        for bdm in block_device_mapping:"},{"line_number":1228,"context_line":"            # NOTE(vish): For now, just make sure the volumes are accessible."},{"line_number":1229,"context_line":"            # Additionally, check that the volume can be attached to this"},{"line_number":1230,"context_line":"            # instance."}],"source_content_type":"text/x-python","patch_set":5,"id":"fa1b9901_7492acf7","line":1227,"updated":"2015-08-21 07:12:12.000000000","message":"I think bdm means \"block device mapping\", and the renamed value should be multiple.\n\nSo this change makes the code unreadable. At least, the value should be block_device_mappings.\nbut I don\u0027t think the original value name is so bad..","commit_id":"d476cebaa1d9c86a71c3bd2c6cf1de60078682ea"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"f6ba92b606fcb3358f90993eb02f19f9243e3f63","unresolved":false,"context_lines":[{"line_number":1274,"context_line":"            bdm.update_or_create()"},{"line_number":1275,"context_line":""},{"line_number":1276,"context_line":"    def _validate_bdm(self, context, instance, instance_type,"},{"line_number":1277,"context_line":"                                        block_device_mapping):"},{"line_number":1278,"context_line":"        def _subsequent_list(l):"},{"line_number":1279,"context_line":"            return all(el + 1 \u003d\u003d l[i + 1] for i, el in enumerate(l[:-1]))"},{"line_number":1280,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"da20952f_ee894727","line":1277,"updated":"2015-08-30 05:18:50.000000000","message":"block_device_mapping \u003d\u003e block_device_mappings (as this is a plural and the same for all below)\n\nin addition to this the indentation is a but odd","commit_id":"9940fd2afb191659b9a288a4eac307e4d19146f0"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"2bf81fd83caef22f0b82127f4243d26c0ba4e8b7","unresolved":false,"context_lines":[{"line_number":1274,"context_line":"            bdm.update_or_create()"},{"line_number":1275,"context_line":""},{"line_number":1276,"context_line":"    def _validate_bdm(self, context, instance, instance_type,"},{"line_number":1277,"context_line":"                                        block_device_mappings):"},{"line_number":1278,"context_line":"        def _subsequent_list(l):"},{"line_number":1279,"context_line":"            return all(el + 1 \u003d\u003d l[i + 1] for i, el in enumerate(l[:-1]))"},{"line_number":1280,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"da20952f_821baec9","line":1277,"updated":"2015-08-31 07:34:00.000000000","message":"alignment here is dodgy","commit_id":"ce204dd8c521494f5526b88b79315e12b3ab55dc"}],"nova/tests/unit/compute/test_compute.py":[{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"beab0e42f1b93a1fccc9bcc31b848e5e157be676","unresolved":false,"context_lines":[{"line_number":1066,"context_line":"                         \u0027device_name\u0027: \u0027vda\u0027,"},{"line_number":1067,"context_line":"                         \u0027boot_index\u0027: 0,"},{"line_number":1068,"context_line":"                         \u0027delete_on_termination\u0027: False}, anon\u003dTrue)]"},{"line_number":1069,"context_line":"        block_device_mapping \u003d block_device_obj."},{"line_number":1070,"context_line":"                               block_device_make_list_from_dicts("},{"line_number":1071,"context_line":"                               self.context, block_device_mapping)"},{"line_number":1072,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_66a04491","line":1069,"updated":"2015-08-05 03:58:41.000000000","message":"you shouldn\u0027t separate this dot(.) and its function, thats why you got all those errors","commit_id":"1c26f2b327c280c5644617a5ada8778a3e7ef364"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"51d590a960f300689593914f3a2ab07991893627","unresolved":false,"context_lines":[{"line_number":1066,"context_line":"                         \u0027device_name\u0027: \u0027vda\u0027,"},{"line_number":1067,"context_line":"                         \u0027boot_index\u0027: 0,"},{"line_number":1068,"context_line":"                         \u0027delete_on_termination\u0027: False}, anon\u003dTrue)]"},{"line_number":1069,"context_line":"        block_device_mapping \u003d \\ "},{"line_number":1070,"context_line":"           block_device_obj.block_device_make_list_from_dicts("},{"line_number":1071,"context_line":"                       self.context, block_device_mapping)"},{"line_number":1072,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_4bc4f68f","line":1069,"updated":"2015-08-06 01:52:00.000000000","message":"delete the whitespace here","commit_id":"dc86c12df9c382e4ae827cb023b1ea2494019c4a"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"51d590a960f300689593914f3a2ab07991893627","unresolved":false,"context_lines":[{"line_number":1067,"context_line":"                         \u0027boot_index\u0027: 0,"},{"line_number":1068,"context_line":"                         \u0027delete_on_termination\u0027: False}, anon\u003dTrue)]"},{"line_number":1069,"context_line":"        block_device_mapping \u003d \\ "},{"line_number":1070,"context_line":"           block_device_obj.block_device_make_list_from_dicts("},{"line_number":1071,"context_line":"                       self.context, block_device_mapping)"},{"line_number":1072,"context_line":""},{"line_number":1073,"context_line":"        # First we test a list of invalid status values that should result"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_2b4e4a3b","line":1070,"updated":"2015-08-06 01:52:00.000000000","message":"one more whitespace here to get an indent of 8","commit_id":"dc86c12df9c382e4ae827cb023b1ea2494019c4a"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"f6ba92b606fcb3358f90993eb02f19f9243e3f63","unresolved":false,"context_lines":[{"line_number":1065,"context_line":"                         \u0027device_name\u0027: \u0027vda\u0027,"},{"line_number":1066,"context_line":"                         \u0027boot_index\u0027: 0,"},{"line_number":1067,"context_line":"                         \u0027delete_on_termination\u0027: False}, anon\u003dTrue)]"},{"line_number":1068,"context_line":"        block_device_mapping \u003d \\"},{"line_number":1069,"context_line":"                block_device_obj.block_device_make_list_from_dicts("},{"line_number":1070,"context_line":"                self.context, block_device_mapping)"},{"line_number":1071,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"da20952f_ae7fcf15","line":1068,"updated":"2015-08-30 05:18:50.000000000","message":"can you please write this without the \\. you could use bdms instead","commit_id":"9940fd2afb191659b9a288a4eac307e4d19146f0"}]}