)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"e62d966cd512c57f025939e0cfc56ef47a53e9d1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Vikas Choudhary \u003cchoudharyvikas16@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-08-05 04:53:36 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update hypervisor resources correctly in booting failed case"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As a periodic activity , available resources for compute node are updated using instances db to maintain a collective view of"},{"line_number":10,"context_line":"available resources at hypervisor level.\u0027nova hypervisor-stats\u0027 is expected to show this view of resources.Currently resources are"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1a4dcd0f_86a0f044","line":7,"updated":"2015-08-05 04:13:27.000000000","message":"The first line should be limited to 50 characters. see https://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure","commit_id":"fb411f7f4f29213fc6e1547a7a48187fe9686955"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"e62d966cd512c57f025939e0cfc56ef47a53e9d1","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update hypervisor resources correctly in booting failed case"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As a periodic activity , available resources for compute node are updated using instances db to maintain a collective view of"},{"line_number":10,"context_line":"available resources at hypervisor level.\u0027nova hypervisor-stats\u0027 is expected to show this view of resources.Currently resources are"},{"line_number":11,"context_line":"updated from all instances available in db except the ones that have vm_state as \u0027deleted\u0027.In booting failed case , resources are"},{"line_number":12,"context_line":"released and process is aborted but soon after this when periodic updation of available resources for the corresponding compute"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1a4dcd0f_a6bacc6c","line":9,"updated":"2015-08-05 04:13:27.000000000","message":"commit messages over 72 characters will be rejected by the gate. see https://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure","commit_id":"fb411f7f4f29213fc6e1547a7a48187fe9686955"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"e62d966cd512c57f025939e0cfc56ef47a53e9d1","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As a periodic activity , available resources for compute node are updated using instances db to maintain a collective view of"},{"line_number":10,"context_line":"available resources at hypervisor level.\u0027nova hypervisor-stats\u0027 is expected to show this view of resources.Currently resources are"},{"line_number":11,"context_line":"updated from all instances available in db except the ones that have vm_state as \u0027deleted\u0027.In booting failed case , resources are"},{"line_number":12,"context_line":"released and process is aborted but soon after this when periodic updation of available resources for the corresponding compute"},{"line_number":13,"context_line":"happens , again already released resouces for errored VM gets considered.To fix this long with deleted,VMs in error state should"},{"line_number":14,"context_line":"also be skipped."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1a4dcd0f_66ada430","line":11,"updated":"2015-08-05 04:13:27.000000000","message":"also some extra blank space before \",\".","commit_id":"fb411f7f4f29213fc6e1547a7a48187fe9686955"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"e62d966cd512c57f025939e0cfc56ef47a53e9d1","unresolved":false,"context_lines":[{"line_number":10,"context_line":"available resources at hypervisor level.\u0027nova hypervisor-stats\u0027 is expected to show this view of resources.Currently resources are"},{"line_number":11,"context_line":"updated from all instances available in db except the ones that have vm_state as \u0027deleted\u0027.In booting failed case , resources are"},{"line_number":12,"context_line":"released and process is aborted but soon after this when periodic updation of available resources for the corresponding compute"},{"line_number":13,"context_line":"happens , again already released resouces for errored VM gets considered.To fix this long with deleted,VMs in error state should"},{"line_number":14,"context_line":"also be skipped."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I9b51596bc11dbb32b2ca561d7dfc280f7f5277e5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1a4dcd0f_c664b823","line":13,"updated":"2015-08-05 04:13:27.000000000","message":"or missing blank space after \".\".","commit_id":"fb411f7f4f29213fc6e1547a7a48187fe9686955"}],"nova/compute/resource_tracker.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"ef40d76ab92de7d1f3cf340b134f1e9911895bea","unresolved":false,"context_lines":[{"line_number":786,"context_line":"                                                   self.driver)"},{"line_number":787,"context_line":""},{"line_number":788,"context_line":"        for instance in instances:"},{"line_number":789,"context_line":"            if instance.vm_state not in (vm_states.DELETED, vm_states.ERROR):"},{"line_number":790,"context_line":"                self._update_usage_from_instance(context, instance)"},{"line_number":791,"context_line":""},{"line_number":792,"context_line":"    def _find_orphaned_instances(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a4dcd0f_16040948","line":789,"updated":"2015-08-05 06:50:37.000000000","message":"I don\u0027t think this is right fix. As have may case can make the instance to Error state. But that isn\u0027t mean the instance resource already release on the host.\n\nFor example, reboot instance may lead to instance to be errror state, but resource didn\u0027t release. https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L2837","commit_id":"c77390dc99f2ee3e2021662e02405d4623cd7728"},{"author":{"_account_id":15967,"name":"vikas choudhary","email":"choudharyvikas16@gmail.com","username":"vikaschoudhary16"},"change_message_id":"d97105c8c14faef7c4679bb18d583fb2405e668a","unresolved":false,"context_lines":[{"line_number":786,"context_line":"                                                   self.driver)"},{"line_number":787,"context_line":""},{"line_number":788,"context_line":"        for instance in instances:"},{"line_number":789,"context_line":"            if instance.vm_state not in (vm_states.DELETED, vm_states.ERROR):"},{"line_number":790,"context_line":"                self._update_usage_from_instance(context, instance)"},{"line_number":791,"context_line":""},{"line_number":792,"context_line":"    def _find_orphaned_instances(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a4dcd0f_8fa31c4f","line":789,"in_reply_to":"1a4dcd0f_16040948","updated":"2015-08-05 08:03:46.000000000","message":"Thanks Alex for pointing out.That makes sense.I will come back on that soon.","commit_id":"c77390dc99f2ee3e2021662e02405d4623cd7728"}]}