)]}'
{"nova/api/openstack/compute/console_auth_tokens.py":[{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"9443dee70fedabb1b6485c6f3e5f6d6c22c00360","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        console_type \u003d connect_info.get(\u0027console_type\u0027)"},{"line_number":48,"context_line":"        # This is currently required only for RDP and MKS consoles"},{"line_number":49,"context_line":"        if console_type not in (\"rdp-html5\", \"webmks\"):"},{"line_number":50,"context_line":"            raise webob.exc.HTTPUnauthorized("},{"line_number":51,"context_line":"                explanation\u003d_(\"The requested console type details are not \""},{"line_number":52,"context_line":"                              \"accessible\"))"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa1b9901_a09e9e05","line":49,"updated":"2015-08-17 11:22:30.000000000","message":"Unfortunately the comment doesn\u0027t explain WHY the other console types (VNC, SPICE, SERIAL) aren\u0027t available via this API. Maybe this is a wider issue, would be great if you could dig deeper here.","commit_id":"c2660efe5ffbecbe772613d1ee0f5a7c6afd0c87"},{"author":{"_account_id":3185,"name":"Alessandro Pilotti","email":"apilotti@cloudbasesolutions.com","username":"alexpilotti"},"change_message_id":"d44baefb31627fd922b16b01075717aac6a48d11","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        console_type \u003d connect_info.get(\u0027console_type\u0027)"},{"line_number":48,"context_line":"        # This is currently required only for RDP and MKS consoles"},{"line_number":49,"context_line":"        if console_type not in (\"rdp-html5\", \"webmks\"):"},{"line_number":50,"context_line":"            raise webob.exc.HTTPUnauthorized("},{"line_number":51,"context_line":"                explanation\u003d_(\"The requested console type details are not \""},{"line_number":52,"context_line":"                              \"accessible\"))"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_6209b72c","line":49,"in_reply_to":"fa1b9901_a09e9e05","updated":"2016-08-08 22:40:06.000000000","message":"Author of the original os-console-auth-tokens BP here, sorry for the very late comment, I just found out about this patch:\n\nWhen the os-console-auth-tokens patch was being reviewed, the reviewers asked to add this check to limit the API usage to RDP, the reason being provided was to avoid \"unsupported\" usage, so unfortunately it\u0027s still there. I\u0027d definitely support removing the check.","commit_id":"c2660efe5ffbecbe772613d1ee0f5a7c6afd0c87"}],"nova/api/openstack/compute/plugins/v3/console_auth_tokens.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"2680792ea10df35fcaa9dbc9d398e7ecde941695","unresolved":false,"context_lines":[{"line_number":45,"context_line":"            raise webob.exc.HTTPNotFound(explanation\u003d_(\"Token not found\"))"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        console_type \u003d connect_info.get(\u0027console_type\u0027)"},{"line_number":48,"context_line":"        # This is currently required only for RDP consoles"},{"line_number":49,"context_line":"        if console_type not in (\"rdp-html5\", \"webmks\"):"},{"line_number":50,"context_line":"            raise webob.exc.HTTPUnauthorized("},{"line_number":51,"context_line":"                explanation\u003d_(\"The requested console type details are not \""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_cb606f38","line":48,"updated":"2015-08-04 11:44:58.000000000","message":"can you please update the comment","commit_id":"3514498fab14e0c0ab14a328f00f0cf999a1562f"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"6a2c43750fa593a7ddb919d28ace462e9d628653","unresolved":false,"context_lines":[{"line_number":45,"context_line":"            raise webob.exc.HTTPNotFound(explanation\u003d_(\"Token not found\"))"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        console_type \u003d connect_info.get(\u0027console_type\u0027)"},{"line_number":48,"context_line":"        # This is currently required only for RDP consoles"},{"line_number":49,"context_line":"        if console_type not in (\"rdp-html5\", \"webmks\"):"},{"line_number":50,"context_line":"            raise webob.exc.HTTPUnauthorized("},{"line_number":51,"context_line":"                explanation\u003d_(\"The requested console type details are not \""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_6baefb2f","line":48,"in_reply_to":"1a4dcd0f_cb606f38","updated":"2015-08-04 11:47:43.000000000","message":"Done","commit_id":"3514498fab14e0c0ab14a328f00f0cf999a1562f"},{"author":{"_account_id":16929,"name":"Giridhar Jayavelu","email":"gjayavelu@vmware.com","username":"gjayavelu"},"change_message_id":"4239ab06334b79d634d0e6f58dbbfd96210bc44a","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        console_type \u003d connect_info.get(\u0027console_type\u0027)"},{"line_number":48,"context_line":"        # This is currently required only for RDP consoles"},{"line_number":49,"context_line":"        if console_type !\u003d \"rdp-html5\":"},{"line_number":50,"context_line":"            raise webob.exc.HTTPUnauthorized("},{"line_number":51,"context_line":"                explanation\u003d_(\"The requested console type details are not \""},{"line_number":52,"context_line":"                              \"accessible\"))"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_623039e9","side":"PARENT","line":49,"updated":"2015-08-04 22:13:17.000000000","message":"nit: would be nice to keep these different console types as constants.","commit_id":"4a96b90623ffd3814131b37c622e75e4dae812fa"}]}