)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"aa318da6153d86dcbbd183e8f0b07105e3e91e94","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Clean MAC addresses for direct ports on unplug"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, in sriov setup VFs doesn\u0027t get cleaned up after"},{"line_number":10,"context_line":"port deletion. Specifically, MAC and VLAN configuration that"},{"line_number":11,"context_line":"was previously assigned stays untouched and gets changed"},{"line_number":12,"context_line":"only next time when this device will be allocated."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a4dcd0f_f241890c","line":9,"updated":"2015-08-04 16:10:59.000000000","message":"Can you please add more details about the change you do? The current commit message is more about the reason for the change and not the change itself.","commit_id":"ce1672cf041141764da4513accc7c17a9a4e158c"},{"author":{"_account_id":6509,"name":"Roman Bogorodskiy","email":"rbogorodskiy@mirantis.com","username":"novel"},"change_message_id":"ce80d65b09506b1069ea62e0ef9b321e637fc05f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Clean MAC addresses for direct ports on unplug"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, in sriov setup VFs doesn\u0027t get cleaned up after"},{"line_number":10,"context_line":"port deletion. Specifically, MAC and VLAN configuration that"},{"line_number":11,"context_line":"was previously assigned stays untouched and gets changed"},{"line_number":12,"context_line":"only next time when this device will be allocated."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a4dcd0f_3174b4fb","line":9,"in_reply_to":"1a4dcd0f_f241890c","updated":"2015-08-05 04:52:53.000000000","message":"Done","commit_id":"ce1672cf041141764da4513accc7c17a9a4e158c"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"aa318da6153d86dcbbd183e8f0b07105e3e91e94","unresolved":false,"context_lines":[{"line_number":14,"context_line":"This could lead to unexpected results, for example, user could"},{"line_number":15,"context_line":"create a port with MAC address of some deleted port, but as"},{"line_number":16,"context_line":"the VF of that specific deleted port wasn\u0027t cleaned up, user"},{"line_number":17,"context_line":"could end up with two VFs with the same MAC address for example."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Closes-Bug: #1475256"},{"line_number":20,"context_line":"Change-Id: Ibdc013bbfc5a4cea62698fe686894de1b2b5e6a3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a4dcd0f_1280b545","line":17,"updated":"2015-08-04 16:10:59.000000000","message":"If that device will be set to down, won\u0027t this solve the problem?","commit_id":"ce1672cf041141764da4513accc7c17a9a4e158c"},{"author":{"_account_id":6509,"name":"Roman Bogorodskiy","email":"rbogorodskiy@mirantis.com","username":"novel"},"change_message_id":"ce80d65b09506b1069ea62e0ef9b321e637fc05f","unresolved":false,"context_lines":[{"line_number":14,"context_line":"This could lead to unexpected results, for example, user could"},{"line_number":15,"context_line":"create a port with MAC address of some deleted port, but as"},{"line_number":16,"context_line":"the VF of that specific deleted port wasn\u0027t cleaned up, user"},{"line_number":17,"context_line":"could end up with two VFs with the same MAC address for example."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Closes-Bug: #1475256"},{"line_number":20,"context_line":"Change-Id: Ibdc013bbfc5a4cea62698fe686894de1b2b5e6a3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a4dcd0f_d119d089","line":17,"in_reply_to":"1a4dcd0f_1280b545","updated":"2015-08-05 04:52:53.000000000","message":"I guess it would not, because as we\u0027ve discussed in https://review.openstack.org/#/c/195060/, for some drivers state setting is not supported, for ixgbe specifically.\n\nBy the way, I\u0027m wondering why linux_net.set_vf_interface_vlan prefers to try to set state on the actual host device (i.e. ip link set $dev up/down) instead of the VF device (ip link set $pf vf $vf state enable/disable).","commit_id":"ce1672cf041141764da4513accc7c17a9a4e158c"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"0ce3c3c6738dbcd8a9c93ac92581a20f231b197e","unresolved":false,"context_lines":[{"line_number":14,"context_line":"This could lead to unexpected results, for example, user could"},{"line_number":15,"context_line":"create a port with MAC address of some deleted port, but as"},{"line_number":16,"context_line":"the VF of that specific deleted port wasn\u0027t cleaned up, user"},{"line_number":17,"context_line":"could end up with two VFs with the same MAC address for example."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Closes-Bug: #1475256"},{"line_number":20,"context_line":"Change-Id: Ibdc013bbfc5a4cea62698fe686894de1b2b5e6a3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a4dcd0f_61001702","line":17,"in_reply_to":"1a4dcd0f_d119d089","updated":"2015-08-05 12:30:04.000000000","message":"If I remember correctly, it is due to the same reason you mention. Not every driver supports VF state settings, so host device (corresponding to the VF) will be moved to down instead.","commit_id":"ce1672cf041141764da4513accc7c17a9a4e158c"}]}