)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ee432e06c4ecad575a994493171eb3cd85155f28","unresolved":false,"context_lines":[{"line_number":12,"context_line":"of database traffic."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This mostly has impacts only on unit tests that mock these calls. However,"},{"line_number":15,"context_line":"this does touch the API which was still depending on the linkage by not"},{"line_number":16,"context_line":"explicitly asking for flavor."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I073305c2fb9bc448c5ed33d0edfab9399bbd319b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"fa1b9901_dea03c93","line":15,"updated":"2015-08-17 21:07:57.000000000","message":"Isn\u0027t this last sentence invalid for this change now that my simple-tenant-usage change landed and you rebased?","commit_id":"172f02483587a07da62384a686094e661fbe6936"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"77a401be541c416e4a1ce582ce046ab0a26a8954","unresolved":false,"context_lines":[{"line_number":12,"context_line":"of database traffic."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This mostly has impacts only on unit tests that mock these calls. However,"},{"line_number":15,"context_line":"this does touch the API which was still depending on the linkage by not"},{"line_number":16,"context_line":"explicitly asking for flavor."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I073305c2fb9bc448c5ed33d0edfab9399bbd319b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"fa1b9901_de86fcb8","line":15,"in_reply_to":"fa1b9901_dea03c93","updated":"2015-08-17 21:14:58.000000000","message":"Yep.","commit_id":"172f02483587a07da62384a686094e661fbe6936"}],"nova/api/openstack/compute/servers.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"32f20562386e904886431e834026230068bd84ff","unresolved":false,"context_lines":[{"line_number":227,"context_line":"                                                     limit\u003dlimit,"},{"line_number":228,"context_line":"                                                     marker\u003dmarker,"},{"line_number":229,"context_line":"                                                     want_objects\u003dTrue,"},{"line_number":230,"context_line":"                                                     expected_attrs\u003d[\u0027flavor\u0027],"},{"line_number":231,"context_line":"                                                     sort_keys\u003dsort_keys,"},{"line_number":232,"context_line":"                                                     sort_dirs\u003dsort_dirs)"},{"line_number":233,"context_line":"        except exception.MarkerNotFound:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_793f7ed6","line":230,"updated":"2015-08-05 07:31:26.000000000","message":"For index action needn\u0027t flavor. \n\nFor detail action, actually it only need flavor id https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/views/servers.py#L208\n\nAnd we have instance_type_id field in the instance object. So we needn\u0027t add flavor as expected_attrs.","commit_id":"866448e63084ad901a7d79808b3deeea0882aee0"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"003b87c796aee511f3d7647dc9c60d9c13c24c6a","unresolved":false,"context_lines":[{"line_number":227,"context_line":"                                                     limit\u003dlimit,"},{"line_number":228,"context_line":"                                                     marker\u003dmarker,"},{"line_number":229,"context_line":"                                                     want_objects\u003dTrue,"},{"line_number":230,"context_line":"                                                     expected_attrs\u003d[\u0027flavor\u0027],"},{"line_number":231,"context_line":"                                                     sort_keys\u003dsort_keys,"},{"line_number":232,"context_line":"                                                     sort_dirs\u003dsort_dirs)"},{"line_number":233,"context_line":"        except exception.MarkerNotFound:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_57a9028f","line":230,"in_reply_to":"1a4dcd0f_793f7ed6","updated":"2015-08-05 20:07:16.000000000","message":"Maybe this should be set if is_detail is true. However, I\u0027ll push up without this and we\u0027ll see if we\u0027re lazy-loading flavor in the logs.","commit_id":"866448e63084ad901a7d79808b3deeea0882aee0"}],"nova/objects/instance.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9b1338da458f63c3ede2a71c0324f63fb744ca0f","unresolved":false,"context_lines":[{"line_number":807,"context_line":"    def _load_flavor(self):"},{"line_number":808,"context_line":"        try:"},{"line_number":809,"context_line":"            instance \u003d self.__class__.get_by_uuid("},{"line_number":810,"context_line":"                self._context, uuid\u003dself.uuid,"},{"line_number":811,"context_line":"                expected_attrs\u003d[\u0027flavor\u0027, \u0027system_metadata\u0027])"},{"line_number":812,"context_line":"        except exception.InstanceNotFound:"},{"line_number":813,"context_line":"            # NOTE(danms): Before we had instance types in system_metadata,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a4dcd0f_4b6d1131","line":810,"updated":"2015-08-17 01:08:48.000000000","message":"Can we remove the system_metadata stuff here and below on L836 at some point?","commit_id":"8110ef29a69b121f32311eee7ac078cc31e7b879"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"41662d52dc3edab0026894ffac758b10b7914e78","unresolved":false,"context_lines":[{"line_number":807,"context_line":"    def _load_flavor(self):"},{"line_number":808,"context_line":"        try:"},{"line_number":809,"context_line":"            instance \u003d self.__class__.get_by_uuid("},{"line_number":810,"context_line":"                self._context, uuid\u003dself.uuid,"},{"line_number":811,"context_line":"                expected_attrs\u003d[\u0027flavor\u0027, \u0027system_metadata\u0027])"},{"line_number":812,"context_line":"        except exception.InstanceNotFound:"},{"line_number":813,"context_line":"            # NOTE(danms): Before we had instance types in system_metadata,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a4dcd0f_e64f7468","line":810,"in_reply_to":"1a4dcd0f_4b6d1131","updated":"2015-08-17 01:40:37.000000000","message":"Yep, certainly at some point. These kinds of changes tend to snowball in terms of effects on the tests, so I\u0027m just trying to make small changes to keep things sane.","commit_id":"8110ef29a69b121f32311eee7ac078cc31e7b879"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"bb5df9529413f366b5ad906d989178f8de697ad3","unresolved":false,"context_lines":[{"line_number":717,"context_line":""},{"line_number":718,"context_line":"        # NOTE(alaski): We need to pull system_metadata for the"},{"line_number":719,"context_line":"        # notification.send_update() below.  If we don\u0027t there\u0027s a KeyError"},{"line_number":720,"context_line":"        # when it tries to extract the flavor."},{"line_number":721,"context_line":"        # NOTE(danms): If we have sysmeta, we need flavor since the caller"},{"line_number":722,"context_line":"        # might be expecting flavor information as a result"},{"line_number":723,"context_line":"        if \u0027system_metadata\u0027 not in expected_attrs:"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa1b9901_1ed6b4c5","line":720,"updated":"2015-08-17 21:12:35.000000000","message":"Still need this?","commit_id":"172f02483587a07da62384a686094e661fbe6936"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"77a401be541c416e4a1ce582ce046ab0a26a8954","unresolved":false,"context_lines":[{"line_number":717,"context_line":""},{"line_number":718,"context_line":"        # NOTE(alaski): We need to pull system_metadata for the"},{"line_number":719,"context_line":"        # notification.send_update() below.  If we don\u0027t there\u0027s a KeyError"},{"line_number":720,"context_line":"        # when it tries to extract the flavor."},{"line_number":721,"context_line":"        # NOTE(danms): If we have sysmeta, we need flavor since the caller"},{"line_number":722,"context_line":"        # might be expecting flavor information as a result"},{"line_number":723,"context_line":"        if \u0027system_metadata\u0027 not in expected_attrs:"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa1b9901_fe6c200a","line":720,"in_reply_to":"fa1b9901_1ed6b4c5","updated":"2015-08-17 21:14:58.000000000","message":"Hmm, probably not.","commit_id":"172f02483587a07da62384a686094e661fbe6936"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1da11aaa1855d81ac0cf4980bd5053d03b5a5d3a","unresolved":false,"context_lines":[{"line_number":720,"context_line":"        # when it tries to extract the flavor."},{"line_number":721,"context_line":"        # NOTE(danms): If we have sysmeta, we need flavor since the caller"},{"line_number":722,"context_line":"        # might be expecting flavor information as a result"},{"line_number":723,"context_line":"        if \u0027system_metadata\u0027 not in expected_attrs:"},{"line_number":724,"context_line":"            expected_attrs.append(\u0027system_metadata\u0027)"},{"line_number":725,"context_line":"            expected_attrs.append(\u0027flavor\u0027)"},{"line_number":726,"context_line":"        old_ref, inst_ref \u003d db.instance_update_and_get_original("}],"source_content_type":"text/x-python","patch_set":8,"id":"fa1b9901_ced29800","line":723,"updated":"2015-08-18 18:00:08.000000000","message":"Just to reiterate from IRC, this needs to go at some point but it\u0027s complicated due to the tests, so Dan is going to do that on a separate change - also because there is an oslo.versionedobjects release dependent on this nova change landing otherwise tests will break (which are removed here, that\u0027s why we want it to land sooner than later).","commit_id":"5d3467b1b6b55ae4975432955c47fb65484ad01f"}],"nova/tests/unit/objects/test_instance.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ee432e06c4ecad575a994493171eb3cd85155f28","unresolved":false,"context_lines":[{"line_number":566,"context_line":"                mock.call(self.context, inst.uuid,"},{"line_number":567,"context_line":"                    {\u0027vm_state\u0027: \u0027foo\u0027, \u0027task_state\u0027: \u0027bar\u0027,"},{"line_number":568,"context_line":"                     \u0027cell_name\u0027: \u0027foo!bar@baz\u0027},"},{"line_number":569,"context_line":"                    columns_to_join\u003d[\u0027system_metadata\u0027,"},{"line_number":570,"context_line":"                                     \u0027extra\u0027, \u0027extra.flavor\u0027]),"},{"line_number":571,"context_line":"                mock.call(self.context, inst.uuid,"},{"line_number":572,"context_line":"                    {\u0027vm_state\u0027: \u0027bar\u0027, \u0027task_state\u0027: \u0027foo\u0027},"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa1b9901_5e174ca3","line":569,"updated":"2015-08-17 21:07:57.000000000","message":"uh oh someone\u0027s OCD is shining through :)","commit_id":"172f02483587a07da62384a686094e661fbe6936"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ee432e06c4ecad575a994493171eb3cd85155f28","unresolved":false,"context_lines":[{"line_number":570,"context_line":"                                     \u0027extra\u0027, \u0027extra.flavor\u0027]),"},{"line_number":571,"context_line":"                mock.call(self.context, inst.uuid,"},{"line_number":572,"context_line":"                    {\u0027vm_state\u0027: \u0027bar\u0027, \u0027task_state\u0027: \u0027foo\u0027},"},{"line_number":573,"context_line":"                          columns_to_join\u003d[\u0027system_metadata\u0027])]"},{"line_number":574,"context_line":"        mock_db_update.assert_has_calls(expected_calls)"},{"line_number":575,"context_line":""},{"line_number":576,"context_line":"    def test_skip_cells_api(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa1b9901_1e11d4ac","line":573,"updated":"2015-08-17 21:07:57.000000000","message":"nit: this makes the alignment a bit odd now, but I see what you were doing.","commit_id":"172f02483587a07da62384a686094e661fbe6936"}]}