)]}'
{"nova/tests/unit/virt/ironic/test_driver.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"785fd2f653032e5bf831faeb717a69da68288938","unresolved":false,"context_lines":[{"line_number":1152,"context_line":"            # reset mocks for the next interaction"},{"line_number":1153,"context_line":"            mock_node.get_by_instance_uuid.reset_mock()"},{"line_number":1154,"context_line":"            mock_unprovision.reset_mock()"},{"line_number":1155,"context_line":"            mock_cleanup_deploy.reset_mock()"},{"line_number":1156,"context_line":""},{"line_number":1157,"context_line":"    @mock.patch.object(FAKE_CLIENT, \u0027node\u0027)"},{"line_number":1158,"context_line":"    @mock.patch.object(ironic_driver.IronicDriver, \u0027_cleanup_deploy\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_e66339dc","line":1155,"updated":"2015-09-08 18:19:58.000000000","message":"This is good in that it checks all the unprovision states, but doesn\u0027t it miss the case that was tested by this method before, where we don\u0027t call unprovision?\n\nSeems like this should be a new test in _addition_ to the one that was already there, no?","commit_id":"96c17409e3867907f13a7eb241801c7e667d0cae"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"4165efc3cce446cab9aecac2afdcbe5a382218d6","unresolved":false,"context_lines":[{"line_number":1152,"context_line":"            # reset mocks for the next interaction"},{"line_number":1153,"context_line":"            mock_node.get_by_instance_uuid.reset_mock()"},{"line_number":1154,"context_line":"            mock_unprovision.reset_mock()"},{"line_number":1155,"context_line":"            mock_cleanup_deploy.reset_mock()"},{"line_number":1156,"context_line":""},{"line_number":1157,"context_line":"    @mock.patch.object(FAKE_CLIENT, \u0027node\u0027)"},{"line_number":1158,"context_line":"    @mock.patch.object(ironic_driver.IronicDriver, \u0027_cleanup_deploy\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_3f029473","line":1155,"in_reply_to":"da20952f_e66339dc","updated":"2015-09-08 19:55:12.000000000","message":"Right, the reasoning (if I recall well) was that _unprovision() already has his own set of tests [1]. As for destroy() it only needs to check if _unprovision() is being called for the right states instead of testing _unprovision() as part of the destroy() test itself. \n\nIf you guys feel that we should test it as a whole (destroy() and _unprovision()) here I can add it back.\n\n[1] https://github.com/openstack/nova/blob/master/nova/tests/unit/virt/ironic/test_driver.py#L1214-L1265","commit_id":"96c17409e3867907f13a7eb241801c7e667d0cae"}],"nova/virt/ironic/ironic_states.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"1669c07838a593774ab3c1b206b32012eceec376","unresolved":false,"context_lines":[{"line_number":128,"context_line":"inspected node shall transition to MANAGEABLE status."},{"line_number":129,"context_line":"\"\"\""},{"line_number":130,"context_line":""},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"INSPECTFAIL \u003d \u0027inspect failed\u0027"},{"line_number":133,"context_line":"\"\"\" Node inspection failed. \"\"\""},{"line_number":134,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_51f15d00","side":"PARENT","line":131,"updated":"2015-09-09 13:50:31.000000000","message":"Random whitespace damage!","commit_id":"8cf2228ea1a8c70c51ac1c3e862e1783e0ec1df1"}]}