)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":15701,"name":"venkatesh","email":"p.venkatesh551@gmail.com","username":"venkatesh"},"change_message_id":"1388e04057dc2667fa62f1a2c25c85ee567aae0e","unresolved":false,"context_lines":[{"line_number":2064,"context_line":"                exception.UnexpectedDeletingTaskStateError):"},{"line_number":2065,"context_line":"            raise"},{"line_number":2066,"context_line":"        except (exception.UnexpectedTaskStateError,"},{"line_number":2067,"context_line":"                exception.InvalidBDMOverQuota) as e:"},{"line_number":2068,"context_line":"            raise exception.BuildAbortException(instance_uuid\u003dinstance.uuid,"},{"line_number":2069,"context_line":"                    reason\u003de.format_message())"},{"line_number":2070,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_b402286e","line":2067,"updated":"2015-08-10 09:07:38.000000000","message":"wrong location for catching the InvalidBDMOverQuota  exception .\n It will never occur at this place, because we are building network for instances","commit_id":"bbb70bd34da02330712fefdd6dbf79d4eeac36a5"},{"author":{"_account_id":3068,"name":"Arata Notsu","email":"notsu@virtualtech.jp","username":"arata776"},"change_message_id":"66ec0d2789bcdf794d588c1acd94384f0ffb2de2","unresolved":false,"context_lines":[{"line_number":2064,"context_line":"                exception.UnexpectedDeletingTaskStateError):"},{"line_number":2065,"context_line":"            raise"},{"line_number":2066,"context_line":"        except (exception.UnexpectedTaskStateError,"},{"line_number":2067,"context_line":"                exception.InvalidBDMOverQuota) as e:"},{"line_number":2068,"context_line":"            raise exception.BuildAbortException(instance_uuid\u003dinstance.uuid,"},{"line_number":2069,"context_line":"                    reason\u003de.format_message())"},{"line_number":2070,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_0badf787","line":2067,"in_reply_to":"1a4dcd0f_b402286e","updated":"2015-08-10 10:20:19.000000000","message":"Thanks for pointing it out. I put it at this wrong position when I copy it from my dev env by hand...","commit_id":"bbb70bd34da02330712fefdd6dbf79d4eeac36a5"},{"author":{"_account_id":15701,"name":"venkatesh","email":"p.venkatesh551@gmail.com","username":"venkatesh"},"change_message_id":"1388e04057dc2667fa62f1a2c25c85ee567aae0e","unresolved":false,"context_lines":[{"line_number":2094,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":2095,"context_line":"                # Make sure the async call finishes"},{"line_number":2096,"context_line":"                if network_info is not None:"},{"line_number":2097,"context_line":"                    network_info.wait(do_raise\u003dFalse)"},{"line_number":2098,"context_line":"        except exception.UnexpectedTaskStateError as e:"},{"line_number":2099,"context_line":"            # Make sure the async call finishes"},{"line_number":2100,"context_line":"            if network_info is not None:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_543f2425","line":2097,"updated":"2015-08-10 09:07:38.000000000","message":"catch InvalidBDM exception also here, which can handle InvalidBDMOverQuota exception also.\n\nBut\nLast except clause  in the code handles the InvalidBDM exception cases but above change improves readability","commit_id":"bbb70bd34da02330712fefdd6dbf79d4eeac36a5"},{"author":{"_account_id":3068,"name":"Arata Notsu","email":"notsu@virtualtech.jp","username":"arata776"},"change_message_id":"66ec0d2789bcdf794d588c1acd94384f0ffb2de2","unresolved":false,"context_lines":[{"line_number":2094,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":2095,"context_line":"                # Make sure the async call finishes"},{"line_number":2096,"context_line":"                if network_info is not None:"},{"line_number":2097,"context_line":"                    network_info.wait(do_raise\u003dFalse)"},{"line_number":2098,"context_line":"        except exception.UnexpectedTaskStateError as e:"},{"line_number":2099,"context_line":"            # Make sure the async call finishes"},{"line_number":2100,"context_line":"            if network_info is not None:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_cbb5cfd0","line":2097,"in_reply_to":"1a4dcd0f_543f2425","updated":"2015-08-10 10:20:19.000000000","message":"Done","commit_id":"bbb70bd34da02330712fefdd6dbf79d4eeac36a5"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"5094b95c872d529f0b5f7fe62107e52da8e28dfe","unresolved":false,"context_lines":[{"line_number":1728,"context_line":"            msg \u003d _LW(\u0027Failed to create block device for instance due to \u0027"},{"line_number":1729,"context_line":"                      \u0027being over volume resource quota\u0027)"},{"line_number":1730,"context_line":"            LOG.warn(msg, instance\u003dinstance)"},{"line_number":1731,"context_line":"            raise exception.InvalidBDMOverQuota()"},{"line_number":1732,"context_line":""},{"line_number":1733,"context_line":"        except Exception:"},{"line_number":1734,"context_line":"            LOG.exception(_LE(\u0027Instance failed block device setup\u0027),"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_93ce1482","line":1731,"updated":"2015-08-10 13:17:44.000000000","message":"InvalidBDMOverQuota name is weird...","commit_id":"f5b1be185b7b5d48a181e53a96077b224d54b280"},{"author":{"_account_id":3068,"name":"Arata Notsu","email":"notsu@virtualtech.jp","username":"arata776"},"change_message_id":"e1e3d4623758a8d5a7d432dcfc334403472920b3","unresolved":false,"context_lines":[{"line_number":1728,"context_line":"            msg \u003d _LW(\u0027Failed to create block device for instance due to \u0027"},{"line_number":1729,"context_line":"                      \u0027being over volume resource quota\u0027)"},{"line_number":1730,"context_line":"            LOG.warn(msg, instance\u003dinstance)"},{"line_number":1731,"context_line":"            raise exception.InvalidBDMOverQuota()"},{"line_number":1732,"context_line":""},{"line_number":1733,"context_line":"        except Exception:"},{"line_number":1734,"context_line":"            LOG.exception(_LE(\u0027Instance failed block device setup\u0027),"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_5292bd4c","line":1731,"in_reply_to":"1a4dcd0f_93ce1482","updated":"2015-08-10 16:09:37.000000000","message":"Right. I use the VolumeLimitExceeded anyway.","commit_id":"f5b1be185b7b5d48a181e53a96077b224d54b280"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"5094b95c872d529f0b5f7fe62107e52da8e28dfe","unresolved":false,"context_lines":[{"line_number":2095,"context_line":"                if network_info is not None:"},{"line_number":2096,"context_line":"                    network_info.wait(do_raise\u003dFalse)"},{"line_number":2097,"context_line":"        except (exception.UnexpectedTaskStateError,"},{"line_number":2098,"context_line":"                exception.InvalidBDM) as e:"},{"line_number":2099,"context_line":"            # Make sure the async call finishes"},{"line_number":2100,"context_line":"            if network_info is not None:"},{"line_number":2101,"context_line":"                network_info.wait(do_raise\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_d3257c5c","line":2098,"updated":"2015-08-10 13:17:44.000000000","message":"are u suggesting exception.InvalidBDMOverQuota?","commit_id":"f5b1be185b7b5d48a181e53a96077b224d54b280"},{"author":{"_account_id":3068,"name":"Arata Notsu","email":"notsu@virtualtech.jp","username":"arata776"},"change_message_id":"e1e3d4623758a8d5a7d432dcfc334403472920b3","unresolved":false,"context_lines":[{"line_number":2095,"context_line":"                if network_info is not None:"},{"line_number":2096,"context_line":"                    network_info.wait(do_raise\u003dFalse)"},{"line_number":2097,"context_line":"        except (exception.UnexpectedTaskStateError,"},{"line_number":2098,"context_line":"                exception.InvalidBDM) as e:"},{"line_number":2099,"context_line":"            # Make sure the async call finishes"},{"line_number":2100,"context_line":"            if network_info is not None:"},{"line_number":2101,"context_line":"                network_info.wait(do_raise\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_9fa5ae48","line":2098,"in_reply_to":"1a4dcd0f_d3257c5c","updated":"2015-08-10 16:09:37.000000000","message":"No, I mean to catch InvalidBDM here. I did it for readability (venkatesh suggested me at patchset2). It seems reasonable in logging view point as well; LOG.exception() for InvalidBDM is already called at L1734 and should not be called again at L2105.","commit_id":"f5b1be185b7b5d48a181e53a96077b224d54b280"}]}