)]}'
{"nova/objects/instance.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"f2f9b4ba4c18fb750d8adba5b2de20e11ce98d01","unresolved":false,"context_lines":[{"line_number":231,"context_line":"        \u0027security_groups\u0027: [(\u00271.2\u0027, \u00271.0\u0027)],"},{"line_number":232,"context_line":"        \u0027numa_topology\u0027: [(\u00271.14\u0027, \u00271.0\u0027), (\u00271.16\u0027, \u00271.1\u0027), (\u00271.22\u0027, \u00271.2\u0027)],"},{"line_number":233,"context_line":"        \u0027pci_devices\u0027: [(\u00271.6\u0027, \u00271.0\u0027), (\u00271.15\u0027, \u00271.1\u0027), (\u00271.18\u0027, \u00271.2\u0027),"},{"line_number":234,"context_line":"                        (\u00271.22\u0027, \u00271.3\u0027)],"},{"line_number":235,"context_line":"        \u0027pci_requests\u0027: [(\u00271.16\u0027, \u00271.1\u0027)],"},{"line_number":236,"context_line":"        \u0027tags\u0027: [(\u00271.17\u0027, \u00271.0\u0027), (\u00271.21\u0027, \u00271.1\u0027)],"},{"line_number":237,"context_line":"        \u0027flavor\u0027: [(\u00271.18\u0027, \u00271.1\u0027)],"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_a7c6a547","line":234,"range":{"start_line":234,"start_character":26,"end_line":234,"end_character":30},"updated":"2015-08-07 21:20:10.000000000","message":"Shouldn\u0027t this be 1.23?","commit_id":"188630d503afb16f5c40dfbb4d37bba65c318f94"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"26a33f5b76711e5d88dda738f7745b47cbdf047d","unresolved":false,"context_lines":[{"line_number":231,"context_line":"        \u0027security_groups\u0027: [(\u00271.2\u0027, \u00271.0\u0027)],"},{"line_number":232,"context_line":"        \u0027numa_topology\u0027: [(\u00271.14\u0027, \u00271.0\u0027), (\u00271.16\u0027, \u00271.1\u0027), (\u00271.22\u0027, \u00271.2\u0027)],"},{"line_number":233,"context_line":"        \u0027pci_devices\u0027: [(\u00271.6\u0027, \u00271.0\u0027), (\u00271.15\u0027, \u00271.1\u0027), (\u00271.18\u0027, \u00271.2\u0027),"},{"line_number":234,"context_line":"                        (\u00271.22\u0027, \u00271.3\u0027)],"},{"line_number":235,"context_line":"        \u0027pci_requests\u0027: [(\u00271.16\u0027, \u00271.1\u0027)],"},{"line_number":236,"context_line":"        \u0027tags\u0027: [(\u00271.17\u0027, \u00271.0\u0027), (\u00271.21\u0027, \u00271.1\u0027)],"},{"line_number":237,"context_line":"        \u0027flavor\u0027: [(\u00271.18\u0027, \u00271.1\u0027)],"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_65b87ee6","line":234,"in_reply_to":"1a4dcd0f_a7c6a547","updated":"2015-08-09 15:39:44.000000000","message":"Yes, good catch. I went through about 4 different iterations of playing the version bump dance with this... :)","commit_id":"188630d503afb16f5c40dfbb4d37bba65c318f94"}],"nova/objects/pci_device.py":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"2a84255e74c7e4e0b34107d89b08f59d7ee57c98","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    # Version 1.1: String attributes updated to support unicode"},{"line_number":87,"context_line":"    # Version 1.2: added request_id field"},{"line_number":88,"context_line":"    # Version 1.3: Added field to represent PCI device NUMA node"},{"line_number":89,"context_line":"    # Version 1.4: Changed status to a PciDeviceStatusField from StringFielD"},{"line_number":90,"context_line":"    VERSION \u003d \u00271.4\u0027"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    fields \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_8471430e","line":89,"updated":"2015-08-07 11:43:28.000000000","message":"s/D/d/","commit_id":"9a89a0da63333d0e459554b2f38c652927c22724"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"e56567cdd42627867dd515dbc2013d400af9db98","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    # Version 1.1: String attributes updated to support unicode"},{"line_number":87,"context_line":"    # Version 1.2: added request_id field"},{"line_number":88,"context_line":"    # Version 1.3: Added field to represent PCI device NUMA node"},{"line_number":89,"context_line":"    # Version 1.4: Changed status to a PciDeviceStatusField from StringFielD"},{"line_number":90,"context_line":"    VERSION \u003d \u00271.4\u0027"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    fields \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_1529db89","line":89,"in_reply_to":"1a4dcd0f_8471430e","updated":"2015-08-07 12:14:58.000000000","message":"Done","commit_id":"9a89a0da63333d0e459554b2f38c652927c22724"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"2a84255e74c7e4e0b34107d89b08f59d7ee57c98","unresolved":false,"context_lines":[{"line_number":207,"context_line":"    # Version 1.1: PciDevice 1.2"},{"line_number":208,"context_line":"    # Version 1.2: PciDevice 1.3"},{"line_number":209,"context_line":"    # Version 1.3: PciDevice 1.4"},{"line_number":210,"context_line":"    VERSION \u003d \u00271.3\u0027"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"    fields \u003d {"},{"line_number":213,"context_line":"        \u0027objects\u0027: fields.ListOfObjectsField(\u0027PciDevice\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_bfc24683","line":210,"updated":"2015-08-07 11:43:28.000000000","message":"IIIUC, this means we now have to bump Instance object version to record that it can take version 1.3, which has a ripple on more object versions","commit_id":"9a89a0da63333d0e459554b2f38c652927c22724"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"e56567cdd42627867dd515dbc2013d400af9db98","unresolved":false,"context_lines":[{"line_number":207,"context_line":"    # Version 1.1: PciDevice 1.2"},{"line_number":208,"context_line":"    # Version 1.2: PciDevice 1.3"},{"line_number":209,"context_line":"    # Version 1.3: PciDevice 1.4"},{"line_number":210,"context_line":"    VERSION \u003d \u00271.3\u0027"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"    fields \u003d {"},{"line_number":213,"context_line":"        \u0027objects\u0027: fields.ListOfObjectsField(\u0027PciDevice\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_551c4369","line":210,"in_reply_to":"1a4dcd0f_bfc24683","updated":"2015-08-07 12:14:58.000000000","message":"Done","commit_id":"9a89a0da63333d0e459554b2f38c652927c22724"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"4d7950350005c535c59bc2af8be9777e1c188561","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        \u0027vendor_id\u0027: fields.StringField(),"},{"line_number":99,"context_line":"        \u0027product_id\u0027: fields.StringField(),"},{"line_number":100,"context_line":"        \u0027dev_type\u0027: fields.StringField(),"},{"line_number":101,"context_line":"        \u0027status\u0027: fields.PciDeviceStatusField(),"},{"line_number":102,"context_line":"        \u0027dev_id\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":103,"context_line":"        \u0027label\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":104,"context_line":"        \u0027instance_uuid\u0027: fields.StringField(nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_46799ffb","line":101,"updated":"2015-08-10 17:00:25.000000000","message":"Assuming this encompasses every possible status, you don\u0027t need a version bump for this. Just make the change and fix the hash. No need to bump this and all dependent objects.","commit_id":"6e84de766c2f2a513085a796c7b8e6da422aeed5"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"af1afbf85694d3492dede10e7d87399651288e8b","unresolved":false,"context_lines":[{"line_number":212,"context_line":"        }"},{"line_number":213,"context_line":"    # NOTE(danms): PciDevice was at 1.1 before we added this"},{"line_number":214,"context_line":"    obj_relationships \u003d {"},{"line_number":215,"context_line":"        \u0027objects\u0027: [(\u00271.0\u0027, \u00271.1\u0027), (\u00271.1\u0027, \u00271.2\u0027), (\u00271.2\u0027, \u00271.3\u0027)]"},{"line_number":216,"context_line":"        }"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    def __init__(self, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a4dcd0f_e8fe7504","line":215,"updated":"2015-08-10 17:49:12.000000000","message":"You removed the trailing comma from this","commit_id":"48cafc4f4dcc808ecedb5b9b7591a5fa06d08e12"}],"nova/pci/manager.py":[{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"5a1c069776612c8c16da5ac66e7cb765c274dd8c","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        self.claims \u003d collections.defaultdict(list)"},{"line_number":66,"context_line":"        for dev in self.pci_devs:"},{"line_number":67,"context_line":"            uuid \u003d dev.instance_uuid"},{"line_number":68,"context_line":"            if dev.status \u003d\u003d fields.PciDeviceStatus.CLAIMED:"},{"line_number":69,"context_line":"                self.claims[uuid].append(dev)"},{"line_number":70,"context_line":"            elif dev.status \u003d\u003d fields.PciDeviceStatus.ALLOCATED:"},{"line_number":71,"context_line":"                self.allocations[uuid].append(dev)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a4dcd0f_32fee838","line":68,"updated":"2015-08-11 10:45:43.000000000","message":"I put this comment randomly here but it applies to all the places that do this type of change. It\u0027s unfortunate that we define all the constants on a custom field subclass that is in no way linked to the object it refers to.\n\nI would much rather see something like\n\n  if dev.status \u003d\u003d objects.PciDevice.status.CLAIMED:\n     # do stuff\n\nthis is of course not related to this patch - I am just commenting on how we could make the code look and feel nicer.","commit_id":"cac9d52d07d49dce72da20b8c84679ac1a6560c7"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"aebc619516f5cd4edb3b09b7b14aa1fb0c46286d","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        self.claims \u003d collections.defaultdict(list)"},{"line_number":66,"context_line":"        for dev in self.pci_devs:"},{"line_number":67,"context_line":"            uuid \u003d dev.instance_uuid"},{"line_number":68,"context_line":"            if dev.status \u003d\u003d fields.PciDeviceStatus.CLAIMED:"},{"line_number":69,"context_line":"                self.claims[uuid].append(dev)"},{"line_number":70,"context_line":"            elif dev.status \u003d\u003d fields.PciDeviceStatus.ALLOCATED:"},{"line_number":71,"context_line":"                self.allocations[uuid].append(dev)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a4dcd0f_bdb96930","line":68,"in_reply_to":"1a4dcd0f_32fee838","updated":"2015-08-11 10:47:59.000000000","message":"You are assuming that each enum is only used by a single object type. There are a fair number of enums that are used by many different objects.  As such it is preferrable to refer to enum constants directly and not involve the object type.","commit_id":"cac9d52d07d49dce72da20b8c84679ac1a6560c7"}],"nova/tests/unit/db/test_db_api.py":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"2a84255e74c7e4e0b34107d89b08f59d7ee57c98","unresolved":false,"context_lines":[{"line_number":4384,"context_line":"            \u0027leased\u0027: False,"},{"line_number":4385,"context_line":"            \u0027host\u0027: \u0027127.0.0.1\u0027,"},{"line_number":4386,"context_line":"            \u0027address\u0027: \u0027192.168.1.5\u0027,"},{"line_number":4387,"context_line":"            fields.PciDeviceStatus.ALLOCATED: False,"},{"line_number":4388,"context_line":"            \u0027instance_uuid\u0027: instance_uuid,"},{"line_number":4389,"context_line":"            \u0027network_id\u0027: network_id,"},{"line_number":4390,"context_line":"            \u0027virtual_interface_id\u0027: None"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_241b8f82","line":4387,"updated":"2015-08-07 11:43:28.000000000","message":"I\u0027m not convinced this is a valid replacement.\n\nThe PciDeviceStatus enum is being used as the /value/ for the \u0027status\u0027 key in the PCI device object.\n\nHere you have a /key/ \u0027allocated\u0027 which just happens to be the same string as one of the PciDeviceStatus enum /values/.\n\nIOW, (unless I\u0027m confused) we have two strings that just happ to be \"allocated\", but they are different use contexts, so I don\u0027t think we should use the enum here..\n\nSame for various places below.","commit_id":"9a89a0da63333d0e459554b2f38c652927c22724"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"2a84255e74c7e4e0b34107d89b08f59d7ee57c98","unresolved":false,"context_lines":[{"line_number":4467,"context_line":"            \u0027leased\u0027: False,"},{"line_number":4468,"context_line":"            \u0027host\u0027: \u0027127.0.0.1\u0027,"},{"line_number":4469,"context_line":"            \u0027address\u0027: address,"},{"line_number":4470,"context_line":"            fields.PciDeviceStatus.ALLOCATED: False,"},{"line_number":4471,"context_line":"            \u0027instance_uuid\u0027: instance_uuid,"},{"line_number":4472,"context_line":"            \u0027network_id\u0027: network_id,"},{"line_number":4473,"context_line":"            \u0027virtual_interface_id\u0027: vif[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_64051712","line":4470,"updated":"2015-08-07 11:43:28.000000000","message":"Here.","commit_id":"9a89a0da63333d0e459554b2f38c652927c22724"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"2a84255e74c7e4e0b34107d89b08f59d7ee57c98","unresolved":false,"context_lines":[{"line_number":4497,"context_line":"            \u0027leased\u0027: False,"},{"line_number":4498,"context_line":"            \u0027host\u0027: \u0027127.0.0.1\u0027,"},{"line_number":4499,"context_line":"            \u0027address\u0027: address,"},{"line_number":4500,"context_line":"            fields.PciDeviceStatus.ALLOCATED: False,"},{"line_number":4501,"context_line":"            \u0027instance_uuid\u0027: instance_uuid,"},{"line_number":4502,"context_line":"            \u0027network_id\u0027: network_id,"},{"line_number":4503,"context_line":"            \u0027virtual_interface_id\u0027: None"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_3f05d60f","line":4500,"updated":"2015-08-07 11:43:28.000000000","message":"Here","commit_id":"9a89a0da63333d0e459554b2f38c652927c22724"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"2a84255e74c7e4e0b34107d89b08f59d7ee57c98","unresolved":false,"context_lines":[{"line_number":4518,"context_line":"            \u0027leased\u0027: False,"},{"line_number":4519,"context_line":"            \u0027host\u0027: \u0027127.0.0.1\u0027,"},{"line_number":4520,"context_line":"            \u0027address\u0027: address,"},{"line_number":4521,"context_line":"            fields.PciDeviceStatus.ALLOCATED: False,"},{"line_number":4522,"context_line":"            \u0027instance_uuid\u0027: instance_uuid,"},{"line_number":4523,"context_line":"            \u0027network_id\u0027: network_id,"},{"line_number":4524,"context_line":"            \u0027virtual_interface_id\u0027: None"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_bf11e653","line":4521,"updated":"2015-08-07 11:43:28.000000000","message":"Here","commit_id":"9a89a0da63333d0e459554b2f38c652927c22724"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"2a84255e74c7e4e0b34107d89b08f59d7ee57c98","unresolved":false,"context_lines":[{"line_number":5907,"context_line":"            {\u0027instance_uuid\u0027: instance.uuid, \u0027network_id\u0027: network.id,"},{"line_number":5908,"context_line":"            \u0027address\u0027: ip})"},{"line_number":5909,"context_line":"        db.fixed_ip_create(self.ctxt, {\u0027address\u0027: ip,"},{"line_number":5910,"context_line":"            \u0027network_id\u0027: network.id, fields.PciDeviceStatus.ALLOCATED: True,"},{"line_number":5911,"context_line":"            \u0027virtual_interface_id\u0027: virtual_interface.id})"},{"line_number":5912,"context_line":"        db.fixed_ip_associate(self.ctxt, ip, instance.uuid,"},{"line_number":5913,"context_line":"            network.id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_7f17de44","line":5910,"updated":"2015-08-07 11:43:28.000000000","message":"Here","commit_id":"9a89a0da63333d0e459554b2f38c652927c22724"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"2a84255e74c7e4e0b34107d89b08f59d7ee57c98","unresolved":false,"context_lines":[{"line_number":5923,"context_line":"            {\u0027instance_uuid\u0027: instance.uuid, \u0027network_id\u0027: network2.id,"},{"line_number":5924,"context_line":"            \u0027address\u0027: ip})"},{"line_number":5925,"context_line":"        db.fixed_ip_create(self.ctxt, {\u0027address\u0027: ip,"},{"line_number":5926,"context_line":"            \u0027network_id\u0027: network2.id, fields.PciDeviceStatus.ALLOCATED: True,"},{"line_number":5927,"context_line":"            \u0027virtual_interface_id\u0027: virtual_interface.id})"},{"line_number":5928,"context_line":"        db.fixed_ip_associate(self.ctxt, ip, instance.uuid,"},{"line_number":5929,"context_line":"            network2.id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_1f29fa89","line":5926,"updated":"2015-08-07 11:43:28.000000000","message":"Here","commit_id":"9a89a0da63333d0e459554b2f38c652927c22724"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"2a84255e74c7e4e0b34107d89b08f59d7ee57c98","unresolved":false,"context_lines":[{"line_number":5942,"context_line":"        self.assertEqual(\u0027192.0.2.1\u0027, data[0][\u0027address\u0027])"},{"line_number":5943,"context_line":"        self.assertEqual(\u0027192.0.2.1\u0027, data[0][\u0027vif_address\u0027])"},{"line_number":5944,"context_line":"        self.assertEqual(instance.uuid, data[0][\u0027instance_uuid\u0027])"},{"line_number":5945,"context_line":"        self.assertTrue(data[0][fields.PciDeviceStatus.ALLOCATED])"},{"line_number":5946,"context_line":""},{"line_number":5947,"context_line":"    def test_network_create_safe(self):"},{"line_number":5948,"context_line":"        values \u003d {\u0027host\u0027: \u0027localhost\u0027, \u0027project_id\u0027: \u0027project1\u0027}"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_df1e325e","line":5945,"updated":"2015-08-07 11:43:28.000000000","message":"Hre","commit_id":"9a89a0da63333d0e459554b2f38c652927c22724"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"2a84255e74c7e4e0b34107d89b08f59d7ee57c98","unresolved":false,"context_lines":[{"line_number":5966,"context_line":"        address1 \u003d db.fixed_ip_create(self.ctxt, values)[\u0027address\u0027]"},{"line_number":5967,"context_line":"        values \u003d {\u0027network_id\u0027: network[\u0027id\u0027],"},{"line_number":5968,"context_line":"                  \u0027address\u0027: \u0027192.168.1.6\u0027,"},{"line_number":5969,"context_line":"                  fields.PciDeviceStatus.ALLOCATED: True}"},{"line_number":5970,"context_line":"        address2 \u003d db.fixed_ip_create(self.ctxt, values)[\u0027address\u0027]"},{"line_number":5971,"context_line":"        self.assertRaises(exception.NetworkInUse,"},{"line_number":5972,"context_line":"                          db.network_delete_safe, self.ctxt, network[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_9f3d0ac6","line":5969,"updated":"2015-08-07 11:43:28.000000000","message":"Here","commit_id":"9a89a0da63333d0e459554b2f38c652927c22724"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"2a84255e74c7e4e0b34107d89b08f59d7ee57c98","unresolved":false,"context_lines":[{"line_number":5985,"context_line":"        vif \u003d db.virtual_interface_create(self.ctxt, values)"},{"line_number":5986,"context_line":"        values \u003d {\u0027address\u0027: \u0027192.168.1.6\u0027,"},{"line_number":5987,"context_line":"                  \u0027network_id\u0027: 1,"},{"line_number":5988,"context_line":"                  fields.PciDeviceStatus.ALLOCATED: True,"},{"line_number":5989,"context_line":"                  \u0027instance_uuid\u0027: instance[\u0027uuid\u0027],"},{"line_number":5990,"context_line":"                  \u0027virtual_interface_id\u0027: vif[\u0027id\u0027]}"},{"line_number":5991,"context_line":"        db.fixed_ip_create(self.ctxt, values)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_bf3806d4","line":5988,"updated":"2015-08-07 11:43:28.000000000","message":"Here","commit_id":"9a89a0da63333d0e459554b2f38c652927c22724"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"2a84255e74c7e4e0b34107d89b08f59d7ee57c98","unresolved":false,"context_lines":[{"line_number":8263,"context_line":"                \u0027dev_id\u0027: \u0027pci_0000:0f:08.7\u0027,"},{"line_number":8264,"context_line":"                \u0027extra_info\u0027: None,"},{"line_number":8265,"context_line":"                \u0027label\u0027: \u0027label_8086_1520\u0027,"},{"line_number":8266,"context_line":"                \u0027status\u0027: fields.PciDeviceStatus.AVAILABLE,"},{"line_number":8267,"context_line":"                \u0027instance_uuid\u0027: \u002700000000-0000-0000-0000-000000000010\u0027,"},{"line_number":8268,"context_line":"                \u0027request_id\u0027: None,"},{"line_number":8269,"context_line":"                }, {\u0027id\u0027: 3356,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_7f2efe8c","line":8266,"updated":"2015-08-07 11:43:28.000000000","message":"This looks ok though","commit_id":"9a89a0da63333d0e459554b2f38c652927c22724"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"2a84255e74c7e4e0b34107d89b08f59d7ee57c98","unresolved":false,"context_lines":[{"line_number":8345,"context_line":"    def test_pci_device_get_by_instance_uuid(self):"},{"line_number":8346,"context_line":"        v1, v2 \u003d self._create_fake_pci_devs()"},{"line_number":8347,"context_line":"        v1[\u0027status\u0027] \u003d fields.PciDeviceStatus.ALLOCATED"},{"line_number":8348,"context_line":"        v2[\u0027status\u0027] \u003d fields.PciDeviceStatus.ALLOCATED"},{"line_number":8349,"context_line":"        db.pci_device_update(self.admin_context, v1[\u0027compute_node_id\u0027],"},{"line_number":8350,"context_line":"                             v1[\u0027address\u0027], v1)"},{"line_number":8351,"context_line":"        db.pci_device_update(self.admin_context, v2[\u0027compute_node_id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_9f442a4a","line":8348,"updated":"2015-08-07 11:43:28.000000000","message":"This is ok too, and similar below","commit_id":"9a89a0da63333d0e459554b2f38c652927c22724"}]}
