)]}'
{"nova/objects/fields.py":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"f52143df1d08cd6be4b3c8e99d6d5f98de0388e7","unresolved":false,"context_lines":[{"line_number":397,"context_line":""},{"line_number":398,"context_line":"class PciDeviceType(Enum):"},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"    # NOTE(jaypipes): It\u0027s silly that the word \"type-\" is in these constants,"},{"line_number":401,"context_line":"    # but alas, these were the original constant strings used..."},{"line_number":402,"context_line":"    STANDARD \u003d \"type-PCI\""},{"line_number":403,"context_line":"    SRIOV_PF \u003d \"type-PF\""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a4dcd0f_e95dfb15","line":400,"updated":"2015-08-11 09:23:44.000000000","message":"I always complain when people stamp code with name when no action is required actually :)","commit_id":"9b7e78976886ba571e914eb3ae20503ca410b895"}],"nova/objects/instance.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"7c851f7bbcdcbf73aa652a9f2fc82e7a7dc05ade","unresolved":false,"context_lines":[{"line_number":232,"context_line":"        \u0027security_groups\u0027: [(\u00271.2\u0027, \u00271.0\u0027)],"},{"line_number":233,"context_line":"        \u0027numa_topology\u0027: [(\u00271.14\u0027, \u00271.0\u0027), (\u00271.16\u0027, \u00271.1\u0027), (\u00271.22\u0027, \u00271.2\u0027)],"},{"line_number":234,"context_line":"        \u0027pci_devices\u0027: [(\u00271.6\u0027, \u00271.0\u0027), (\u00271.15\u0027, \u00271.1\u0027), (\u00271.18\u0027, \u00271.2\u0027),"},{"line_number":235,"context_line":"                        (\u00271.22\u0027, \u00271.3\u0027), (\u00271.23\u0027, \u00271.4\u0027)],"},{"line_number":236,"context_line":"        \u0027pci_requests\u0027: [(\u00271.16\u0027, \u00271.1\u0027)],"},{"line_number":237,"context_line":"        \u0027tags\u0027: [(\u00271.17\u0027, \u00271.0\u0027), (\u00271.21\u0027, \u00271.1\u0027)],"},{"line_number":238,"context_line":"        \u0027flavor\u0027: [(\u00271.18\u0027, \u00271.1\u0027)],"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_7aaef0e8","line":235,"range":{"start_line":235,"start_character":43,"end_line":235,"end_character":47},"updated":"2015-08-07 21:26:46.000000000","message":"Shouldn\u0027t this be 1.24?","commit_id":"8a22768127146fa72e16b96b59c2fcd94c2023dd"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"54687266e9602616054479c912b1afc5c3773dc7","unresolved":false,"context_lines":[{"line_number":232,"context_line":"        \u0027security_groups\u0027: [(\u00271.2\u0027, \u00271.0\u0027)],"},{"line_number":233,"context_line":"        \u0027numa_topology\u0027: [(\u00271.14\u0027, \u00271.0\u0027), (\u00271.16\u0027, \u00271.1\u0027), (\u00271.22\u0027, \u00271.2\u0027)],"},{"line_number":234,"context_line":"        \u0027pci_devices\u0027: [(\u00271.6\u0027, \u00271.0\u0027), (\u00271.15\u0027, \u00271.1\u0027), (\u00271.18\u0027, \u00271.2\u0027),"},{"line_number":235,"context_line":"                        (\u00271.22\u0027, \u00271.3\u0027), (\u00271.23\u0027, \u00271.4\u0027)],"},{"line_number":236,"context_line":"        \u0027pci_requests\u0027: [(\u00271.16\u0027, \u00271.1\u0027)],"},{"line_number":237,"context_line":"        \u0027tags\u0027: [(\u00271.17\u0027, \u00271.0\u0027), (\u00271.21\u0027, \u00271.1\u0027)],"},{"line_number":238,"context_line":"        \u0027flavor\u0027: [(\u00271.18\u0027, \u00271.1\u0027)],"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_e5724e49","line":235,"in_reply_to":"1a4dcd0f_7aaef0e8","updated":"2015-08-09 15:46:51.000000000","message":"Done","commit_id":"8a22768127146fa72e16b96b59c2fcd94c2023dd"}],"nova/objects/pci_device.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"687f091c7ef1557ef907874a5931999063afc017","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        \u0027address\u0027: fields.StringField(),"},{"line_number":99,"context_line":"        \u0027vendor_id\u0027: fields.StringField(),"},{"line_number":100,"context_line":"        \u0027product_id\u0027: fields.StringField(),"},{"line_number":101,"context_line":"        \u0027dev_type\u0027: fields.PciDeviceTypeField(),"},{"line_number":102,"context_line":"        \u0027status\u0027: fields.PciDeviceStatusField(),"},{"line_number":103,"context_line":"        \u0027dev_id\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":104,"context_line":"        \u0027label\u0027: fields.StringField(nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_e6d6abc2","line":101,"updated":"2015-08-10 17:01:32.000000000","message":"Same here. Assuming you\u0027re not actually changing the thing that will be over the wire at all, then you don\u0027t need a version bump. The test thinks you do, but it doesn\u0027t know what we know ... which is that nothing has changed.","commit_id":"31d187b287b3e93eb6f60a2d22ff4097f9c67f91"}],"nova/pci/manager.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"7c851f7bbcdcbf73aa652a9f2fc82e7a7dc05ade","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        but possibly the hypervisor has no such guarantee. The best"},{"line_number":103,"context_line":"        we can do is to give a warning if a device is changed"},{"line_number":104,"context_line":"        or removed while assigned."},{"line_number":105,"context_line":"        \"\"\""},{"line_number":106,"context_line":"        exist_addrs \u003d set([dev.address for dev in self.pci_devs])"},{"line_number":107,"context_line":"        new_addrs \u003d set([dev[\u0027address\u0027] for dev in devices])"},{"line_number":108,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_3a8f0877","line":105,"updated":"2015-08-07 21:26:46.000000000","message":"Errant whitespace change","commit_id":"8a22768127146fa72e16b96b59c2fcd94c2023dd"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"54687266e9602616054479c912b1afc5c3773dc7","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        but possibly the hypervisor has no such guarantee. The best"},{"line_number":103,"context_line":"        we can do is to give a warning if a device is changed"},{"line_number":104,"context_line":"        or removed while assigned."},{"line_number":105,"context_line":"        \"\"\""},{"line_number":106,"context_line":"        exist_addrs \u003d set([dev.address for dev in self.pci_devs])"},{"line_number":107,"context_line":"        new_addrs \u003d set([dev[\u0027address\u0027] for dev in devices])"},{"line_number":108,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_c575d232","line":105,"in_reply_to":"1a4dcd0f_3a8f0877","updated":"2015-08-09 15:46:51.000000000","message":"Done","commit_id":"8a22768127146fa72e16b96b59c2fcd94c2023dd"}],"nova/tests/unit/objects/test_objects.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"edb67ff0df51b5b95bc3509a275eb88e5ddfca90","unresolved":false,"context_lines":[{"line_number":1191,"context_line":"    \u0027Instance\u0027: {\u0027InstanceFault\u0027: \u00271.2\u0027,"},{"line_number":1192,"context_line":"                 \u0027InstanceInfoCache\u0027: \u00271.5\u0027,"},{"line_number":1193,"context_line":"                 \u0027InstanceNUMATopology\u0027: \u00271.1\u0027,"},{"line_number":1194,"context_line":"                 \u0027PciDeviceList\u0027: \u00271.4\u0027,"},{"line_number":1195,"context_line":"                 \u0027TagList\u0027: \u00271.1\u0027,"},{"line_number":1196,"context_line":"                 \u0027SecurityGroupList\u0027: \u00271.0\u0027,"},{"line_number":1197,"context_line":"                 \u0027Flavor\u0027: \u00271.1\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_96fc0773","line":1194,"updated":"2015-08-07 16:06:54.000000000","message":"Modifying a element in \u0027Instance\u0027 means \u0027Instance\u0027 (and therefore \u0027InstanceList\u0027) should also have their versions bumped, right?","commit_id":"264782a9d5fd7c9cc5bdebe29e90971c5542bb94"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"f774d1d122c68f5d98d1905e488b19a07c34192a","unresolved":false,"context_lines":[{"line_number":1191,"context_line":"    \u0027Instance\u0027: {\u0027InstanceFault\u0027: \u00271.2\u0027,"},{"line_number":1192,"context_line":"                 \u0027InstanceInfoCache\u0027: \u00271.5\u0027,"},{"line_number":1193,"context_line":"                 \u0027InstanceNUMATopology\u0027: \u00271.1\u0027,"},{"line_number":1194,"context_line":"                 \u0027PciDeviceList\u0027: \u00271.4\u0027,"},{"line_number":1195,"context_line":"                 \u0027TagList\u0027: \u00271.1\u0027,"},{"line_number":1196,"context_line":"                 \u0027SecurityGroupList\u0027: \u00271.0\u0027,"},{"line_number":1197,"context_line":"                 \u0027Flavor\u0027: \u00271.1\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_16055712","line":1194,"in_reply_to":"1a4dcd0f_96fc0773","updated":"2015-08-07 16:12:48.000000000","message":"Yeah, I\u0027m fixing this locally. Was stuck due to a gate bug but should have this pushed shortly.","commit_id":"264782a9d5fd7c9cc5bdebe29e90971c5542bb94"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"c4aa3b91d93b8b81f598e462d4ac06a0b9e859ef","unresolved":false,"context_lines":[{"line_number":4730,"context_line":"                if len(fun_cap.device_addrs) !\u003d 0:"},{"line_number":4731,"context_line":"                    if fun_cap.type \u003d\u003d \u0027virt_functions\u0027:"},{"line_number":4732,"context_line":"                        return {"},{"line_number":4733,"context_line":"                            \u0027dev_type\u0027: fields.PciDeviceType.SRIOV_PF,"},{"line_number":4734,"context_line":"                        }"},{"line_number":4735,"context_line":"                    if fun_cap.type \u003d\u003d \u0027phys_function\u0027:"},{"line_number":4736,"context_line":"                        phys_address \u003d \"%04x:%02x:%02x.%01x\" % ("}],"source_content_type":"text/x-python","patch_set":5,"id":"1a4dcd0f_180f4b2f","line":4733,"updated":"2015-08-11 11:07:59.000000000","message":"It\u0027s a bit awkward to use this here when there is really no objects in this part of the code. maybe a slightly less awkward place to put this would be PciDevice.update_device which contains the de-facto definition of the dev_dict format we create here. alternatively - this code might want to be returning objects anyway.\n\nJust thinking out loud - you don\u0027t really have to do any of that for this patch","commit_id":"9b7e78976886ba571e914eb3ae20503ca410b895"}]}