)]}'
{"nova/pci/whitelist.py":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"559a7477b1a66413818901ebeee13a7545295731","unresolved":false,"context_lines":[{"line_number":29,"context_line":"                            \u0027[{\"vendor_id\": \"8086\", \"product_id\": \"0443\"}]\u0027"},{"line_number":30,"context_line":"                            )"},{"line_number":31,"context_line":"            ]"},{"line_number":32,"context_line":"CONF \u003d cfg.CONF"},{"line_number":33,"context_line":"CONF.register_opts(pci_opts)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a4dcd0f_2f3683e7","side":"PARENT","line":32,"updated":"2015-08-11 10:02:28.000000000","message":"All CONF related things should be moved to manager.py now. We should keep this module free of deps as possible.","commit_id":"568466e5297de6498595e9fac8b2924c42a82ae8"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"95ef4b81d0c108133fd9c70c900e8d4803ab54fd","unresolved":false,"context_lines":[{"line_number":106,"context_line":"                return spec"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"def get_pci_device_devspec(pci_dev):"},{"line_number":110,"context_line":"    dev_filter \u003d Whitelist(CONF.pci_passthrough_whitelist)"},{"line_number":111,"context_line":"    return dev_filter.get_devspec(pci_dev)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a4dcd0f_be587f57","line":109,"updated":"2015-08-11 12:13:34.000000000","message":"Yeah I guess what sahid means is make this function take the whitelist instance as well and then we don\u0027t need the conf here at all. \n\nI agree in principle but not sure if it warrants a -1 since this is used also in places that would then need to have access to the pci_manager instance (like for example neutron api wtf?!)","commit_id":"114ff193cd1d0df415512ed75189794fe08f6ecb"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"ecee5244d67672dc808b655c6b9813d86013cb33","unresolved":false,"context_lines":[{"line_number":106,"context_line":"                return spec"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"def get_pci_device_devspec(pci_dev):"},{"line_number":110,"context_line":"    dev_filter \u003d Whitelist(CONF.pci_passthrough_whitelist)"},{"line_number":111,"context_line":"    return dev_filter.get_devspec(pci_dev)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a4dcd0f_063609e7","line":109,"in_reply_to":"1a4dcd0f_be587f57","updated":"2015-08-11 13:03:08.000000000","message":"Oh yes... actually i wanted to remove that all method.","commit_id":"114ff193cd1d0df415512ed75189794fe08f6ecb"}]}