)]}'
{"id":"openstack%2Fnova~21029","triplet_id":"openstack%2Fnova~master~I96efbc18cb7eb0ee2d0e6526b3c4f3502a68e1dd","project":"openstack/nova","branch":"master","topic":"bug/1112673","hashtags":[],"change_id":"I96efbc18cb7eb0ee2d0e6526b3c4f3502a68e1dd","subject":"Move allowvssprovider\u003dfalse to vm-data field","status":"MERGED","created":"2013-02-01 23:14:41.000000000","updated":"2013-02-13 06:32:32.000000000","submitted":"2013-02-13 06:32:29.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"1dca06e5d8a948d5f618f1caa98f354623d8ea0b","_number":21029,"virtual_id_number":21029,"owner":{"_account_id":6799,"name":"Nicholas Kuechler","email":"nkuechler@gmail.com","username":"nicholaskuechler"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"recommended":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1711,"name":"Yun Mao","email":"yunmao@gmail.com","username":"yunmao"},{"value":0,"_account_id":6799,"name":"Nicholas Kuechler","email":"nkuechler@gmail.com","username":"nicholaskuechler"},{"value":1,"date":"2013-02-12 23:29:55.000000000","_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},{"value":2,"date":"2013-02-13 06:32:29.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1711,"name":"Yun Mao","email":"yunmao@gmail.com","username":"yunmao"},"all":[{"value":2,"date":"2013-02-12 23:49:34.000000000","_account_id":1711,"name":"Yun Mao","email":"yunmao@gmail.com","username":"yunmao"},{"value":0,"_account_id":6799,"name":"Nicholas Kuechler","email":"nkuechler@gmail.com","username":"nicholaskuechler"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":2,"date":"2013-02-12 23:31:53.000000000","_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1711,"name":"Yun Mao","email":"yunmao@gmail.com","username":"yunmao"},"all":[{"value":1,"date":"2013-02-12 23:49:34.000000000","_account_id":1711,"name":"Yun Mao","email":"yunmao@gmail.com","username":"yunmao"},{"value":0,"_account_id":6799,"name":"Nicholas Kuechler","email":"nkuechler@gmail.com","username":"nicholaskuechler"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"date":"2013-02-12 23:31:53.000000000","_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":1711,"name":"Yun Mao","email":"yunmao@gmail.com","username":"yunmao"},{"value":0,"_account_id":6799,"name":"Nicholas Kuechler","email":"nkuechler@gmail.com","username":"nicholaskuechler"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":1711,"name":"Yun Mao","email":"yunmao@gmail.com","username":"yunmao"},{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},{"_account_id":6799,"name":"Nicholas Kuechler","email":"nkuechler@gmail.com","username":"nicholaskuechler"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-02-06 20:33:34.000000000","updated_by":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"reviewer":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"state":"REVIEWER"},{"updated":"2013-02-12 23:29:55.000000000","updated_by":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"reviewer":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2013-02-12 23:31:53.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2013-02-12 23:49:34.000000000","updated_by":{"_account_id":1711,"name":"Yun Mao","email":"yunmao@gmail.com","username":"yunmao"},"reviewer":{"_account_id":1711,"name":"Yun Mao","email":"yunmao@gmail.com","username":"yunmao"},"state":"REVIEWER"},{"updated":"2013-02-13 06:32:29.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"bb870df885c8bf704abc2607279eddce3fdf8f66","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-02 00:36:18.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/21029/1/check/gate-nova-docs/13845 : SUCCESS\n- http://logs.openstack.org/21029/1/check/gate-nova-pep8/19151 : SUCCESS\n- http://logs.openstack.org/21029/1/check/gate-nova-python26/15296 : SUCCESS\n- http://logs.openstack.org/21029/1/check/gate-nova-python27/15353 : SUCCESS\n- http://logs.openstack.org/21029/1/check/gate-tempest-devstack-vm-full/446 : SUCCESS\n- http://logs.openstack.org/21029/1/check/gate-tempest-devstack-vm-postgres-full/174 : FAILURE (non-voting)\n- http://logs.openstack.org/21029/1/check/gate-tempest-devstack-vm-quantum/4264 : SUCCESS\n- http://logs.openstack.org/21029/1/check/gate-nova-pylint/7417 : SUCCESS (non-voting)\n","accounts_in_message":[],"_revision_number":1},{"id":"3fef7d43bb4a7bfaaecb90f5207f70aa25b4be75","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2013-02-02 21:54:37.000000000","message":"Patch Set 1: Works for me\n\nSmokeStack Results (patch set 1):\n\tLibvirt (Fedora 17) Success: http://smokestack.openstack.org/?go\u003d/jobs/68945\n\tXenServer 5.6 (F17 domU) Success: http://smokestack.openstack.org/?go\u003d/jobs/68946\n","accounts_in_message":[],"_revision_number":1},{"id":"21be55c2514c200876d18a3214155fad68298ae4","author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"date":"2013-02-04 15:32:08.000000000","message":"Patch Set 1:\n\nThe change itself looks fine to me, but I would prefer a more concise commit message.  The \"Relevant coded:\" line and below make more sense in the bug report than the commit message.  And since the bug report is linked that information will not be lost.","accounts_in_message":[],"_revision_number":1},{"id":"c574deb5b7c3eaad1327ab03fc4ed21821f9ee8f","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2013-02-06 20:10:54.000000000","message":"Patch Set 1: Looks good to me (core reviewer)\n\nAndrew: I disagree a little.  One of our goals with commit messages is that someone will be able to understand the full purpose of a given commit without having to look at external resources, such as a bug report.  That said, this commit message is a little too complete, but I\u0027m not bothered by that.","accounts_in_message":[],"_revision_number":1},{"id":"94014fc0ddf53a2de4c80536b6dd810064f06bfb","author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"date":"2013-02-06 20:33:34.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\nKevin,\n\nFair points.  I think this message is explanatory without the links, but too much information is not a bad thing.","accounts_in_message":[],"_revision_number":1},{"id":"0dd334ad570096c065017976215bdb3e10e47ef0","author":{"_account_id":1711,"name":"Yun Mao","email":"yunmao@gmail.com","username":"yunmao"},"date":"2013-02-11 21:48:37.000000000","message":"Patch Set 1:\n\nI\u0027m no expert on xenapi but from the example it seems that you want \"false\" instead of str(False), which is \"False\". They may well be equivalent but at least I don\u0027t see the need to do the extra str conversion..","accounts_in_message":[],"_revision_number":1},{"id":"701f683f0af64bfdf8ba86f8217fecb741032fd5","author":{"_account_id":6799,"name":"Nicholas Kuechler","email":"nkuechler@gmail.com","username":"nicholaskuechler"},"date":"2013-02-12 21:03:49.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"cc38b63b2ff237d64ea9bc80f499c1f6ac6fa4d3","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2013-02-12 21:06:07.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"94e8e38e1ed7cf4e88dec076f504fff77bcb466b","author":{"_account_id":1711,"name":"Yun Mao","email":"yunmao@gmail.com","username":"yunmao"},"date":"2013-02-12 21:28:05.000000000","message":"Patch Set 2: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":2},{"id":"75380716eaad7d2eede0b7fcc0843c26a2401651","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-12 21:28:07.000000000","message":"Patch Set 2:\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"8d080caded9f51c932e01a4ac9a17bea2ca2fc08","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-12 22:08:33.000000000","message":"Patch Set 2: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see http://wiki.openstack.org/GerritJenkinsGithub#Test_Failures\n\n- http://logs.openstack.org/21029/2/check/gate-nova-pep8/20060 : SUCCESS\n- http://logs.openstack.org/21029/2/check/gate-nova-docs/14753 : SUCCESS\n- http://logs.openstack.org/21029/2/check/gate-nova-python26/16200 : FAILURE\n- http://logs.openstack.org/21029/2/check/gate-nova-python27/16259 : FAILURE\n- http://logs.openstack.org/21029/2/check/gate-tempest-devstack-vm-full/2353 : SUCCESS\n- http://logs.openstack.org/21029/2/check/gate-tempest-devstack-vm-postgres-full/2079 : SUCCESS\n- http://logs.openstack.org/21029/2/check/gate-tempest-devstack-vm-quantum/6529 : SUCCESS\n- http://logs.openstack.org/21029/2/check/gate-nova-pylint/8080 : FAILURE (non-voting)\n","accounts_in_message":[],"_revision_number":2},{"id":"a83705847b43702b5047739cfb24f09e683a340c","author":{"_account_id":6799,"name":"Nicholas Kuechler","email":"nkuechler@gmail.com","username":"nicholaskuechler"},"date":"2013-02-12 23:07:27.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"c68e6c47ba42bd4007f9c626230bf9aab8b1da42","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2013-02-12 23:29:55.000000000","message":"Patch Set 3: Works for me\n\nSmokeStack Results (patch set 3):\n\tLibvirt (Fedora 17) Success: http://smokestack.openstack.org/?go\u003d/jobs/71533\n\tXenServer 5.6 (F17 domU) Success: http://smokestack.openstack.org/?go\u003d/jobs/71534\n","accounts_in_message":[],"_revision_number":3},{"id":"a4fe3db9b6bf40ac7673cd4d068e0b452697680c","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2013-02-12 23:31:53.000000000","message":"Patch Set 3: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":3},{"id":"8e32a459ab7d2969ace27d0f494285df3b0088c8","author":{"_account_id":1711,"name":"Yun Mao","email":"yunmao@gmail.com","username":"yunmao"},"date":"2013-02-12 23:49:34.000000000","message":"Patch Set 3: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":3},{"id":"03ed9ba64b5e930957ecce0c699f24dfe480ffe9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-12 23:56:03.000000000","message":"Patch Set 3:\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"e89c3f9afdd25ce39fcf68063fc3bf5a9f586948","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-13 00:43:06.000000000","message":"Patch Set 3: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/21029/3/check/gate-nova-pep8/20074 : SUCCESS\n- http://logs.openstack.org/21029/3/check/gate-nova-docs/14761 : SUCCESS\n- http://logs.openstack.org/21029/3/check/gate-nova-python26/16208 : SUCCESS\n- http://logs.openstack.org/21029/3/check/gate-nova-python27/16267 : SUCCESS\n- http://logs.openstack.org/21029/3/check/gate-tempest-devstack-vm-full/2380 : SUCCESS\n- http://logs.openstack.org/21029/3/check/gate-tempest-devstack-vm-postgres-full/2106 : SUCCESS\n- http://logs.openstack.org/21029/3/check/gate-tempest-devstack-vm-quantum/6562 : SUCCESS\n- http://logs.openstack.org/21029/3/check/gate-nova-pylint/8088 : SUCCESS (non-voting)\n","accounts_in_message":[],"_revision_number":3},{"id":"1a3a40e7d9c7b74c421e9491f2368ca3fc4f64a9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-13 06:32:29.000000000","message":"Patch Set 3: Verified\n\nBuild succeeded.\n\n- http://logs.openstack.org/21029/3/gate/gate-nova-docs/14791 : SUCCESS\n- http://logs.openstack.org/21029/3/gate/gate-nova-pep8/20114 : SUCCESS\n- http://logs.openstack.org/21029/3/gate/gate-nova-python26/16238 : SUCCESS\n- http://logs.openstack.org/21029/3/gate/gate-nova-python27/16297 : SUCCESS\n- http://logs.openstack.org/21029/3/gate/gate-tempest-devstack-vm-full/2448 : SUCCESS\n- http://logs.openstack.org/21029/3/gate/gate-tempest-devstack-vm-postgres-full/2174 : SUCCESS\n- http://logs.openstack.org/21029/3/gate/gate-tempest-devstack-vm-quantum/6633 : SUCCESS\n","accounts_in_message":[],"_revision_number":3},{"id":"a262af4d94f6e58c60dc430ed67df513c1b110c1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-13 06:32:32.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"8ddbbf095136333cb9f2f4c7d60e37f70c759776","revisions":{"a9651f16c461d8dc1a2257d73c875d0fc48d3c56":{"kind":"REWORK","_number":1,"created":"2013-02-01 23:14:41.000000000","uploader":{"_account_id":6799,"name":"Nicholas Kuechler","email":"nkuechler@gmail.com","username":"nicholaskuechler"},"ref":"refs/changes/29/21029/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/29/21029/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/29/21029/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/29/21029/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/29/21029/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/29/21029/1"}}},"commit":{"parents":[{"commit":"c421d775ee3052d1af4c08b8ff81f6877ca8b1a8","subject":"Merge \"Split floating ip functionality into new file.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/c421d775ee3052d1af4c08b8ff81f6877ca8b1a8"}]}],"author":{"name":"Nicholas Kuechler","email":"nkuechler@gmail.com","date":"2013-02-01 17:04:01.000000000","tz":-360},"committer":{"name":"Nicholas Kuechler","email":"nkuechler@gmail.com","date":"2013-02-01 17:04:01.000000000","tz":-360},"subject":"Move allowvssprovider\u003dfalse to vm-data field","message":"Move allowvssprovider\u003dfalse to vm-data field\n\nCurrently we\u0027re setting allowvssprovider\u003dfalse in the other-config\nfield. However, this setting is not honored in the other-config field,\nallowing vss-based snapshots to be created.\n\nThe allowvssprovider\u003dfalse should be moved to the vm-data field in\nxenstore as that field is used to decide whether vss snapshotting is allowed or not.\n\nRelevant code:\n\nhttps://github.com/openstack/nova/blob/master/nova/virt/xenapi/vm_utils.py#L233\n\nManually set allowvssprovider\u003dfalse in the vm-data field:\n\nxe vm-param-set uuid\u003d\u003cVM-UUID\u003e xenstore-data:vm-data/allowvssprovider\u003dfalse\n\nReferences:\n\nhttps://github.com/mcclurmc/xcp-storage-managers/blob/master/drivers/vss_control#L38\nhttps://github.com/mcclurmc/xcp-storage-managers/blob/master/snapwatchd/snapwatchd#L298\n\nChange-Id: I96efbc18cb7eb0ee2d0e6526b3c4f3502a68e1dd\nFixes: bug #1112673\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/a9651f16c461d8dc1a2257d73c875d0fc48d3c56"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/a9651f16c461d8dc1a2257d73c875d0fc48d3c56"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"c421d775ee3052d1af4c08b8ff81f6877ca8b1a8","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"fc5e8f4f4e8c15c26ef5fb367276bfcd4e069bf8":{"kind":"REWORK","_number":2,"created":"2013-02-12 21:03:49.000000000","uploader":{"_account_id":6799,"name":"Nicholas Kuechler","email":"nkuechler@gmail.com","username":"nicholaskuechler"},"ref":"refs/changes/29/21029/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/29/21029/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/29/21029/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/29/21029/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/29/21029/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/29/21029/2"}}},"commit":{"parents":[{"commit":"c421d775ee3052d1af4c08b8ff81f6877ca8b1a8","subject":"Merge \"Split floating ip functionality into new file.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/c421d775ee3052d1af4c08b8ff81f6877ca8b1a8"}]}],"author":{"name":"Nicholas Kuechler","email":"nkuechler@gmail.com","date":"2013-02-01 17:04:01.000000000","tz":-360},"committer":{"name":"Nicholas Kuechler","email":"nkuechler@gmail.com","date":"2013-02-12 21:01:48.000000000","tz":-360},"subject":"Move allowvssprovider\u003dfalse to vm-data field","message":"Move allowvssprovider\u003dfalse to vm-data field\n\nCurrently we\u0027re setting allowvssprovider\u003dfalse in the other-config\nfield. However, this setting is not honored in the other-config field,\nallowing vss-based snapshots to be created.\n\nThe allowvssprovider\u003dfalse should be moved to the vm-data field in\nxenstore as that field is used to decide whether vss snapshotting is allowed or not.\n\nAmended to change: \u0027str(False)\u0027 to \u0027false\u0027.\n\nRelevant code:\n\nhttps://github.com/openstack/nova/blob/master/nova/virt/xenapi/vm_utils.py#L233\n\nManually set allowvssprovider\u003dfalse in the vm-data field:\n\nxe vm-param-set uuid\u003d\u003cVM-UUID\u003e xenstore-data:vm-data/allowvssprovider\u003dfalse\n\nReferences:\n\nhttps://github.com/mcclurmc/xcp-storage-managers/blob/master/drivers/vss_control#L38\nhttps://github.com/mcclurmc/xcp-storage-managers/blob/master/snapwatchd/snapwatchd#L298\n\nChange-Id: I96efbc18cb7eb0ee2d0e6526b3c4f3502a68e1dd\nFixes: bug #1112673\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/fc5e8f4f4e8c15c26ef5fb367276bfcd4e069bf8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/fc5e8f4f4e8c15c26ef5fb367276bfcd4e069bf8"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"c421d775ee3052d1af4c08b8ff81f6877ca8b1a8","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"8ddbbf095136333cb9f2f4c7d60e37f70c759776":{"kind":"REWORK","_number":3,"created":"2013-02-12 23:07:27.000000000","uploader":{"_account_id":6799,"name":"Nicholas Kuechler","email":"nkuechler@gmail.com","username":"nicholaskuechler"},"ref":"refs/changes/29/21029/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/29/21029/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/29/21029/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/29/21029/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/29/21029/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/29/21029/3"}}},"commit":{"parents":[{"commit":"c421d775ee3052d1af4c08b8ff81f6877ca8b1a8","subject":"Merge \"Split floating ip functionality into new file.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/c421d775ee3052d1af4c08b8ff81f6877ca8b1a8"}]}],"author":{"name":"Nicholas Kuechler","email":"nkuechler@gmail.com","date":"2013-02-01 17:04:01.000000000","tz":-360},"committer":{"name":"Nicholas Kuechler","email":"nkuechler@gmail.com","date":"2013-02-12 23:06:58.000000000","tz":-360},"subject":"Move allowvssprovider\u003dfalse to vm-data field","message":"Move allowvssprovider\u003dfalse to vm-data field\n\nCurrently we\u0027re setting allowvssprovider\u003dfalse in the other-config\nfield. However, this setting is not honored in the other-config field,\nallowing vss-based snapshots to be created.\n\nThe allowvssprovider\u003dfalse should be moved to the vm-data field in\nxenstore as that field is used to decide whether vss snapshotting is allowed or not.\n\nAmended to change: \u0027str(False)\u0027 to \u0027false\u0027.\n\nRelevant code:\n\nhttps://github.com/openstack/nova/blob/master/nova/virt/xenapi/vm_utils.py#L233\n\nManually set allowvssprovider\u003dfalse in the vm-data field:\n\nxe vm-param-set uuid\u003d\u003cVM-UUID\u003e xenstore-data:vm-data/allowvssprovider\u003dfalse\n\nReferences:\n\nhttps://github.com/mcclurmc/xcp-storage-managers/blob/master/drivers/vss_control#L38\nhttps://github.com/mcclurmc/xcp-storage-managers/blob/master/snapwatchd/snapwatchd#L298\n\nChange-Id: I96efbc18cb7eb0ee2d0e6526b3c4f3502a68e1dd\nFixes: bug #1112673\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/8ddbbf095136333cb9f2f4c7d60e37f70c759776"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/8ddbbf095136333cb9f2f4c7d60e37f70c759776"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"c421d775ee3052d1af4c08b8ff81f6877ca8b1a8","is_merged_in_target_branch":true}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}