)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e0a52530cf880ba424ddc1416d5beec12ee8a775","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Skip detach when volume is no longer in-use"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Detaching a volume which is not attached in cinder will return"},{"line_number":10,"context_line":"a 500 error which prevents the nova-compute terminating the"},{"line_number":11,"context_line":"instance."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This commit simply checks the status of the volume before"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a4dcd0f_fd8a7563","line":10,"updated":"2015-08-11 17:32:33.000000000","message":"Is it a 500 or a 400?\n\nhttp://git.openstack.org/cgit/openstack/cinder/tree/cinder/volume/manager.py#n885","commit_id":"0e7925f09e64393a35f8c9029e191194ecca037b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"950de562ddce8980432b2a08afae3a47593aa77a","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This commit simply checks the status of the volume before"},{"line_number":14,"context_line":"detaching it."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I6f529e5387f31a3cca549e6247a0195ac0e7bf6a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a4dcd0f_3d677dea","line":15,"updated":"2015-08-11 17:31:21.000000000","message":"I believe this closes bug 1476806 so you should mark that here.  There was already a change up for that bug:\n\nhttps://review.openstack.org/#/c/204231/\n\nBut that\u0027s dealing with it in a more complicated way.  If this fixes the same issue, this is cleaner and we should go with this change.","commit_id":"0e7925f09e64393a35f8c9029e191194ecca037b"}],"nova/compute/manager.py":[{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"cf40177ccbbf4f7a7250ef66e0996640e06b656d","unresolved":false,"context_lines":[{"line_number":2243,"context_line":"                                                     connector)"},{"line_number":2244,"context_line":"                vol \u003d self.volume_api.get(context, bdm.volume_id)"},{"line_number":2245,"context_line":"                if vol[\u0027status\u0027] in [\u0027in-use\u0027]:"},{"line_number":2246,"context_line":"                    self.volume_api.detach(context, bdm.volume_id)"},{"line_number":2247,"context_line":"            except exception.DiskNotFound as exc:"},{"line_number":2248,"context_line":"                LOG.debug(\u0027Ignoring DiskNotFound: %s\u0027, exc,"},{"line_number":2249,"context_line":"                          instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_5d55a9bf","line":2246,"updated":"2015-08-11 17:33:34.000000000","message":"Can\u0027t we just handle the exception here. This is racy code by definition.","commit_id":"0e7925f09e64393a35f8c9029e191194ecca037b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"25f80da41fdfeff7fb2ecc41c3e026ba6a93c906","unresolved":false,"context_lines":[{"line_number":2243,"context_line":"                                                     connector)"},{"line_number":2244,"context_line":"                vol \u003d self.volume_api.get(context, bdm.volume_id)"},{"line_number":2245,"context_line":"                if vol[\u0027status\u0027] in [\u0027in-use\u0027]:"},{"line_number":2246,"context_line":"                    self.volume_api.detach(context, bdm.volume_id)"},{"line_number":2247,"context_line":"            except exception.DiskNotFound as exc:"},{"line_number":2248,"context_line":"                LOG.debug(\u0027Ignoring DiskNotFound: %s\u0027, exc,"},{"line_number":2249,"context_line":"                          instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_9d61f13b","line":2246,"in_reply_to":"1a4dcd0f_5d55a9bf","updated":"2015-08-11 17:41:47.000000000","message":"Heh, that\u0027s what https://review.openstack.org/#/c/204231/ is attempting to do.","commit_id":"0e7925f09e64393a35f8c9029e191194ecca037b"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"005d245763091cb0ccbd78fa891a7102e7c13804","unresolved":false,"context_lines":[{"line_number":2243,"context_line":"                                                     connector)"},{"line_number":2244,"context_line":"                vol \u003d self.volume_api.get(context, bdm.volume_id)"},{"line_number":2245,"context_line":"                if vol[\u0027status\u0027] in [\u0027in-use\u0027]:"},{"line_number":2246,"context_line":"                    self.volume_api.detach(context, bdm.volume_id)"},{"line_number":2247,"context_line":"            except exception.DiskNotFound as exc:"},{"line_number":2248,"context_line":"                LOG.debug(\u0027Ignoring DiskNotFound: %s\u0027, exc,"},{"line_number":2249,"context_line":"                          instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_636b28ba","line":2246,"in_reply_to":"1a4dcd0f_9d61f13b","updated":"2015-08-11 18:10:31.000000000","message":"yeah saw that - that;s better - will comment on there too","commit_id":"0e7925f09e64393a35f8c9029e191194ecca037b"}]}