)]}'
{"nova/pci/manager.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"c6bdab9cb7d14a34534090ff8cbd94e80ccf2f53","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                with dev.obj_alternate_context(context):"},{"line_number":88,"context_line":"                    dev.save()"},{"line_number":89,"context_line":"                    if dev.status \u003d\u003d fields.PciDeviceStatus.DELETED:"},{"line_number":90,"context_line":"                        del self.pci_devs[dev]"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    @property"},{"line_number":93,"context_line":"    def pci_stats(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_46d0bf53","line":90,"updated":"2015-08-10 16:51:06.000000000","message":"All you need to do here is:\n\n del self.pci_devs.objects[dev]\n\nAnd then you don\u0027t have to add the __delitem__ handler and change the external behavior of the list objects. Would that be okay?","commit_id":"be00daf3508d67ecb93c85d2aeb96c4a6ea8fbd0"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"a19265c9b77b0515373699f57de7ab6c42e968ae","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                with dev.obj_alternate_context(context):"},{"line_number":88,"context_line":"                    dev.save()"},{"line_number":89,"context_line":"                    if dev.status \u003d\u003d fields.PciDeviceStatus.DELETED:"},{"line_number":90,"context_line":"                        del self.pci_devs[dev]"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    @property"},{"line_number":93,"context_line":"    def pci_stats(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_e646ab20","line":90,"in_reply_to":"1a4dcd0f_46d0bf53","updated":"2015-08-10 16:52:27.000000000","message":"Yeah, that\u0027ll work I guess.","commit_id":"be00daf3508d67ecb93c85d2aeb96c4a6ea8fbd0"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"55758ed226f9847e327ec8370f5ef680263c62c9","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                with dev.obj_alternate_context(context):"},{"line_number":88,"context_line":"                    dev.save()"},{"line_number":89,"context_line":"                    if dev.status \u003d\u003d fields.PciDeviceStatus.DELETED:"},{"line_number":90,"context_line":"                        del self.pci_devs[dev]"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    @property"},{"line_number":93,"context_line":"    def pci_stats(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_01d141cd","line":90,"in_reply_to":"1a4dcd0f_46d0bf53","updated":"2015-08-10 17:24:16.000000000","message":"del self.pci_devs.objects[dev]\n\n TypeError: list indices must be integers, not PciDevice\n\nBut, I can do this instead:\n\n    idx \u003d self.pci_devs.index(dev)\n    del self.pci_devs.objects[idx]","commit_id":"be00daf3508d67ecb93c85d2aeb96c4a6ea8fbd0"}]}