)]}'
{"nova/objects/image_meta.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"489d3b157aab4b7c1a76c2963acb273c8419f635","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    # data in the \u0027metadata\u0027 subfield is non-trivial as"},{"line_number":46,"context_line":"    # there\u0027s no clear spec."},{"line_number":47,"context_line":"    #"},{"line_number":48,"context_line":"    # TODO(ft): In version 2.0, these fields should be nullable:"},{"line_number":49,"context_line":"    # name, checksum, owner, size, virtual_size, container_format, disk_format"},{"line_number":50,"context_line":"    #"},{"line_number":51,"context_line":"    fields \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_69c8fc22","side":"PARENT","line":48,"range":{"start_line":48,"start_character":16,"end_line":48,"end_character":63},"updated":"2015-08-19 13:34:48.000000000","message":"As I said in the previous patch, I don\u0027t think you should change these to be nullable until we drop support for the older version, which is why I asked you to put this \"version 2.0\" statement here.\n\nWhy are you deciding to skip ahead and do it in v1.6?","commit_id":"cdfd489779506d79170bd471f68991a1c0a6646c"},{"author":{"_account_id":10224,"name":"Feodor Tersin","email":"ftersin@hotmail.com","username":"ftersin"},"change_message_id":"6de684a0149490dd26e53236723f30c03f906148","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    # data in the \u0027metadata\u0027 subfield is non-trivial as"},{"line_number":46,"context_line":"    # there\u0027s no clear spec."},{"line_number":47,"context_line":"    #"},{"line_number":48,"context_line":"    # TODO(ft): In version 2.0, these fields should be nullable:"},{"line_number":49,"context_line":"    # name, checksum, owner, size, virtual_size, container_format, disk_format"},{"line_number":50,"context_line":"    #"},{"line_number":51,"context_line":"    fields \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_50565007","side":"PARENT","line":48,"in_reply_to":"fa1b9901_69c8fc22","updated":"2015-08-23 08:49:21.000000000","message":"I thought that there was no way to do this fields nullable with no breaking of compatibility. And it was the reason why we put the comment here and suspended nullability until v2, in which legacy compatibility will be dropped.\n\nBut since there is a standard way to give these fields nullability with no breaking of compatibility, why not to do that now?","commit_id":"cdfd489779506d79170bd471f68991a1c0a6646c"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"96900ba455fa373a7ef19e4e05a6223a281f2149","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        for fld in NULLABLE_INTEGER_FIELDS:"},{"line_number":112,"context_line":"            if fld in image_meta and image_meta[fld] is None:"},{"line_number":113,"context_line":"                image_meta[fld] \u003d 0"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"        return cls(**image_meta)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_288f9724","side":"PARENT","line":114,"updated":"2015-08-24 12:42:20.000000000","message":"IIUC, what Dan Smith is saying is that we could change from_dict to do\n\n\n   for fld in NULLABLE_FIELDS:\n      if fld in image_meta and image_meta[fld] is None:\n          del image_meta[fld]\n\nSo we avoid ever setting the attribute if it is None and thus do not need to mark them nullable.","commit_id":"cdfd489779506d79170bd471f68991a1c0a6646c"}]}