)]}'
{"nova/api/metadata/password.py":[{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"7546d3b830ede480ecaa02a5337b50bf72f1087d","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    return result or None"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"def set_password(context, password):"},{"line_number":37,"context_line":"    \"\"\"Stores password as system_metadata items."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    Password is stored with the keys \u0027password_0\u0027 -\u003e \u0027password_3\u0027."}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FLgQ%3D","line":36,"updated":"2013-02-04 18:22:58.000000000","message":"if you are changing the semantics of this code, I would rename the method to something like \"convert_password\"","commit_id":"935cbfe5b37a20efe39078dbe8b40cbd4b1188f2"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3f90ed1e69c2b4a357536012ec4f8627fc12bb42","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    return result or None"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"def set_password(context, password):"},{"line_number":37,"context_line":"    \"\"\"Stores password as system_metadata items."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    Password is stored with the keys \u0027password_0\u0027 -\u003e \u0027password_3\u0027."}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FLdE%3D","line":36,"in_reply_to":"AAAAM3%2F%2FLgQ%3D","updated":"2013-02-04 18:32:31.000000000","message":"Sure, good call.","commit_id":"935cbfe5b37a20efe39078dbe8b40cbd4b1188f2"},{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"7546d3b830ede480ecaa02a5337b50bf72f1087d","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        if (req.content_length \u003e MAX_SIZE or len(req.body) \u003e MAX_SIZE):"},{"line_number":61,"context_line":"            msg \u003d _(\"Request is too large.\")"},{"line_number":62,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":63,"context_line":"        meta \u003d set_password(ctxt, req.body)"},{"line_number":64,"context_line":"        db.instance_system_metadata_update(context,"},{"line_number":65,"context_line":"                                           meta_data.uuid,"},{"line_number":66,"context_line":"                                           meta,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FLf4%3D","line":63,"updated":"2013-02-04 18:22:58.000000000","message":"Maybe you are planning on doing this in a later patch, but I don\u0027t see any problem with using the conductor here as well.","commit_id":"935cbfe5b37a20efe39078dbe8b40cbd4b1188f2"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3f90ed1e69c2b4a357536012ec4f8627fc12bb42","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        if (req.content_length \u003e MAX_SIZE or len(req.body) \u003e MAX_SIZE):"},{"line_number":61,"context_line":"            msg \u003d _(\"Request is too large.\")"},{"line_number":62,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":63,"context_line":"        meta \u003d set_password(ctxt, req.body)"},{"line_number":64,"context_line":"        db.instance_system_metadata_update(context,"},{"line_number":65,"context_line":"                                           meta_data.uuid,"},{"line_number":66,"context_line":"                                           meta,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FLc8%3D","line":63,"in_reply_to":"AAAAM3%2F%2FLf4%3D","updated":"2013-02-04 18:32:31.000000000","message":"Is there any reason _to_ do that? It just creates more work for the conductor to do for no reason, which means potentially holding up some compute node that needs a slot...","commit_id":"935cbfe5b37a20efe39078dbe8b40cbd4b1188f2"},{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"ac66fbfe993129beac48841360fba8e83796b50f","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        conductor_api \u003d conductor.API()"},{"line_number":66,"context_line":"        instance \u003d conductor_api.instance_get_by_uuid(ctxt, meta_data.uuid)"},{"line_number":67,"context_line":"        sys_meta \u003d utils.metadata_to_dict(instance[\u0027system_metadata\u0027])"},{"line_number":68,"context_line":"        sys_meta.update(convert_password(ctxt, req.body))"},{"line_number":69,"context_line":"        conductor_api.instance_update(ctxt, meta_data.uuid,"},{"line_number":70,"context_line":"                                      system_metadata\u003dsys_meta)"},{"line_number":71,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAM3%2F%2FJDI%3D","line":68,"updated":"2013-02-05 19:58:09.000000000","message":"something like\n\n  sys_meta \u003d add_password_to_meta(instance[\u0027system_metadata\u0027])\n\nwould be nice since we do this twice, but no big deal","commit_id":"5d8868a4d58122dce6fdc81fa0ed17ae7fc55672"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"06dd42e03a37ccfafcb12afddfc8ec1e6b1a95c6","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        conductor_api \u003d conductor.API()"},{"line_number":66,"context_line":"        instance \u003d conductor_api.instance_get_by_uuid(ctxt, meta_data.uuid)"},{"line_number":67,"context_line":"        sys_meta \u003d utils.metadata_to_dict(instance[\u0027system_metadata\u0027])"},{"line_number":68,"context_line":"        sys_meta.update(convert_password(ctxt, req.body))"},{"line_number":69,"context_line":"        conductor_api.instance_update(ctxt, meta_data.uuid,"},{"line_number":70,"context_line":"                                      system_metadata\u003dsys_meta)"},{"line_number":71,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAM3%2F%2FJBQ%3D","line":68,"in_reply_to":"AAAAM3%2F%2FJDI%3D","updated":"2013-02-05 20:14:27.000000000","message":"Okay, I\u0027ll do that if I have to resubmit for some reason.","commit_id":"5d8868a4d58122dce6fdc81fa0ed17ae7fc55672"}]}