)]}'
{"nova/tests/network/test_manager.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"e3df386663e1b73f522abf6638aceb1f91617b48","unresolved":false,"context_lines":[{"line_number":778,"context_line":""},{"line_number":779,"context_line":"    def test_add_floating_ip_nat_before_bind(self):"},{"line_number":780,"context_line":"        \u0027\u0027\u0027"},{"line_number":781,"context_line":"        Tried to verify order with documented mox record/verify functionality, "},{"line_number":782,"context_line":"        but it doesn\u0027t seem to work since I can\u0027t make it fail.  I\u0027m using stubs"},{"line_number":783,"context_line":"        and a flag for now, but if this mox feature can be made to work, it would "},{"line_number":784,"context_line":"        be a better way to test this."}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FDiE%3D","line":781,"updated":"2013-02-08 19:24:52.000000000","message":"1. Trailing spaces; please eliminate.\n\n2. I prefer there to be no docstrings on tests; test reports often use the docstring instead of the function name to report failures.  I would advise changing this docstring to a block comment.","commit_id":"d9d64ed8209c1cce90226992e2031fbbb10a888b"},{"author":{"_account_id":6728,"name":"Mingyan Bao","email":"bao.mingyan@hp.com","username":"Mingyan.Bao"},"change_message_id":"b0e8812332374ef372fa66c94215148a8c6671c1","unresolved":false,"context_lines":[{"line_number":778,"context_line":""},{"line_number":779,"context_line":"    def test_add_floating_ip_nat_before_bind(self):"},{"line_number":780,"context_line":"        \u0027\u0027\u0027"},{"line_number":781,"context_line":"        Tried to verify order with documented mox record/verify functionality, "},{"line_number":782,"context_line":"        but it doesn\u0027t seem to work since I can\u0027t make it fail.  I\u0027m using stubs"},{"line_number":783,"context_line":"        and a flag for now, but if this mox feature can be made to work, it would "},{"line_number":784,"context_line":"        be a better way to test this."}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FDc0%3D","line":781,"in_reply_to":"AAAAM3%2F%2FDiE%3D","updated":"2013-02-08 20:10:45.000000000","message":"Done","commit_id":"d9d64ed8209c1cce90226992e2031fbbb10a888b"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"e3df386663e1b73f522abf6638aceb1f91617b48","unresolved":false,"context_lines":[{"line_number":792,"context_line":"        \u0027\u0027\u0027"},{"line_number":793,"context_line":"        "},{"line_number":794,"context_line":"        nat_called \u003d [False];"},{"line_number":795,"context_line":"        def fakeNat(*args, **kwargs):"},{"line_number":796,"context_line":"            nat_called[0] \u003d True"},{"line_number":797,"context_line":"        "},{"line_number":798,"context_line":"        def fakeBind(*args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FDh4%3D","line":795,"updated":"2013-02-08 19:24:52.000000000","message":"I believe pep8 will insist on there being a blank line before this function declaration.  Also, I strongly prefer snake-case names, even on internally declared functions like this; i.e., name this \"fake_nat\" instead of \"fakeNat\".","commit_id":"d9d64ed8209c1cce90226992e2031fbbb10a888b"},{"author":{"_account_id":6728,"name":"Mingyan Bao","email":"bao.mingyan@hp.com","username":"Mingyan.Bao"},"change_message_id":"b0e8812332374ef372fa66c94215148a8c6671c1","unresolved":false,"context_lines":[{"line_number":792,"context_line":"        \u0027\u0027\u0027"},{"line_number":793,"context_line":"        "},{"line_number":794,"context_line":"        nat_called \u003d [False];"},{"line_number":795,"context_line":"        def fakeNat(*args, **kwargs):"},{"line_number":796,"context_line":"            nat_called[0] \u003d True"},{"line_number":797,"context_line":"        "},{"line_number":798,"context_line":"        def fakeBind(*args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FDcs%3D","line":795,"in_reply_to":"AAAAM3%2F%2FDh4%3D","updated":"2013-02-08 20:10:45.000000000","message":"Done","commit_id":"d9d64ed8209c1cce90226992e2031fbbb10a888b"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"993fc6a60871df0ab7d6ac7ebd13879fb77b9601","unresolved":false,"context_lines":[{"line_number":719,"context_line":"                    \u0027Cannot find device \"em0\"\\n\u0027)"},{"line_number":720,"context_line":""},{"line_number":721,"context_line":"        def fake9(*args, **kwargs):"},{"line_number":722,"context_line":"            raise test.TestingException()"},{"line_number":723,"context_line":""},{"line_number":724,"context_line":"        # raises because interface doesn\u0027t exist"},{"line_number":725,"context_line":"        self.stubs.Set(self.network.db,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FC1M%3D","line":722,"updated":"2013-02-09 07:40:34.000000000","message":"I know its not your fault, but wow. Worst named fakes ever.","commit_id":"12c73ee65372fd1b0a3d3417cd91e548fd7afd2b"}]}