)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"2a3c5e5fda0b7a745d88c4b057add6542269f7dc","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch ensures that we don\u0027t look for the libvirt disk spec (skip"},{"line_number":10,"context_line":"calling _get_snap_dev()) if the new backing file for rebase op is"},{"line_number":11,"context_line":"None. More details are provided in the bug associated."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I98deda75310f0b44b70257071d282aa50babe06b"},{"line_number":14,"context_line":"Tested-By: Zhang Jinnan\u003czhang.jinnan@99cloud.net\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"fa1b9901_765570c4","line":11,"updated":"2015-08-24 13:21:22.000000000","message":"The commit messages should be self-contained and provide enough information without relying on reader going off to look at bugs\n\nSee the second point here:\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Information_in_commit_messages","commit_id":"bcefb889f6d53e6582daf4c39de8194bdd9d1917"},{"author":{"_account_id":10796,"name":"Deepak C Shetty (deepakcs)","email":"dpkshetty@gmail.com","username":"deepakcs"},"change_message_id":"6e7cb7ae6aefa1a87c429d0f6d1dc335e8a3f7b0","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch ensures that we don\u0027t look for the libvirt disk spec (skip"},{"line_number":10,"context_line":"calling _get_snap_dev()) if the new backing file for rebase op is"},{"line_number":11,"context_line":"None. More details are provided in the bug associated."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I98deda75310f0b44b70257071d282aa50babe06b"},{"line_number":14,"context_line":"Tested-By: Zhang Jinnan\u003czhang.jinnan@99cloud.net\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"fa1b9901_1e21864d","line":11,"in_reply_to":"fa1b9901_765570c4","updated":"2015-08-25 06:30:33.000000000","message":"Done","commit_id":"bcefb889f6d53e6582daf4c39de8194bdd9d1917"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"db2142fdb368bfb60c4ea92b5c9f56b1e1432a86","unresolved":false,"context_lines":[{"line_number":1831,"context_line":"        timer.start(interval\u003d0.5).wait()"},{"line_number":1832,"context_line":""},{"line_number":1833,"context_line":"    def _volume_snapshot_delete(self, context, instance, volume_id,"},{"line_number":1834,"context_line":"                                snapshot_id, delete_info\u003dNone):"},{"line_number":1835,"context_line":"        \"\"\"Note:"},{"line_number":1836,"context_line":"            if file being merged into \u003d\u003d active image:"},{"line_number":1837,"context_line":"                do a blockRebase (pull) operation"}],"source_content_type":"text/x-python","patch_set":7,"id":"da20952f_939161f4","line":1834,"range":{"start_line":1834,"start_character":45,"end_line":1834,"end_character":61},"updated":"2015-09-08 18:18:04.000000000","message":"Just a comment.. this defaults to \u003dNone","commit_id":"7d5df265e53915bd9de066373596f12a62a11f0b"},{"author":{"_account_id":10796,"name":"Deepak C Shetty (deepakcs)","email":"dpkshetty@gmail.com","username":"deepakcs"},"change_message_id":"d6fc9e01506afa1ba0be52f11174bc4ffe031f42","unresolved":false,"context_lines":[{"line_number":1831,"context_line":"        timer.start(interval\u003d0.5).wait()"},{"line_number":1832,"context_line":""},{"line_number":1833,"context_line":"    def _volume_snapshot_delete(self, context, instance, volume_id,"},{"line_number":1834,"context_line":"                                snapshot_id, delete_info\u003dNone):"},{"line_number":1835,"context_line":"        \"\"\"Note:"},{"line_number":1836,"context_line":"            if file being merged into \u003d\u003d active image:"},{"line_number":1837,"context_line":"                do a blockRebase (pull) operation"}],"source_content_type":"text/x-python","patch_set":7,"id":"da20952f_b2b7ad39","line":1834,"in_reply_to":"da20952f_939161f4","updated":"2015-09-09 05:21:47.000000000","message":"ack","commit_id":"7d5df265e53915bd9de066373596f12a62a11f0b"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"db2142fdb368bfb60c4ea92b5c9f56b1e1432a86","unresolved":false,"context_lines":[{"line_number":1866,"context_line":"        LOG.debug(\u0027volume_snapshot_delete: delete_info: %s\u0027, delete_info,"},{"line_number":1867,"context_line":"                  instance\u003dinstance)"},{"line_number":1868,"context_line":""},{"line_number":1869,"context_line":"        if delete_info[\u0027type\u0027] !\u003d \u0027qcow2\u0027:"},{"line_number":1870,"context_line":"            msg \u003d _(\u0027Unknown delete_info type %s\u0027) % delete_info[\u0027type\u0027]"},{"line_number":1871,"context_line":"            raise exception.NovaException(msg)"},{"line_number":1872,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"da20952f_73bfed60","line":1869,"updated":"2015-09-08 18:18:04.000000000","message":"But it looks like we assume it\u0027s not None here. That seems, like, bad and stuff.","commit_id":"7d5df265e53915bd9de066373596f12a62a11f0b"},{"author":{"_account_id":10796,"name":"Deepak C Shetty (deepakcs)","email":"dpkshetty@gmail.com","username":"deepakcs"},"change_message_id":"d6fc9e01506afa1ba0be52f11174bc4ffe031f42","unresolved":false,"context_lines":[{"line_number":1866,"context_line":"        LOG.debug(\u0027volume_snapshot_delete: delete_info: %s\u0027, delete_info,"},{"line_number":1867,"context_line":"                  instance\u003dinstance)"},{"line_number":1868,"context_line":""},{"line_number":1869,"context_line":"        if delete_info[\u0027type\u0027] !\u003d \u0027qcow2\u0027:"},{"line_number":1870,"context_line":"            msg \u003d _(\u0027Unknown delete_info type %s\u0027) % delete_info[\u0027type\u0027]"},{"line_number":1871,"context_line":"            raise exception.NovaException(msg)"},{"line_number":1872,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"da20952f_d2b4a136","line":1869,"in_reply_to":"da20952f_73bfed60","updated":"2015-09-09 05:21:47.000000000","message":"Good catch, i can remove \u003dNone in a future patch. Maybe it was done for existing callers that dont\u0027 send delete_info, but I don\u0027t see any such caller now, so it should be safe to remove \u003dNone","commit_id":"7d5df265e53915bd9de066373596f12a62a11f0b"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"db2142fdb368bfb60c4ea92b5c9f56b1e1432a86","unresolved":false,"context_lines":[{"line_number":1957,"context_line":"            rebase_disk \u003d my_dev"},{"line_number":1958,"context_line":"            rebase_base \u003d delete_info[\u0027file_to_merge\u0027]  # often None"},{"line_number":1959,"context_line":"            if (active_protocol is not None) and (rebase_base is not None):"},{"line_number":1960,"context_line":"                rebase_base \u003d _get_snap_dev(rebase_base,"},{"line_number":1961,"context_line":"                                            active_disk_object.backing_store)"},{"line_number":1962,"context_line":""},{"line_number":1963,"context_line":"            # NOTE(deepakcs): libvirt added support for _RELATIVE in v1.2.7,"}],"source_content_type":"text/x-python","patch_set":7,"id":"da20952f_1339d1f2","line":1960,"updated":"2015-09-08 18:18:04.000000000","message":"It\u0027s pretty unfortunate that this _volume_snapshot_delete() method is so enormous, making it basically impossible to unit test this bit of logic. What is being done to test this is more of a functional test, requiring mocking out a lot of things to get down to this level :(","commit_id":"7d5df265e53915bd9de066373596f12a62a11f0b"},{"author":{"_account_id":10796,"name":"Deepak C Shetty (deepakcs)","email":"dpkshetty@gmail.com","username":"deepakcs"},"change_message_id":"d6fc9e01506afa1ba0be52f11174bc4ffe031f42","unresolved":false,"context_lines":[{"line_number":1957,"context_line":"            rebase_disk \u003d my_dev"},{"line_number":1958,"context_line":"            rebase_base \u003d delete_info[\u0027file_to_merge\u0027]  # often None"},{"line_number":1959,"context_line":"            if (active_protocol is not None) and (rebase_base is not None):"},{"line_number":1960,"context_line":"                rebase_base \u003d _get_snap_dev(rebase_base,"},{"line_number":1961,"context_line":"                                            active_disk_object.backing_store)"},{"line_number":1962,"context_line":""},{"line_number":1963,"context_line":"            # NOTE(deepakcs): libvirt added support for _RELATIVE in v1.2.7,"}],"source_content_type":"text/x-python","patch_set":7,"id":"da20952f_f294458d","line":1960,"in_reply_to":"da20952f_1339d1f2","updated":"2015-09-09 05:21:47.000000000","message":"I am doing it in https://review.openstack.org/#/c/209904/ but that patch series\nas part of \"volume snapshot improvement\" bp is now pushed to M :(","commit_id":"7d5df265e53915bd9de066373596f12a62a11f0b"}]}