)]}'
{"nova/virt/libvirt/blockinfo.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"bd4e436966036fa8972fa3bf00133fb325a86ff8","unresolved":false,"context_lines":[{"line_number":414,"context_line":"def get_root_info(instance, virt_type, image_meta, root_bdm,"},{"line_number":415,"context_line":"                  disk_bus, cdrom_bus, root_device_name\u003dNone):"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"    # NOTE(ndipanov): This is a hack to avoid considering an image"},{"line_number":418,"context_line":"    #                 BDM with local target, as we don\u0027t support them"},{"line_number":419,"context_line":"    #                 yet. Only applies when passed non-driver format"},{"line_number":420,"context_line":"    no_root_bdm \u003d (not root_bdm or ("}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_ad835202","line":417,"updated":"2015-08-26 06:46:04.000000000","message":"Strangely, you kept this one :)","commit_id":"98b351ec10a69012874e29dab110b4d2ab2fd986"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"cc7169f52b4b46cfbc50e790f38f050eadefbbd0","unresolved":false,"context_lines":[{"line_number":414,"context_line":"def get_root_info(instance, virt_type, image_meta, root_bdm,"},{"line_number":415,"context_line":"                  disk_bus, cdrom_bus, root_device_name\u003dNone):"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"    # NOTE(ndipanov): This is a hack to avoid considering an image"},{"line_number":418,"context_line":"    #                 BDM with local target, as we don\u0027t support them"},{"line_number":419,"context_line":"    #                 yet. Only applies when passed non-driver format"},{"line_number":420,"context_line":"    no_root_bdm \u003d (not root_bdm or ("}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_f04fe18f","line":417,"in_reply_to":"fa1b9901_ad835202","updated":"2015-08-26 07:25:53.000000000","message":"Yes that is because it\u0027s explicitly indicated this is a hack, so if people need to find better way is good to know how did that.","commit_id":"98b351ec10a69012874e29dab110b4d2ab2fd986"}],"nova/virt/libvirt/imagebackend.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"bd4e436966036fa8972fa3bf00133fb325a86ff8","unresolved":false,"context_lines":[{"line_number":270,"context_line":"        # is even downloaded from glance, but currently min_disk is"},{"line_number":271,"context_line":"        # adjustable and doesn\u0027t currently account for virtual disk"},{"line_number":272,"context_line":"        # size, so we need this extra check here."},{"line_number":273,"context_line":"        # NOTE(cfb): Having a flavor that sets the root size to 0 and"},{"line_number":274,"context_line":"        # having nova effectively ignore that size and use the size of"},{"line_number":275,"context_line":"        # the image is considered a feature at this time, not a bug."},{"line_number":276,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_0daa7e71","line":273,"updated":"2015-08-26 06:46:04.000000000","message":"And these above you kept, too :)","commit_id":"98b351ec10a69012874e29dab110b4d2ab2fd986"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"cc7169f52b4b46cfbc50e790f38f050eadefbbd0","unresolved":false,"context_lines":[{"line_number":270,"context_line":"        # is even downloaded from glance, but currently min_disk is"},{"line_number":271,"context_line":"        # adjustable and doesn\u0027t currently account for virtual disk"},{"line_number":272,"context_line":"        # size, so we need this extra check here."},{"line_number":273,"context_line":"        # NOTE(cfb): Having a flavor that sets the root size to 0 and"},{"line_number":274,"context_line":"        # having nova effectively ignore that size and use the size of"},{"line_number":275,"context_line":"        # the image is considered a feature at this time, not a bug."},{"line_number":276,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_a30a811e","line":273,"in_reply_to":"fa1b9901_0daa7e71","updated":"2015-08-26 07:25:53.000000000","message":"Again, note from cfb is to explain something seems to be a hack. About the pbrady one I could probably remove it yes.","commit_id":"98b351ec10a69012874e29dab110b4d2ab2fd986"}]}