)]}'
{"nova/virt/disk/mount/api.py":[{"author":{"_account_id":1865,"name":"Andrea Rosa","email":"andrea.rosa@gmail.com","username":"andrea-rosa-m"},"change_message_id":"818e93af45e91c1b836aa109469db11fc607ba66","unresolved":false,"context_lines":[{"line_number":182,"context_line":"                rechecks -\u003d 1"},{"line_number":183,"context_line":"                if rechecks \u003c\u003d 0:"},{"line_number":184,"context_line":"                    break"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"            if not os.path.exists(map_path):"},{"line_number":187,"context_line":"                if not err:"},{"line_number":188,"context_line":"                    err \u003d _(\u0027partition %s not found\u0027) % self.partition"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_28e6c6b0","line":185,"updated":"2015-08-14 10:13:12.000000000","message":"I think that for this pattern you should use the FixedIntervalLoopingCall class from the oslo.sevice library.\nsomething like \nhttps://github.com/openstack/nova/blob/master/nova/compute/manager.py#L6392","commit_id":"639d221ed2e5794ac96855e0d929baa4ec0e859e"},{"author":{"_account_id":11650,"name":"Tom Cammann","email":"tom.cammann@hpe.com","username":"cammann"},"change_message_id":"cdf269652b198ed6f68aececb644f950d0eaeab4","unresolved":false,"context_lines":[{"line_number":182,"context_line":"                rechecks -\u003d 1"},{"line_number":183,"context_line":"                if rechecks \u003c\u003d 0:"},{"line_number":184,"context_line":"                    break"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"            if not os.path.exists(map_path):"},{"line_number":187,"context_line":"                if not err:"},{"line_number":188,"context_line":"                    err \u003d _(\u0027partition %s not found\u0027) % self.partition"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_97584e8c","line":185,"in_reply_to":"1a4dcd0f_28e6c6b0","updated":"2015-08-14 13:52:13.000000000","message":"Agree with Andrea otherwise you could end up blocking this API thread for 3 seconds. Also you may want to pull out the sleep time and number of rechecks like \"MAX_DEVICE_WAIT\" at the top of the file.","commit_id":"639d221ed2e5794ac96855e0d929baa4ec0e859e"}]}