)]}'
{"nova/conductor/manager.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"65d278c0b88a98927f84e20ee4c2231136726acd","unresolved":false,"context_lines":[{"line_number":242,"context_line":"        result \u003d self.db.instance_get_active_by_window(context, begin, end,"},{"line_number":243,"context_line":"                                                       project_id, host)"},{"line_number":244,"context_line":"        return jsonutils.to_primitive(result)"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"    def instance_get_active_by_window_joined(self, context, begin, end\u003dNone,"},{"line_number":247,"context_line":"                                             project_id\u003dNone, host\u003dNone):"},{"line_number":248,"context_line":"        result \u003d self.db.instance_get_active_by_window_joined("}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FDfI%3D","side":"PARENT","line":245,"updated":"2013-02-08 19:46:29.000000000","message":"You can\u0027t remove this from conductor manager yet.","commit_id":"daddc54befea4414776368b0ae8f689872b21e27"}],"nova/conductor/rpcapi.py":[{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"1f73070525f81d8c3f5450a973d9cce24f85cc4c","unresolved":false,"context_lines":[{"line_number":244,"context_line":"                            timeout\u003dtimeout)"},{"line_number":245,"context_line":"        return self.call(context, msg, version\u003d\u00271.15\u0027)"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"    def instance_get_active_by_window(self, context, begin, end\u003dNone,"},{"line_number":248,"context_line":"                                      project_id\u003dNone, host\u003dNone):"},{"line_number":249,"context_line":"        msg \u003d self.make_msg(\u0027instance_get_active_by_window\u0027,"},{"line_number":250,"context_line":"                            begin\u003dbegin, end\u003dend, project_id\u003dproject_id,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FE3Y%3D","side":"PARENT","line":247,"updated":"2013-02-07 21:27:42.000000000","message":"When we want to remove arguments from a call, don\u0027t we tend to  leave them until a major version bump?  If so, then it seems like we also need to leave a full method as well.","commit_id":"daddc54befea4414776368b0ae8f689872b21e27"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"65d278c0b88a98927f84e20ee4c2231136726acd","unresolved":false,"context_lines":[{"line_number":244,"context_line":"                            timeout\u003dtimeout)"},{"line_number":245,"context_line":"        return self.call(context, msg, version\u003d\u00271.15\u0027)"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"    def instance_get_active_by_window(self, context, begin, end\u003dNone,"},{"line_number":248,"context_line":"                                      project_id\u003dNone, host\u003dNone):"},{"line_number":249,"context_line":"        msg \u003d self.make_msg(\u0027instance_get_active_by_window\u0027,"},{"line_number":250,"context_line":"                            begin\u003dbegin, end\u003dend, project_id\u003dproject_id,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FDfM%3D","side":"PARENT","line":247,"in_reply_to":"AAAAM3%2F%2FE3Q%3D","updated":"2013-02-08 19:46:29.000000000","message":"It\u0027s okay to remove this from rpcapi, but not okay to remove it from conductor/manager until the next major RPC API revision. No version bump needed in this case.","commit_id":"daddc54befea4414776368b0ae8f689872b21e27"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"3d5b3401dcff6cfa87203efa4c1445d504bbe45f","unresolved":false,"context_lines":[{"line_number":244,"context_line":"                            timeout\u003dtimeout)"},{"line_number":245,"context_line":"        return self.call(context, msg, version\u003d\u00271.15\u0027)"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"    def instance_get_active_by_window(self, context, begin, end\u003dNone,"},{"line_number":248,"context_line":"                                      project_id\u003dNone, host\u003dNone):"},{"line_number":249,"context_line":"        msg \u003d self.make_msg(\u0027instance_get_active_by_window\u0027,"},{"line_number":250,"context_line":"                            begin\u003dbegin, end\u003dend, project_id\u003dproject_id,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FE3Q%3D","side":"PARENT","line":247,"in_reply_to":"AAAAM3%2F%2FE3Y%3D","updated":"2013-02-07 21:29:31.000000000","message":"Lets confirm with russellb","commit_id":"daddc54befea4414776368b0ae8f689872b21e27"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"65d278c0b88a98927f84e20ee4c2231136726acd","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    1.39 - Added notify_usage_exists"},{"line_number":75,"context_line":"    1.40 - Added security_groups_trigger_handler and"},{"line_number":76,"context_line":"                 security_groups_trigger_members_refresh"},{"line_number":77,"context_line":"           Remove instance_get_active_by_window"},{"line_number":78,"context_line":"    \"\"\""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    BASE_RPC_API_VERSION \u003d \u00271.0\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FDe0%3D","line":77,"updated":"2013-02-08 19:46:29.000000000","message":"This is not critical to function, of course, but I\u0027m not sure what the convention here is, if anything. You don\u0027t want to make it look like you removed this at 1.40 because you didn\u0027t. Maybe russell will have to chime in here after all.","commit_id":"f608df72fae143fb5977553f10d1d3c49e879152"}],"nova/db/sqlalchemy/api.py":[{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"7b45c2c7bb5a5bd680d5cef38e85d586c015533c","unresolved":false,"context_lines":[{"line_number":1653,"context_line":"    return query"},{"line_number":1654,"context_line":""},{"line_number":1655,"context_line":""},{"line_number":1656,"context_line":"#TODO(jogo) This isn\u0027t used anymore, and can be removed"},{"line_number":1657,"context_line":"@require_context"},{"line_number":1658,"context_line":"def instance_get_active_by_window(context, begin, end\u003dNone,"},{"line_number":1659,"context_line":"                                  project_id\u003dNone, host\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FHhY%3D","line":1656,"updated":"2013-02-06 17:47:56.000000000","message":"Why not remove it now?","commit_id":"3dfbe403169a1fedc9e5c56506218140b873fd5d"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"c1c1f29e5d3fc4f56b114ca1fee8156ae39d91d9","unresolved":false,"context_lines":[{"line_number":1653,"context_line":"    return query"},{"line_number":1654,"context_line":""},{"line_number":1655,"context_line":""},{"line_number":1656,"context_line":"#TODO(jogo) This isn\u0027t used anymore, and can be removed"},{"line_number":1657,"context_line":"@require_context"},{"line_number":1658,"context_line":"def instance_get_active_by_window(context, begin, end\u003dNone,"},{"line_number":1659,"context_line":"                                  project_id\u003dNone, host\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FHe0%3D","line":1656,"in_reply_to":"AAAAM3%2F%2FHgE%3D","updated":"2013-02-06 18:03:47.000000000","message":"Fair point.","commit_id":"3dfbe403169a1fedc9e5c56506218140b873fd5d"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"888a31588eaa33f4d2cb16cc4f0a90ceb137eb10","unresolved":false,"context_lines":[{"line_number":1653,"context_line":"    return query"},{"line_number":1654,"context_line":""},{"line_number":1655,"context_line":""},{"line_number":1656,"context_line":"#TODO(jogo) This isn\u0027t used anymore, and can be removed"},{"line_number":1657,"context_line":"@require_context"},{"line_number":1658,"context_line":"def instance_get_active_by_window(context, begin, end\u003dNone,"},{"line_number":1659,"context_line":"                                  project_id\u003dNone, host\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FHgE%3D","line":1656,"in_reply_to":"AAAAM3%2F%2FHhY%3D","updated":"2013-02-06 17:57:54.000000000","message":"Because this has to be removed from conductor and conductor rpc, and want to leave that for a separate patch.","commit_id":"3dfbe403169a1fedc9e5c56506218140b873fd5d"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"87d4a90cf6cd45a667eaedcd2e86afc16d8d06b6","unresolved":false,"context_lines":[{"line_number":1653,"context_line":"    return query"},{"line_number":1654,"context_line":""},{"line_number":1655,"context_line":""},{"line_number":1656,"context_line":"#TODO(jogo) This isn\u0027t used anymore, and can be removed"},{"line_number":1657,"context_line":"@require_context"},{"line_number":1658,"context_line":"def instance_get_active_by_window(context, begin, end\u003dNone,"},{"line_number":1659,"context_line":"                                  project_id\u003dNone, host\u003dNone):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FG7A%3D","line":1656,"updated":"2013-02-06 22:36:44.000000000","message":"So why isn\u0027t it?","commit_id":"761e7fbb74c5f55d4ac7500536969df0701f7a7c"}]}