)]}'
{"nova/api/openstack/compute/admin_password.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"fd99d8be7f13df26cba275527b4f6213ade0344d","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        instance \u003d common.get_instance(self.compute_api, context, id)"},{"line_number":50,"context_line":"        try:"},{"line_number":51,"context_line":"            self.compute_api.set_admin_password(context, instance, password)"},{"line_number":52,"context_line":"        except exception.InstanceUnknownCell as err:"},{"line_number":53,"context_line":"            raise exc.HTTPNotFound(explanation\u003derr.format_message())"},{"line_number":54,"context_line":"        except exception.InstancePasswordSetFailed as e:"},{"line_number":55,"context_line":"            raise exc.HTTPConflict(explanation\u003de.format_message())"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_22066286","line":52,"updated":"2015-08-31 07:32:42.000000000","message":"maybe this is nit picking, but would it not be better to use e to be consistent with the lines below","commit_id":"5323c65c6eac6ceb1f37f72b0005444876521236"}],"nova/api/openstack/compute/create_backup.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"fd99d8be7f13df26cba275527b4f6213ade0344d","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        try:"},{"line_number":67,"context_line":"            image \u003d self.compute_api.backup(context, instance, image_name,"},{"line_number":68,"context_line":"                    backup_type, rotation, extra_properties\u003dprops)"},{"line_number":69,"context_line":"        except exception.InstanceUnknownCell as err:"},{"line_number":70,"context_line":"            raise webob.exc.HTTPNotFound(explanation\u003derr.format_message())"},{"line_number":71,"context_line":"        except exception.InstanceInvalidState as state_error:"},{"line_number":72,"context_line":"            common.raise_http_conflict_for_instance_invalid_state(state_error,"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_e2fb8a79","line":69,"updated":"2015-08-31 07:32:42.000000000","message":"same as before","commit_id":"5323c65c6eac6ceb1f37f72b0005444876521236"}],"nova/api/openstack/compute/floating_ips.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"fd99d8be7f13df26cba275527b4f6213ade0344d","unresolved":false,"context_lines":[{"line_number":242,"context_line":"        except exception.NoFloatingIpInterface:"},{"line_number":243,"context_line":"            msg \u003d _(\u0027l3driver call to add floating ip failed\u0027)"},{"line_number":244,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":245,"context_line":"        except exception.InstanceUnknownCell as err:"},{"line_number":246,"context_line":"            raise webob.exc.HTTPNotFound(explanation\u003derr.format_message())"},{"line_number":247,"context_line":"        except exception.FloatingIpNotFoundForAddress:"},{"line_number":248,"context_line":"            msg \u003d _(\u0027floating ip not found\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_82edeeb8","line":245,"updated":"2015-08-31 07:32:42.000000000","message":"same as before","commit_id":"5323c65c6eac6ceb1f37f72b0005444876521236"}],"nova/api/openstack/compute/migrate_server.py":[{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"493c224d82cb69b3b9fb30dd18b087bf030d2600","unresolved":false,"context_lines":[{"line_number":91,"context_line":"                exception.HypervisorUnavailable,"},{"line_number":92,"context_line":"                exception.MigrationPreCheckError,"},{"line_number":93,"context_line":"                exception.LiveMigrationWithOldNovaNotSafe,"},{"line_number":94,"context_line":"                exception.InstanceUnknownCell) as ex:"},{"line_number":95,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dex.format_message())"},{"line_number":96,"context_line":"        except exception.InstanceIsLocked as e:"},{"line_number":97,"context_line":"            raise exc.HTTPConflict(explanation\u003de.format_message())"}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_533d728d","line":94,"updated":"2015-09-04 18:23:27.000000000","message":"Why is this one raising a HTTPBadRequest while the others are all HTTPNotFound?","commit_id":"bfa13ffb554cd115d586bf96e7e7635afb2ca100"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"7380e65683c683d1fee0a1da7d480d7eef183f87","unresolved":false,"context_lines":[{"line_number":91,"context_line":"                exception.HypervisorUnavailable,"},{"line_number":92,"context_line":"                exception.MigrationPreCheckError,"},{"line_number":93,"context_line":"                exception.LiveMigrationWithOldNovaNotSafe,"},{"line_number":94,"context_line":"                exception.InstanceUnknownCell) as ex:"},{"line_number":95,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dex.format_message())"},{"line_number":96,"context_line":"        except exception.InstanceIsLocked as e:"},{"line_number":97,"context_line":"            raise exc.HTTPConflict(explanation\u003de.format_message())"}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_abdf9d0b","line":94,"in_reply_to":"da20952f_533d728d","updated":"2015-09-06 01:54:27.000000000","message":"my stupid bad.","commit_id":"bfa13ffb554cd115d586bf96e7e7635afb2ca100"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"c9eeed48cc9f07e48f6eb540549f56f4eff94286","unresolved":false,"context_lines":[{"line_number":93,"context_line":"                exception.HypervisorUnavailable,"},{"line_number":94,"context_line":"                exception.MigrationPreCheckError,"},{"line_number":95,"context_line":"                exception.LiveMigrationWithOldNovaNotSafe,"},{"line_number":96,"context_line":"                exception.InstanceUnknownCell) as ex:"},{"line_number":97,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dex.format_message())"},{"line_number":98,"context_line":"        except exception.InstanceIsLocked as e:"},{"line_number":99,"context_line":"            raise exc.HTTPConflict(explanation\u003de.format_message())"}],"source_content_type":"text/x-python","patch_set":7,"id":"da20952f_b5700575","line":96,"updated":"2015-09-08 20:40:38.000000000","message":"This is no longer needed here.","commit_id":"6a3ae1d02be569d62aa6ceaa8b51acd807dcef03"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"68d58ddf465e229a376e934c48cef413bdea45d0","unresolved":false,"context_lines":[{"line_number":93,"context_line":"                exception.HypervisorUnavailable,"},{"line_number":94,"context_line":"                exception.MigrationPreCheckError,"},{"line_number":95,"context_line":"                exception.LiveMigrationWithOldNovaNotSafe,"},{"line_number":96,"context_line":"                exception.InstanceUnknownCell) as ex:"},{"line_number":97,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dex.format_message())"},{"line_number":98,"context_line":"        except exception.InstanceIsLocked as e:"},{"line_number":99,"context_line":"            raise exc.HTTPConflict(explanation\u003de.format_message())"}],"source_content_type":"text/x-python","patch_set":7,"id":"da20952f_2aab27d8","line":96,"in_reply_to":"da20952f_b5700575","updated":"2015-09-09 01:21:55.000000000","message":"Done","commit_id":"6a3ae1d02be569d62aa6ceaa8b51acd807dcef03"}],"nova/api/openstack/compute/servers.py":[{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"493c224d82cb69b3b9fb30dd18b087bf030d2600","unresolved":false,"context_lines":[{"line_number":745,"context_line":"            try:"},{"line_number":746,"context_line":"                self.compute_api.soft_delete(context, instance)"},{"line_number":747,"context_line":"            except (exception.InstanceInvalidState,"},{"line_number":748,"context_line":"                         exception.InstanceUnknownCell):"},{"line_number":749,"context_line":"                # Note(yufang521247): instance which has never been active"},{"line_number":750,"context_line":"                # is not allowed to be soft_deleted. Thus we have to call"},{"line_number":751,"context_line":"                # delete() to clean up the instance."}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_33d47e1e","line":748,"updated":"2015-09-04 18:23:27.000000000","message":"This is a different type of fix since it\u0027s a change in behavior.  This should be split out into its own patch.","commit_id":"bfa13ffb554cd115d586bf96e7e7635afb2ca100"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"7380e65683c683d1fee0a1da7d480d7eef183f87","unresolved":false,"context_lines":[{"line_number":745,"context_line":"            try:"},{"line_number":746,"context_line":"                self.compute_api.soft_delete(context, instance)"},{"line_number":747,"context_line":"            except (exception.InstanceInvalidState,"},{"line_number":748,"context_line":"                         exception.InstanceUnknownCell):"},{"line_number":749,"context_line":"                # Note(yufang521247): instance which has never been active"},{"line_number":750,"context_line":"                # is not allowed to be soft_deleted. Thus we have to call"},{"line_number":751,"context_line":"                # delete() to clean up the instance."}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_abb8fdc8","line":748,"in_reply_to":"da20952f_33d47e1e","updated":"2015-09-06 01:54:27.000000000","message":"hi Andrew, thanks I will split out and think this a bit more.","commit_id":"bfa13ffb554cd115d586bf96e7e7635afb2ca100"}]}