)]}'
{"nova/objects/pci_device.py":[{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"d91f94e8fb48663c50e95e2dca37272c472cb155","unresolved":false,"context_lines":[{"line_number":200,"context_line":"                                              self.compute_node_id,"},{"line_number":201,"context_line":"                                              self.address, updates)"},{"line_number":202,"context_line":"                self._from_db_object(self._context, self, db_pci)"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"    def claim(self, instance):"},{"line_number":205,"context_line":"        if self.status !\u003d fields.PciDeviceStatus.AVAILABLE:"},{"line_number":206,"context_line":"            raise exception.PciDeviceInvalidStatus("}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_6b037e10","line":203,"updated":"2015-08-17 15:21:57.000000000","message":"Any reason you changed from the status-check decorator? I thought it made the code more readable.","commit_id":"0407799d59da96422991d1d645bcd59b186c61ef"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"ed3d5807107766c769b98100144962c5fa480593","unresolved":false,"context_lines":[{"line_number":200,"context_line":"                                              self.compute_node_id,"},{"line_number":201,"context_line":"                                              self.address, updates)"},{"line_number":202,"context_line":"                self._from_db_object(self._context, self, db_pci)"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"    def claim(self, instance):"},{"line_number":205,"context_line":"        if self.status !\u003d fields.PciDeviceStatus.AVAILABLE:"},{"line_number":206,"context_line":"            raise exception.PciDeviceInvalidStatus("}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_8b004fac","line":203,"in_reply_to":"fa1b9901_6b037e10","updated":"2015-08-17 16:04:24.000000000","message":"I thought it was odd to have one exception (PciDeviceInvalidStatus) handled using a decorator and another exception (PciDeviceInvalidOwner) handled without using a decorator. Felt having everything follow a non-decorator code path was actually more explicit.","commit_id":"0407799d59da96422991d1d645bcd59b186c61ef"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"da1018e8120b0d5edbe04060ddf6bff6b54eff07","unresolved":false,"context_lines":[{"line_number":202,"context_line":"                self._from_db_object(self._context, self, db_pci)"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"    def claim(self, instance):"},{"line_number":205,"context_line":"        if self.status !\u003d fields.PciDeviceStatus.AVAILABLE:"},{"line_number":206,"context_line":"            raise exception.PciDeviceInvalidStatus("},{"line_number":207,"context_line":"                compute_node_id\u003dself.compute_node_id,"},{"line_number":208,"context_line":"                address\u003dself.address, status\u003dself.status,"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_87f0be68","line":205,"updated":"2015-08-19 23:34:11.000000000","message":"thanks for not reusing a decorator for checking that ;)","commit_id":"ee2ecfc68aaf52223d6491dd7a366682d06c03c6"}],"nova/tests/unit/objects/test_pci_device.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"da1018e8120b0d5edbe04060ddf6bff6b54eff07","unresolved":false,"context_lines":[{"line_number":248,"context_line":""},{"line_number":249,"context_line":"    def test_claim_device(self):"},{"line_number":250,"context_line":"        self._create_fake_instance()"},{"line_number":251,"context_line":"        devobj \u003d pci_device.PciDevice.create(dev_dict)"},{"line_number":252,"context_line":"        devobj.claim(self.inst)"},{"line_number":253,"context_line":"        self.assertEqual(devobj.status,"},{"line_number":254,"context_line":"                         fields.PciDeviceStatus.CLAIMED)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_7f6c12d0","line":251,"updated":"2015-08-19 23:34:11.000000000","message":"well, it sounds a bit redundant to create a new devobj for each test, but that\u0027s fine to me.","commit_id":"ee2ecfc68aaf52223d6491dd7a366682d06c03c6"}]}