)]}'
{"nova/compute/api.py":[{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"8c865f8d49865a1e78a8e7bbee55c48669ab3d73","unresolved":false,"context_lines":[{"line_number":743,"context_line":""},{"line_number":744,"context_line":"        if image_mapping:"},{"line_number":745,"context_line":"            image_defined_bdms \u003d self._prepare_image_mapping("},{"line_number":746,"context_line":"                instance_type, image_mapping) + image_defined_bdms"},{"line_number":747,"context_line":""},{"line_number":748,"context_line":"        return image_defined_bdms"},{"line_number":749,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_0a7600d7","line":746,"updated":"2015-08-25 17:00:25.000000000","message":"So I am definitely not a fan of the implicit behaviour we are taking advantage of here - I think we should be explicit and do a similar thing like we are doing bellow (see comment)","commit_id":"7c6ed4e3951c941b07ca8d6d2f8cbdab8ba95936"},{"author":{"_account_id":10224,"name":"Feodor Tersin","email":"ftersin@hotmail.com","username":"ftersin"},"change_message_id":"f62c9bc99c7f82f3b489413ae2452f701a11aa65","unresolved":false,"context_lines":[{"line_number":743,"context_line":""},{"line_number":744,"context_line":"        if image_mapping:"},{"line_number":745,"context_line":"            image_defined_bdms \u003d self._prepare_image_mapping("},{"line_number":746,"context_line":"                instance_type, image_mapping) + image_defined_bdms"},{"line_number":747,"context_line":""},{"line_number":748,"context_line":"        return image_defined_bdms"},{"line_number":749,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_9e35b4db","line":746,"in_reply_to":"fa1b9901_0a7600d7","updated":"2015-08-27 19:49:12.000000000","message":"Done","commit_id":"7c6ed4e3951c941b07ca8d6d2f8cbdab8ba95936"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"8c865f8d49865a1e78a8e7bbee55c48669ab3d73","unresolved":false,"context_lines":[{"line_number":763,"context_line":"                block_device.create_blank_bdm(instance_type[\u0027swap\u0027], \u0027swap\u0027))"},{"line_number":764,"context_line":""},{"line_number":765,"context_line":"        return flavor_defined_bdms"},{"line_number":766,"context_line":""},{"line_number":767,"context_line":"    def _merge_with_image_bdms(self, block_device_mapping, image_mappings):"},{"line_number":768,"context_line":"        \"\"\"Override any block devices from the image by device name\"\"\""},{"line_number":769,"context_line":"        device_names \u003d set(bdm[\u0027device_name\u0027] for bdm in block_device_mapping"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_65dfad3a","line":766,"updated":"2015-08-25 17:00:25.000000000","message":"Here - so we should have a merge function for image bdms where we are explicit which devices get overriden and we don\u0027t rely on the accidental behaviour of device names being overriden by the DB layer, which is pretty implicit","commit_id":"7c6ed4e3951c941b07ca8d6d2f8cbdab8ba95936"}],"nova/tests/unit/compute/test_compute.py":[{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"ba921bb6352a308a0c1c4a062863d0c84e024540","unresolved":false,"context_lines":[{"line_number":8838,"context_line":"            self.context, base_options, {}, image_meta, 1, 1, [], False)"},{"line_number":8839,"context_line":"        self.assertEqual(1, len(transformed_bdm))"},{"line_number":8840,"context_line":"        self.assertEqual(\u0027volume\u0027, transformed_bdm[0][\u0027destination_type\u0027])"},{"line_number":8841,"context_line":"        self.assertEqual(\u0027/dev/vdb\u0027, transformed_bdm[0][\u0027device_name\u0027])"},{"line_number":8842,"context_line":""},{"line_number":8843,"context_line":"    def test_volume_size(self):"},{"line_number":8844,"context_line":"        ephemeral_size \u003d 2"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_68a308b3","line":8841,"updated":"2015-09-16 14:22:47.000000000","message":"wouldn\u0027t be easier to have it so:\n\n    block_device \u003d {\u0027device_name\u0027: \u0027/dev/vdb\u0027, \u0027source_type\u0027: \u0027blank\u0027,\n                    \u0027destination_type\u0027: \u0027volume\u0027, \u0027volume_size\u0027: 1}\n    image_meta \u003d {\n        \u0027properties\u0027: {\n            \u0027mappings\u0027: [{\u0027virtual\u0027: \u0027ephemeral0\u0027, \u0027device\u0027: \u0027vdb\u0027}],\n            \u0027bdm_v2\u0027: True,\n            \u0027block_device_mapping\u0027: [block_device]}}\n    transformed_bdm \u003d self.compute_api._check_and_transform_bdm(\n        self.context, base_options, {}, image_meta, 1, 1, [], False)\n    self.assertEqual(block_device, transformed_bdm)","commit_id":"4eb800da95a9537407e0e972522606155f90ab63"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"6a0cfb28102092411cc701d95f79fd4e62c8b649","unresolved":false,"context_lines":[{"line_number":8838,"context_line":"            self.context, base_options, {}, image_meta, 1, 1, [], False)"},{"line_number":8839,"context_line":"        self.assertEqual(1, len(transformed_bdm))"},{"line_number":8840,"context_line":"        self.assertEqual(\u0027volume\u0027, transformed_bdm[0][\u0027destination_type\u0027])"},{"line_number":8841,"context_line":"        self.assertEqual(\u0027/dev/vdb\u0027, transformed_bdm[0][\u0027device_name\u0027])"},{"line_number":8842,"context_line":""},{"line_number":8843,"context_line":"    def test_volume_size(self):"},{"line_number":8844,"context_line":"        ephemeral_size \u003d 2"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_1f5db978","line":8841,"in_reply_to":"ba15a1d1_68a308b3","updated":"2015-09-17 09:59:32.000000000","message":"it would need to be:\n\n  self.assertEqual(block_device, transformed_bdm[0])\n\nA pretty small nit and this is maybe more explicit","commit_id":"4eb800da95a9537407e0e972522606155f90ab63"}]}