)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"8513ac146e67945651cf182685a2fad66641c30c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     jichenjc \u003cjichenjc@cn.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-11-24 01:29:47 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Prevent build more than one default ephemeral disk"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Nova allow following command"},{"line_number":10,"context_line":"nova boot --image 3ec2603b-9113-4ca1-92cf-690e573985bd --flavor 11"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7a740942_b24f46bc","line":7,"updated":"2015-12-07 08:48:11.000000000","message":"This is confusing as the API supports more than one ephemeral disk. You should state that this is when one does not have size defined","commit_id":"5067a12f68e8eacc5a4b97497f0dfab909ec904e"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"6d7b4796213fe295cbbca001a12f2420011019a1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     jichenjc \u003cjichenjc@cn.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-11-24 01:29:47 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Prevent build more than one default ephemeral disk"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Nova allow following command"},{"line_number":10,"context_line":"nova boot --image 3ec2603b-9113-4ca1-92cf-690e573985bd --flavor 11"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7a740942_3529328a","line":7,"in_reply_to":"7a740942_b24f46bc","updated":"2015-12-10 12:22:30.000000000","message":"Done","commit_id":"5067a12f68e8eacc5a4b97497f0dfab909ec904e"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"8513ac146e67945651cf182685a2fad66641c30c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Prevent build more than one default ephemeral disk"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Nova allow following command"},{"line_number":10,"context_line":"nova boot --image 3ec2603b-9113-4ca1-92cf-690e573985bd --flavor 11"},{"line_number":11,"context_line":"--block-device source\u003dblank,dest\u003dlocal"},{"line_number":12,"context_line":"--block-device source\u003dblank,dest\u003dlocal test"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7a740942_722c7e02","line":9,"updated":"2015-12-07 08:48:11.000000000","message":"allow \u003d\u003e allows the","commit_id":"5067a12f68e8eacc5a4b97497f0dfab909ec904e"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"6d7b4796213fe295cbbca001a12f2420011019a1","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Prevent build more than one default ephemeral disk"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Nova allow following command"},{"line_number":10,"context_line":"nova boot --image 3ec2603b-9113-4ca1-92cf-690e573985bd --flavor 11"},{"line_number":11,"context_line":"--block-device source\u003dblank,dest\u003dlocal"},{"line_number":12,"context_line":"--block-device source\u003dblank,dest\u003dlocal test"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7a740942_b53522dc","line":9,"in_reply_to":"7a740942_722c7e02","updated":"2015-12-10 12:22:30.000000000","message":"Done","commit_id":"5067a12f68e8eacc5a4b97497f0dfab909ec904e"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"8513ac146e67945651cf182685a2fad66641c30c","unresolved":false,"context_lines":[{"line_number":12,"context_line":"--block-device source\u003dblank,dest\u003dlocal test"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"which in turn translate the ephemeral disk mappings into 2"},{"line_number":15,"context_line":"default ephemeral disk and violate the rule for ephemeral disk"},{"line_number":16,"context_line":"This patch add checks to this kind of siutation and prevents it."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I1952eeb04bf3835182e575e418632a6d611c84e9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7a740942_d24532b3","line":15,"updated":"2015-12-07 08:48:11.000000000","message":"out of interest where is this rule?","commit_id":"5067a12f68e8eacc5a4b97497f0dfab909ec904e"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"6d7b4796213fe295cbbca001a12f2420011019a1","unresolved":false,"context_lines":[{"line_number":12,"context_line":"--block-device source\u003dblank,dest\u003dlocal test"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"which in turn translate the ephemeral disk mappings into 2"},{"line_number":15,"context_line":"default ephemeral disk and violate the rule for ephemeral disk"},{"line_number":16,"context_line":"This patch add checks to this kind of siutation and prevents it."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I1952eeb04bf3835182e575e418632a6d611c84e9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7a740942_5534fedc","line":15,"in_reply_to":"7a740942_d24532b3","updated":"2015-12-10 12:22:30.000000000","message":"change the wording","commit_id":"5067a12f68e8eacc5a4b97497f0dfab909ec904e"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"8513ac146e67945651cf182685a2fad66641c30c","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"which in turn translate the ephemeral disk mappings into 2"},{"line_number":15,"context_line":"default ephemeral disk and violate the rule for ephemeral disk"},{"line_number":16,"context_line":"This patch add checks to this kind of siutation and prevents it."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I1952eeb04bf3835182e575e418632a6d611c84e9"},{"line_number":19,"context_line":"Closes-Bug: 1483645"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7a740942_320d9690","line":16,"range":{"start_line":16,"start_character":38,"end_line":16,"end_character":47},"updated":"2015-12-07 08:48:11.000000000","message":"siutation \u003d\u003e situation","commit_id":"5067a12f68e8eacc5a4b97497f0dfab909ec904e"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"6d7b4796213fe295cbbca001a12f2420011019a1","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"which in turn translate the ephemeral disk mappings into 2"},{"line_number":15,"context_line":"default ephemeral disk and violate the rule for ephemeral disk"},{"line_number":16,"context_line":"This patch add checks to this kind of siutation and prevents it."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I1952eeb04bf3835182e575e418632a6d611c84e9"},{"line_number":19,"context_line":"Closes-Bug: 1483645"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7a740942_752fba88","line":16,"in_reply_to":"7a740942_320d9690","updated":"2015-12-10 12:22:30.000000000","message":"Done","commit_id":"5067a12f68e8eacc5a4b97497f0dfab909ec904e"}],"nova/compute/api.py":[{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"315968789455a5cddfe009ca5f139cc6a25f174b","unresolved":false,"context_lines":[{"line_number":1332,"context_line":"                    \"(source: \u0027blank\u0027, dest: \u0027volume\u0027) need to have non-zero \""},{"line_number":1333,"context_line":"                    \"size\"))"},{"line_number":1334,"context_line":""},{"line_number":1335,"context_line":"        ephemeral_size \u003d sum(bdm.volume_size or 0"},{"line_number":1336,"context_line":"                for bdm in all_mappings"},{"line_number":1337,"context_line":"                if block_device.new_format_is_ephemeral(bdm))"},{"line_number":1338,"context_line":"        if ephemeral_size \u003e instance_type[\u0027ephemeral_gb\u0027]:"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_18d90f57","side":"PARENT","line":1335,"updated":"2015-09-18 15:58:26.000000000","message":"Shouldn\u0027t we just do \n\n  sum(bdm.volume_size or instance[\u0027ephemeral_size\u0027] ...\n\nand be done with it?\n\nWe don\u0027t need to update the volume size of the bdm here as it will be updated in _create_block_device_mapping","commit_id":"003a2f6fcb3295d15d61825bfe6fa7e07033693a"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"e18e61307913ad9756a45322b2e366c19b55f3cb","unresolved":false,"context_lines":[{"line_number":1332,"context_line":"                    \"(source: \u0027blank\u0027, dest: \u0027volume\u0027) need to have non-zero \""},{"line_number":1333,"context_line":"                    \"size\"))"},{"line_number":1334,"context_line":""},{"line_number":1335,"context_line":"        ephemeral_size \u003d sum(bdm.volume_size or 0"},{"line_number":1336,"context_line":"                for bdm in all_mappings"},{"line_number":1337,"context_line":"                if block_device.new_format_is_ephemeral(bdm))"},{"line_number":1338,"context_line":"        if ephemeral_size \u003e instance_type[\u0027ephemeral_gb\u0027]:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_cb30670a","side":"PARENT","line":1335,"in_reply_to":"ba15a1d1_18d90f57","updated":"2015-10-02 11:58:46.000000000","message":"right, thanks~","commit_id":"003a2f6fcb3295d15d61825bfe6fa7e07033693a"}],"nova/exception.py":[{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"158cffa630843372322b13029d035757cb8a89b2","unresolved":false,"context_lines":[{"line_number":245,"context_line":"    msg_fmt \u003d _(\"Ephemeral disks requested are larger than \""},{"line_number":246,"context_line":"                \"the instance type allows. If no size is given \""},{"line_number":247,"context_line":"                \"in one block device mapping, flavor ephemeral \""},{"line_number":248,"context_line":"                \"size will be used\")"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"class InvalidBDMSwapSize(InvalidBDM):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_3d891027","line":248,"updated":"2015-09-15 09:49:32.000000000","message":"used. instead of used","commit_id":"33fcf1955942d51a4dddb9fb7bcbb37270714a0f"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"4ceba2fd2a562e2029f790ba9dfc3ef07de42b32","unresolved":false,"context_lines":[{"line_number":245,"context_line":"    msg_fmt \u003d _(\"Ephemeral disks requested are larger than \""},{"line_number":246,"context_line":"                \"the instance type allows. If no size is given \""},{"line_number":247,"context_line":"                \"in one block device mapping, flavor ephemeral \""},{"line_number":248,"context_line":"                \"size will be used\")"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"class InvalidBDMSwapSize(InvalidBDM):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_6d164f4d","line":248,"in_reply_to":"ba15a1d1_3d891027","updated":"2015-09-18 15:25:52.000000000","message":"given string freeze, its probably better to not do this change.","commit_id":"33fcf1955942d51a4dddb9fb7bcbb37270714a0f"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"315968789455a5cddfe009ca5f139cc6a25f174b","unresolved":false,"context_lines":[{"line_number":245,"context_line":"    msg_fmt \u003d _(\"Ephemeral disks requested are larger than \""},{"line_number":246,"context_line":"                \"the instance type allows. If no size is given \""},{"line_number":247,"context_line":"                \"in one block device mapping, flavor ephemeral \""},{"line_number":248,"context_line":"                \"size will be used\")"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"class InvalidBDMSwapSize(InvalidBDM):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_f891bb47","line":248,"in_reply_to":"ba15a1d1_6d164f4d","updated":"2015-09-18 15:58:26.000000000","message":"Agreed - we can skip this","commit_id":"33fcf1955942d51a4dddb9fb7bcbb37270714a0f"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"e18e61307913ad9756a45322b2e366c19b55f3cb","unresolved":false,"context_lines":[{"line_number":245,"context_line":"    msg_fmt \u003d _(\"Ephemeral disks requested are larger than \""},{"line_number":246,"context_line":"                \"the instance type allows. If no size is given \""},{"line_number":247,"context_line":"                \"in one block device mapping, flavor ephemeral \""},{"line_number":248,"context_line":"                \"size will be used\")"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"class InvalidBDMSwapSize(InvalidBDM):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_685b6155","line":248,"in_reply_to":"ba15a1d1_f891bb47","updated":"2015-10-02 11:58:46.000000000","message":"because it\u0027s M release now, I will keep the change for string except \u0027used.\u0027 ..thanks","commit_id":"33fcf1955942d51a4dddb9fb7bcbb37270714a0f"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"b30cfca8f11dc2ac93c2bff29a9b3eb6c5c744dd","unresolved":false,"context_lines":[{"line_number":271,"context_line":"    msg_fmt \u003d _(\"Ephemeral disks requested are larger than \""},{"line_number":272,"context_line":"                \"the instance type allows. If no size is given \""},{"line_number":273,"context_line":"                \"in one block device mapping, flavor ephemeral \""},{"line_number":274,"context_line":"                \"size will be used.\")"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"class InvalidBDMSwapSize(InvalidBDM):"}],"source_content_type":"text/x-python","patch_set":10,"id":"5aef4532_356996bf","line":274,"updated":"2016-03-07 22:54:57.000000000","message":"\"If no size is requested each ephemeral disk will default to the flavor specified size\" might be a bit more clear.","commit_id":"f1c7450789fbd8c530b8fcc4520a2af52a6ad24b"}],"nova/tests/unit/compute/test_compute.py":[{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"158cffa630843372322b13029d035757cb8a89b2","unresolved":false,"context_lines":[{"line_number":1086,"context_line":"        self.assertRaises(exception.InvalidBDMEphemeralSize,"},{"line_number":1087,"context_line":"                  self.compute_api._validate_bdm,"},{"line_number":1088,"context_line":"                  self.context, self.instance,"},{"line_number":1089,"context_line":"                  instance_type, all_mappings)"},{"line_number":1090,"context_line":""},{"line_number":1091,"context_line":"    def test_validate_bdm_media_service_exceptions(self):"},{"line_number":1092,"context_line":"        instance_type \u003d {\u0027swap\u0027: 1, \u0027ephemeral_gb\u0027: 1}"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_5d93a44f","line":1089,"updated":"2015-09-15 09:49:32.000000000","message":"you could indent those args to match the indentation of exception.InvalidBDMEphemeralSize","commit_id":"33fcf1955942d51a4dddb9fb7bcbb37270714a0f"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"e18e61307913ad9756a45322b2e366c19b55f3cb","unresolved":false,"context_lines":[{"line_number":1086,"context_line":"        self.assertRaises(exception.InvalidBDMEphemeralSize,"},{"line_number":1087,"context_line":"                  self.compute_api._validate_bdm,"},{"line_number":1088,"context_line":"                  self.context, self.instance,"},{"line_number":1089,"context_line":"                  instance_type, all_mappings)"},{"line_number":1090,"context_line":""},{"line_number":1091,"context_line":"    def test_validate_bdm_media_service_exceptions(self):"},{"line_number":1092,"context_line":"        instance_type \u003d {\u0027swap\u0027: 1, \u0027ephemeral_gb\u0027: 1}"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_0b1dff65","line":1089,"in_reply_to":"ba15a1d1_5d93a44f","updated":"2015-10-02 11:58:46.000000000","message":"right, done","commit_id":"33fcf1955942d51a4dddb9fb7bcbb37270714a0f"}]}