)]}'
{"nova/conductor/rpcapi.py":[{"author":{"_account_id":4992,"name":"malini-k-bhandaru","email":"malini.k.bhandaru@intel.com","username":"malini-k-bhandaru"},"change_message_id":"0e41d53047ea9d5088ad1037a60c34b2667a8935","unresolved":false,"context_lines":[{"line_number":377,"context_line":"                  system_metadata\u003dsystem_metadata_p,"},{"line_number":378,"context_line":"                  extra_usage_info\u003dextra_usage_info_p)"},{"line_number":379,"context_line":"        return self.call(context, msg, version\u003d\u00271.39\u0027)"},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"    def security_groups_trigger_handler(self, context, event, args):"},{"line_number":382,"context_line":"        args_p \u003d jsonutils.to_primitive(args)"},{"line_number":383,"context_line":"        msg \u003d self.make_msg(\u0027security_groups_trigger_handler\u0027, event\u003devent,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FG3U%3D","line":380,"updated":"2013-02-06 23:13:51.000000000","message":"you have hardcoded version numbers, perhaps introduce constants such as BASE_RPC_API_VERSION. Else the logic of 1.39, 1.4 .. need some explanation for future maintainability.","commit_id":"80de2da0a549d096c1722321f8c2cc7da77785f1"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"adee5f7fcf47aa0919550696b6afbd021d05ae76","unresolved":false,"context_lines":[{"line_number":377,"context_line":"                  system_metadata\u003dsystem_metadata_p,"},{"line_number":378,"context_line":"                  extra_usage_info\u003dextra_usage_info_p)"},{"line_number":379,"context_line":"        return self.call(context, msg, version\u003d\u00271.39\u0027)"},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"    def security_groups_trigger_handler(self, context, event, args):"},{"line_number":382,"context_line":"        args_p \u003d jsonutils.to_primitive(args)"},{"line_number":383,"context_line":"        msg \u003d self.make_msg(\u0027security_groups_trigger_handler\u0027, event\u003devent,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FGz0%3D","line":380,"in_reply_to":"AAAAM3%2F%2FG3U%3D","updated":"2013-02-06 23:33:30.000000000","message":"This is convention everywhere in nova. We want hardcoded version numbers so that they\u0027re never accidentally recalculated.","commit_id":"80de2da0a549d096c1722321f8c2cc7da77785f1"}],"nova/network/quantumv2/api.py":[{"author":{"_account_id":4992,"name":"malini-k-bhandaru","email":"malini.k.bhandaru@intel.com","username":"malini-k-bhandaru"},"change_message_id":"0e41d53047ea9d5088ad1037a60c34b2667a8935","unresolved":false,"context_lines":[{"line_number":16,"context_line":"#"},{"line_number":17,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from nova.compute import api as compute_api"},{"line_number":20,"context_line":"from nova import conductor"},{"line_number":21,"context_line":"from nova.db import base"},{"line_number":22,"context_line":"from nova import exception"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FG4A%3D","line":19,"updated":"2013-02-06 23:13:51.000000000","message":"Remove compute_api import","commit_id":"80de2da0a549d096c1722321f8c2cc7da77785f1"},{"author":{"_account_id":4992,"name":"malini-k-bhandaru","email":"malini.k.bhandaru@intel.com","username":"malini-k-bhandaru"},"change_message_id":"0e41d53047ea9d5088ad1037a60c34b2667a8935","unresolved":false,"context_lines":[{"line_number":73,"context_line":"class API(base.Base):"},{"line_number":74,"context_line":"    \"\"\"API for interacting with the quantum 2.x API.\"\"\""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    security_group_api \u003d compute_api.SecurityGroupAPI()"},{"line_number":77,"context_line":"    conductor_api \u003d conductor.API()"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def setup_networks_on_host(self, context, instance, host\u003dNone,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FG4M%3D","line":76,"updated":"2013-02-06 23:13:51.000000000","message":"Can remove this security_group_api because you are going through conductor","commit_id":"80de2da0a549d096c1722321f8c2cc7da77785f1"}]}