)]}'
{"nova/network/quantumv2/api.py":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"4f2509ff3c62783340d1744945b9d29c1965d4fb","unresolved":false,"context_lines":[{"line_number":669,"context_line":"            bridge \u003d None"},{"line_number":670,"context_line":"            ovs_interfaceid \u003d None"},{"line_number":671,"context_line":"            # Network model metadata"},{"line_number":672,"context_line":"            should_create_bridge \u003d False"},{"line_number":673,"context_line":"            vif_type \u003d port.get(\u0027binding:vif_type\u0027)"},{"line_number":674,"context_line":"            # TODO(berrange) Quantum should pass the bridge name"},{"line_number":675,"context_line":"            # in another binding metadata field"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FFiY%3D","line":672,"updated":"2013-02-07 15:36:38.000000000","message":"This should be \u0027None\u0027 really","commit_id":"866a07f602190004f80c17599ddaf61934dba3a7"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"5d176d8364d7b380b513880d1eba211253496740","unresolved":false,"context_lines":[{"line_number":669,"context_line":"            bridge \u003d None"},{"line_number":670,"context_line":"            ovs_interfaceid \u003d None"},{"line_number":671,"context_line":"            # Network model metadata"},{"line_number":672,"context_line":"            should_create_bridge \u003d False"},{"line_number":673,"context_line":"            vif_type \u003d port.get(\u0027binding:vif_type\u0027)"},{"line_number":674,"context_line":"            # TODO(berrange) Quantum should pass the bridge name"},{"line_number":675,"context_line":"            # in another binding metadata field"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FENk%3D","line":672,"in_reply_to":"AAAAM3%2F%2FFiY%3D","updated":"2013-02-08 07:26:02.000000000","message":"Done","commit_id":"866a07f602190004f80c17599ddaf61934dba3a7"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"4f2509ff3c62783340d1744945b9d29c1965d4fb","unresolved":false,"context_lines":[{"line_number":694,"context_line":"                tenant_id\u003dnet[\u0027tenant_id\u0027]"},{"line_number":695,"context_line":"            )"},{"line_number":696,"context_line":"            network[\u0027subnets\u0027] \u003d subnets"},{"line_number":697,"context_line":"            network[\u0027should_create_bridge\u0027] \u003d should_create_bridge"},{"line_number":698,"context_line":"            nw_info.append(network_model.VIF("},{"line_number":699,"context_line":"                id\u003dport[\u0027id\u0027],"},{"line_number":700,"context_line":"                address\u003dport[\u0027mac_address\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FFiQ%3D","line":697,"updated":"2013-02-07 15:36:38.000000000","message":"And this should be \n\n   if should_create_bridge is not None:\n      network[\u0027should_create_bridge\u0027] \u003d should_create_bridge\n\nWe don\u0027t want to hardcode \u0027False\u0027 in this, since that then requires the VIF driver to explicitly override \u0027False\u0027 with True later.","commit_id":"866a07f602190004f80c17599ddaf61934dba3a7"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"5d176d8364d7b380b513880d1eba211253496740","unresolved":false,"context_lines":[{"line_number":694,"context_line":"                tenant_id\u003dnet[\u0027tenant_id\u0027]"},{"line_number":695,"context_line":"            )"},{"line_number":696,"context_line":"            network[\u0027subnets\u0027] \u003d subnets"},{"line_number":697,"context_line":"            network[\u0027should_create_bridge\u0027] \u003d should_create_bridge"},{"line_number":698,"context_line":"            nw_info.append(network_model.VIF("},{"line_number":699,"context_line":"                id\u003dport[\u0027id\u0027],"},{"line_number":700,"context_line":"                address\u003dport[\u0027mac_address\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FENc%3D","line":697,"in_reply_to":"AAAAM3%2F%2FFiQ%3D","updated":"2013-02-08 07:26:02.000000000","message":"Done","commit_id":"866a07f602190004f80c17599ddaf61934dba3a7"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"3675f106ebb8b96f68cc73c3b09e09d4b4b9831c","unresolved":false,"context_lines":[{"line_number":667,"context_line":"            bridge \u003d None"},{"line_number":668,"context_line":"            ovs_interfaceid \u003d None"},{"line_number":669,"context_line":"            # Network model metadata"},{"line_number":670,"context_line":"            should_create_bridge \u003d None "},{"line_number":671,"context_line":"            vif_type \u003d port.get(\u0027binding:vif_type\u0027)"},{"line_number":672,"context_line":"            # TODO(berrange) Quantum should pass the bridge name"},{"line_number":673,"context_line":"            # in another binding metadata field"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FEJI%3D","line":670,"updated":"2013-02-08 10:10:29.000000000","message":"There\u0027s a trailing whitespace character on this line, which is the cause of the pep8 failure","commit_id":"32b01f95d7ec82ca0de4511399fbe0088940630d"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"ac4e463f6003c4a18268da97f69400cfb308204d","unresolved":false,"context_lines":[{"line_number":667,"context_line":"            bridge \u003d None"},{"line_number":668,"context_line":"            ovs_interfaceid \u003d None"},{"line_number":669,"context_line":"            # Network model metadata"},{"line_number":670,"context_line":"            should_create_bridge \u003d None "},{"line_number":671,"context_line":"            vif_type \u003d port.get(\u0027binding:vif_type\u0027)"},{"line_number":672,"context_line":"            # TODO(berrange) Quantum should pass the bridge name"},{"line_number":673,"context_line":"            # in another binding metadata field"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FD5s%3D","line":670,"in_reply_to":"AAAAM3%2F%2FEJI%3D","updated":"2013-02-08 14:30:07.000000000","message":"no comment from the peanut gallery","commit_id":"32b01f95d7ec82ca0de4511399fbe0088940630d"},{"author":{"_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},"change_message_id":"b015292a7a7add225fbde27125f417b3306d010b","unresolved":false,"context_lines":[{"line_number":667,"context_line":"            bridge \u003d None"},{"line_number":668,"context_line":"            ovs_interfaceid \u003d None"},{"line_number":669,"context_line":"            # Network model metadata"},{"line_number":670,"context_line":"            should_create_bridge \u003d None"},{"line_number":671,"context_line":"            vif_type \u003d port.get(\u0027binding:vif_type\u0027)"},{"line_number":672,"context_line":"            # TODO(berrange) Quantum should pass the bridge name"},{"line_number":673,"context_line":"            # in another binding metadata field"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2B%2Bvk%3D","line":670,"updated":"2013-02-12 16:37:39.000000000","message":"Seems weird to not default this to False, but ok :-)","commit_id":"90f79a0485076bf79d63ed65b55605adec408f32"}],"nova/virt/libvirt/vif.py":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"bbda517b1e73db92fb76ff528037042ac973ba9f","unresolved":false,"context_lines":[{"line_number":415,"context_line":"    def get_config(self, instance, network, mapping):"},{"line_number":416,"context_line":"        # In order for libvirt to make use of the bridge name then it has"},{"line_number":417,"context_line":"        # to ensure that the bridge exists"},{"line_number":418,"context_line":"        mapping[\u0027should_create_bridge\u0027] \u003d True"},{"line_number":419,"context_line":"        return self.get_config_bridge(instance, network, mapping)"},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"    def plug(self, instance, vif):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FF1U%3D","line":418,"updated":"2013-02-07 12:08:24.000000000","message":"I think the \u0027_build_network_info_model\u0027 method in nova/network/quantumv2/api.py ought to be setting this here\n\n            elif vif_type \u003d\u003d network_model.VIF_TYPE_BRIDGE:\n                bridge \u003d \"brq\" + port[\u0027network_id\u0027]\n                mapping[\u0027should_create_bridge\u0027] \u003d True\n\nThen, the VIF driver only set this field, if not already set (for sake of back compat with Quantum instance which don\u0027t report vif_type.  eg. change this VIF code todo\n\n    if \"should_create_bridge\" not in mapping:\n       mapping[\"should_create_bridge\"] \u003d True","commit_id":"38b5c4dbea667b1f198b948f4c18db4266871aae"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"4cde6c6f164ba40731af376891999a2ed4b17aea","unresolved":false,"context_lines":[{"line_number":415,"context_line":"    def get_config(self, instance, network, mapping):"},{"line_number":416,"context_line":"        # In order for libvirt to make use of the bridge name then it has"},{"line_number":417,"context_line":"        # to ensure that the bridge exists"},{"line_number":418,"context_line":"        mapping[\u0027should_create_bridge\u0027] \u003d True"},{"line_number":419,"context_line":"        return self.get_config_bridge(instance, network, mapping)"},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"    def plug(self, instance, vif):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FFzQ%3D","line":418,"in_reply_to":"AAAAM3%2F%2FF1U%3D","updated":"2013-02-07 12:35:07.000000000","message":"Done","commit_id":"38b5c4dbea667b1f198b948f4c18db4266871aae"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"3675f106ebb8b96f68cc73c3b09e09d4b4b9831c","unresolved":false,"context_lines":[{"line_number":455,"context_line":"        # In order for libvirt to make use of the bridge name then it has"},{"line_number":456,"context_line":"        # to ensure that the bridge exists"},{"line_number":457,"context_line":"        if (\u0027should_create_bridge\u0027 not in mapping or"},{"line_number":458,"context_line":"            mapping[\u0027should_create_bridge\u0027] is False):"},{"line_number":459,"context_line":"            mapping[\u0027should_create_bridge\u0027] \u003d True"},{"line_number":460,"context_line":"        return self.get_config_bridge(instance, network, mapping)"},{"line_number":461,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FEJM%3D","line":458,"updated":"2013-02-08 10:10:29.000000000","message":"Now that you changed the quantum api.py file to use \"None\" by default the check for \"mapping[\u0027should_create_bridge\u0027] is False\" should have also been removed. This code should only check for the \"should_create_bridge\" key existing.","commit_id":"32b01f95d7ec82ca0de4511399fbe0088940630d"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"ac4e463f6003c4a18268da97f69400cfb308204d","unresolved":false,"context_lines":[{"line_number":455,"context_line":"        # In order for libvirt to make use of the bridge name then it has"},{"line_number":456,"context_line":"        # to ensure that the bridge exists"},{"line_number":457,"context_line":"        if (\u0027should_create_bridge\u0027 not in mapping or"},{"line_number":458,"context_line":"            mapping[\u0027should_create_bridge\u0027] is False):"},{"line_number":459,"context_line":"            mapping[\u0027should_create_bridge\u0027] \u003d True"},{"line_number":460,"context_line":"        return self.get_config_bridge(instance, network, mapping)"},{"line_number":461,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FD5o%3D","line":458,"in_reply_to":"AAAAM3%2F%2FEJM%3D","updated":"2013-02-08 14:30:07.000000000","message":"Done","commit_id":"32b01f95d7ec82ca0de4511399fbe0088940630d"}]}