)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"b28d5d6bfaa57fadecd141191f1e965396fe7200","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"context_is_admin role is used by nova to check if"},{"line_number":10,"context_line":"the current user is the admin. But it can only check"},{"line_number":11,"context_line":"role rules. The fix allow generic rules in context_is_admin."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ib4823a67fe63d5356fc8c9280a2013b8855f5217"},{"line_number":14,"context_line":"Fixes: bug 1118142"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAM3%2F%2FAio%3D","line":11,"updated":"2013-02-11 19:36:22.000000000","message":"Can you add the docImpact flag here.","commit_id":"2641a53260bbc4a6ffb6de5f7bce8b1d33f2bb4f"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"b28d5d6bfaa57fadecd141191f1e965396fe7200","unresolved":false,"context_lines":[{"line_number":10,"context_line":"the current user is the admin. But it can only check"},{"line_number":11,"context_line":"role rules. The fix allow generic rules in context_is_admin."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ib4823a67fe63d5356fc8c9280a2013b8855f5217"},{"line_number":14,"context_line":"Fixes: bug 1118142"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAM3%2F%2FAis%3D","line":13,"updated":"2013-02-11 19:36:22.000000000","message":"Can you swap these two lines: http://wiki.openstack.org/GitCommitMessages#Summary_of_GIT_commit_message_structure","commit_id":"2641a53260bbc4a6ffb6de5f7bce8b1d33f2bb4f"}],"nova/context.py":[{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"b28d5d6bfaa57fadecd141191f1e965396fe7200","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        self.quota_class \u003d quota_class"},{"line_number":88,"context_line":"        self.user_name \u003d user_name"},{"line_number":89,"context_line":"        self.project_name \u003d project_name"},{"line_number":90,"context_line":"        self.is_admin \u003d is_admin"},{"line_number":91,"context_line":"        if self.is_admin is None:"},{"line_number":92,"context_line":"            self.is_admin \u003d policy.check_is_admin(self)"},{"line_number":93,"context_line":"        if overwrite or not hasattr(local.store, \u0027context\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FAiU%3D","line":90,"updated":"2013-02-11 19:36:22.000000000","message":"Why are these lines moved?","commit_id":"2641a53260bbc4a6ffb6de5f7bce8b1d33f2bb4f"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"f02dd45407cd696e26b73ac8fce9f6ca6c920561","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        self.quota_class \u003d quota_class"},{"line_number":88,"context_line":"        self.user_name \u003d user_name"},{"line_number":89,"context_line":"        self.project_name \u003d project_name"},{"line_number":90,"context_line":"        self.is_admin \u003d is_admin"},{"line_number":91,"context_line":"        if self.is_admin is None:"},{"line_number":92,"context_line":"            self.is_admin \u003d policy.check_is_admin(self)"},{"line_number":93,"context_line":"        if overwrite or not hasattr(local.store, \u0027context\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FAgg%3D","line":90,"in_reply_to":"AAAAM3%2F%2FAg4%3D","updated":"2013-02-11 19:43:57.000000000","message":"Makes Sense","commit_id":"2641a53260bbc4a6ffb6de5f7bce8b1d33f2bb4f"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"0a7781d968a3953ed197141dabff1aebe039e0b4","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        self.quota_class \u003d quota_class"},{"line_number":88,"context_line":"        self.user_name \u003d user_name"},{"line_number":89,"context_line":"        self.project_name \u003d project_name"},{"line_number":90,"context_line":"        self.is_admin \u003d is_admin"},{"line_number":91,"context_line":"        if self.is_admin is None:"},{"line_number":92,"context_line":"            self.is_admin \u003d policy.check_is_admin(self)"},{"line_number":93,"context_line":"        if overwrite or not hasattr(local.store, \u0027context\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FAg4%3D","line":90,"in_reply_to":"AAAAM3%2F%2FAiU%3D","updated":"2013-02-11 19:42:34.000000000","message":"Are you asking about just the is_admin line—which didn\u0027t, strictly speaking, need to be moved—or the policy.check_is_admin()?  If the latter, that\u0027s because check_is_admin() potentially needs access to the other attributes set above, and was the source of the bug.  If the former, I suspect it\u0027s to keep that setting close to the \u0027if\u0027 statement.","commit_id":"2641a53260bbc4a6ffb6de5f7bce8b1d33f2bb4f"}]}