)]}'
{"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"fdc177c70a61b359150ce128d48149a391ce8a41","unresolved":false,"context_lines":[{"line_number":12685,"context_line":"        swap \u003d [objects.BlockDeviceMapping("},{"line_number":12686,"context_line":"                        **fake_block_device.AnonFakeDbBlockDeviceDict("},{"line_number":12687,"context_line":"                            {\u0027device_name\u0027: \u0027vdg\u0027,"},{"line_number":12688,"context_line":"                             \u0027source_type\u0027: \u0027blank\u0027,"},{"line_number":12689,"context_line":"                             \u0027volume_size\u0027: 512,"},{"line_number":12690,"context_line":"                             \u0027guest_format\u0027: \u0027swap\u0027,"},{"line_number":12691,"context_line":"                             \u0027destination_type\u0027: \u0027local\u0027}))]"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a18252c_97bb760e","line":12688,"updated":"2016-04-12 09:54:18.000000000","message":"TBH also, having this kind of different behaviour would need to have a clear unittest.","commit_id":"ea9fb12ec43655489220b36301aec89a5cf86696"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":10224,"name":"Feodor Tersin","email":"ftersin@hotmail.com","username":"ftersin"},"change_message_id":"082cd84a75241beba96cb225f47a6d8a9e3cdf79","unresolved":false,"context_lines":[{"line_number":7142,"context_line":"                LOG.warn(_LW(\"Ignoring supplied device name: %(device_name)s. \""},{"line_number":7143,"context_line":"                             \"Libvirt can\u0027t honour user-supplied dev names\"),"},{"line_number":7144,"context_line":"                         {\u0027device_name\u0027: bdm.device_name}, instance\u003dinstance)"},{"line_number":7145,"context_line":"                if instance.root_device_name \u003d\u003d bdm.device_name:"},{"line_number":7146,"context_line":"                    instance.root_device_name \u003d None"},{"line_number":7147,"context_line":"                bdm.device_name \u003d None"},{"line_number":7148,"context_line":"        block_device_info \u003d driver.get_block_device_info(instance,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_5ee57035","line":7145,"updated":"2015-08-20 14:11:24.000000000","message":"Probably bdm.is_root is better.","commit_id":"cdbba2c063baa778d128d606c6719dfc2195fddd"},{"author":{"_account_id":12408,"name":"Maxim Nestratov","email":"mnestratov@virtuozzo.com","username":"mnestratov"},"change_message_id":"a1a140a1b18f19eac0337bdc704801c4a0f8fa67","unresolved":false,"context_lines":[{"line_number":7142,"context_line":"                LOG.warn(_LW(\"Ignoring supplied device name: %(device_name)s. \""},{"line_number":7143,"context_line":"                             \"Libvirt can\u0027t honour user-supplied dev names\"),"},{"line_number":7144,"context_line":"                         {\u0027device_name\u0027: bdm.device_name}, instance\u003dinstance)"},{"line_number":7145,"context_line":"                if instance.root_device_name \u003d\u003d bdm.device_name:"},{"line_number":7146,"context_line":"                    instance.root_device_name \u003d None"},{"line_number":7147,"context_line":"                bdm.device_name \u003d None"},{"line_number":7148,"context_line":"        block_device_info \u003d driver.get_block_device_info(instance,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_94df6768","line":7145,"in_reply_to":"fa1b9901_5ee57035","updated":"2015-08-20 14:35:21.000000000","message":"agree","commit_id":"cdbba2c063baa778d128d606c6719dfc2195fddd"},{"author":{"_account_id":10224,"name":"Feodor Tersin","email":"ftersin@hotmail.com","username":"ftersin"},"change_message_id":"082cd84a75241beba96cb225f47a6d8a9e3cdf79","unresolved":false,"context_lines":[{"line_number":7153,"context_line":"                                       instance,"},{"line_number":7154,"context_line":"                                       block_device_info,"},{"line_number":7155,"context_line":"                                       image_meta)"},{"line_number":7156,"context_line":""},{"line_number":7157,"context_line":"    def get_device_name_for_instance(self, instance, bdms, block_device_obj):"},{"line_number":7158,"context_line":"        image_meta \u003d utils.get_image_from_system_metadata("},{"line_number":7159,"context_line":"            instance.system_metadata)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_de32e05d","line":7156,"updated":"2015-08-20 14:11:24.000000000","message":"Since this function is called from manager\u0027s _default_block_device_names, which seems to be intended to align instance.root_device_name with a root bdm.device_name, i think we should finish the alignment here. I.e. set instance.root_device_name to a result value of a root device name.","commit_id":"cdbba2c063baa778d128d606c6719dfc2195fddd"},{"author":{"_account_id":12408,"name":"Maxim Nestratov","email":"mnestratov@virtuozzo.com","username":"mnestratov"},"change_message_id":"a1a140a1b18f19eac0337bdc704801c4a0f8fa67","unresolved":false,"context_lines":[{"line_number":7153,"context_line":"                                       instance,"},{"line_number":7154,"context_line":"                                       block_device_info,"},{"line_number":7155,"context_line":"                                       image_meta)"},{"line_number":7156,"context_line":""},{"line_number":7157,"context_line":"    def get_device_name_for_instance(self, instance, bdms, block_device_obj):"},{"line_number":7158,"context_line":"        image_meta \u003d utils.get_image_from_system_metadata("},{"line_number":7159,"context_line":"            instance.system_metadata)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_347bfb8d","line":7156,"in_reply_to":"fa1b9901_de32e05d","updated":"2015-08-20 14:35:21.000000000","message":"Makes sense.","commit_id":"cdbba2c063baa778d128d606c6719dfc2195fddd"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"fdc177c70a61b359150ce128d48149a391ce8a41","unresolved":false,"context_lines":[{"line_number":7734,"context_line":"                        \"Libvirt can\u0027t honour user-supplied dev names\"),"},{"line_number":7735,"context_line":"                    {\u0027device_name\u0027: bdm.device_name}, instance\u003dinstance)"},{"line_number":7736,"context_line":"                if instance.root_device_name \u003d\u003d bdm.device_name:"},{"line_number":7737,"context_line":"                    instance.root_device_name \u003d None"},{"line_number":7738,"context_line":"                bdm.device_name \u003d None"},{"line_number":7739,"context_line":"        block_device_info \u003d driver.get_block_device_info(instance,"},{"line_number":7740,"context_line":"                                                         block_device_mapping)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a18252c_b7e7923f","line":7737,"updated":"2016-04-12 09:54:18.000000000","message":"Well, I\u0027m not super happy to see that here because it means that different drivers could have different behaviours.\n\nI know that the provided root_device_name is a lot of times not really good, but I wonder if we shouldn\u0027t rather set a clear distinction out of the drivers modules and rather in the compute API.\n\nAnyway, since the instance change is not persisted, it would mean that nullify it here would not be persisted (and probably being a problem for move operations later).","commit_id":"ea9fb12ec43655489220b36301aec89a5cf86696"}]}