)]}'
{"nova/virt/libvirt/blockinfo.py":[{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"b1f0bd5f09766dda98a3f6079f64ece6195059e0","unresolved":false,"context_lines":[{"line_number":182,"context_line":"        return None"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    if assigned_devices is None:"},{"line_number":185,"context_line":"        assigned_devices \u003d []"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    max_dev \u003d get_dev_count_for_disk_bus(bus)"},{"line_number":188,"context_line":"    if last_device:"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_ea332a60","line":185,"updated":"2015-09-01 07:10:32.000000000","message":"why not set [] as the default value of assigned_devices in line 167","commit_id":"c1715485f9a636913562e3c93cd9e38a3a98cb8b"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"5363445f8cd06c99bf5bf8269fc1c448b846e119","unresolved":false,"context_lines":[{"line_number":182,"context_line":"        return None"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    if assigned_devices is None:"},{"line_number":185,"context_line":"        assigned_devices \u003d []"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    max_dev \u003d get_dev_count_for_disk_bus(bus)"},{"line_number":188,"context_line":"    if last_device:"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_8599417b","line":185,"in_reply_to":"da20952f_654aed56","updated":"2015-09-01 07:31:42.000000000","message":"gocha, thanks","commit_id":"c1715485f9a636913562e3c93cd9e38a3a98cb8b"},{"author":{"_account_id":13790,"name":"Zhenzan Zhou","email":"linuxosa@gmail.com","username":"zhenzanzhou"},"change_message_id":"d5ff1c7b7530af65cce0fc013553e07dc2fe44f0","unresolved":false,"context_lines":[{"line_number":182,"context_line":"        return None"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    if assigned_devices is None:"},{"line_number":185,"context_line":"        assigned_devices \u003d []"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    max_dev \u003d get_dev_count_for_disk_bus(bus)"},{"line_number":188,"context_line":"    if last_device:"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_654aed56","line":185,"in_reply_to":"da20952f_ea332a60","updated":"2015-09-01 07:21:19.000000000","message":"We should not use mutable default arguments. Please refer to\nhttps://pythonconquerstheuniverse.wordpress.com/2012/02/15/mutable-default-arguments/","commit_id":"c1715485f9a636913562e3c93cd9e38a3a98cb8b"}]}