)]}'
{"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"139239c969ca2f923510ed5f9e7e8b712965aece","unresolved":false,"context_lines":[{"line_number":5796,"context_line":"                block_migration\u003dTrue,"},{"line_number":5797,"context_line":"                block_device_info\u003dbdi)"},{"line_number":5798,"context_line":""},{"line_number":5799,"context_line":"        self.mox.StubOutWithMock(drvr, \"_assert_dest_node_has_enough_disk\")"},{"line_number":5800,"context_line":"        drvr._assert_dest_node_has_enough_disk("},{"line_number":5801,"context_line":"            self.context, instance, dest_check_data[\u0027disk_available_mb\u0027],"},{"line_number":5802,"context_line":"            False, bdi)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba15a1d1_6f47c04b","line":5799,"updated":"2015-09-15 14:54:01.000000000","message":"The new tests really need to use mock not mox.\n\nI would not normally block on this, except this is replacing a test that used mock.","commit_id":"85a3fa94cc8adecb0cacc9a4e2d021dce1ab92f0"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"a37e9f084e3979d18c26697c12665c51b29413af","unresolved":false,"context_lines":[{"line_number":5796,"context_line":"                block_migration\u003dTrue,"},{"line_number":5797,"context_line":"                block_device_info\u003dbdi)"},{"line_number":5798,"context_line":""},{"line_number":5799,"context_line":"        self.mox.StubOutWithMock(drvr, \"_assert_dest_node_has_enough_disk\")"},{"line_number":5800,"context_line":"        drvr._assert_dest_node_has_enough_disk("},{"line_number":5801,"context_line":"            self.context, instance, dest_check_data[\u0027disk_available_mb\u0027],"},{"line_number":5802,"context_line":"            False, bdi)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba15a1d1_d4820694","line":5799,"in_reply_to":"ba15a1d1_6f47c04b","updated":"2015-09-16 00:54:17.000000000","message":"hi John, thank you! agreed.","commit_id":"85a3fa94cc8adecb0cacc9a4e2d021dce1ab92f0"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"eae0a2a120e633d7fd17009be1e6281de19226f5","unresolved":false,"context_lines":[{"line_number":5235,"context_line":"                                    block_device_info)"},{"line_number":5236,"context_line":"            if block_device_info:"},{"line_number":5237,"context_line":"                bdm \u003d block_device_info.get(\u0027block_device_mapping\u0027)"},{"line_number":5238,"context_line":"                if bdm and len(bdm):"},{"line_number":5239,"context_line":"                    LOG.error(_LE(\u0027Cannot block migrate instance %s with \u0027"},{"line_number":5240,"context_line":"                                  \u0027mapped volumes\u0027),"},{"line_number":5241,"context_line":"                              instance.uuid, instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_2c6e9d96","line":5238,"updated":"2015-08-25 08:35:06.000000000","message":"This can include details of local disks, like swap disk. I am not sure this actually does the check you mean it does.\n\nIs this true for all storage backends and volume driver combinations?","commit_id":"389054b389e02dad6f7c602bbb9e6c6e24613263"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"36df9605f4e6561508176e706be23c2cc18b9bc7","unresolved":false,"context_lines":[{"line_number":5235,"context_line":"                                    block_device_info)"},{"line_number":5236,"context_line":"            if block_device_info:"},{"line_number":5237,"context_line":"                bdm \u003d block_device_info.get(\u0027block_device_mapping\u0027)"},{"line_number":5238,"context_line":"                if bdm and len(bdm):"},{"line_number":5239,"context_line":"                    LOG.error(_LE(\u0027Cannot block migrate instance %s with \u0027"},{"line_number":5240,"context_line":"                                  \u0027mapped volumes\u0027),"},{"line_number":5241,"context_line":"                              instance.uuid, instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_8c4a4982","line":5238,"in_reply_to":"fa1b9901_2c6e9d96","updated":"2015-08-25 08:48:25.000000000","message":"hi john, I think this is correct, the bdm is from bdi, this will not including swap and local disk.","commit_id":"389054b389e02dad6f7c602bbb9e6c6e24613263"}]}