)]}'
{"nova/network/linux_net.py":[{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"c775e371b4e24b847d9addc7e3b14688f847af6e","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    cfg.BoolOpt(\u0027use_network_dns_servers\u0027,"},{"line_number":69,"context_line":"                default\u003dFalse,"},{"line_number":70,"context_line":"                help\u003d\u0027if set, uses the dns1 and dns2 from the network ref.\u0027"},{"line_number":71,"context_line":"                     \u0027as dns servers.\u0027),"},{"line_number":72,"context_line":"    cfg.ListOpt(\u0027dmz_cidr\u0027,"},{"line_number":73,"context_line":"               default\u003d[],"},{"line_number":74,"context_line":"               help\u003d\u0027A list of dmz range that should be accepted\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2B7ws%3D","line":71,"updated":"2013-02-13 23:17:13.000000000","message":"The help text could be improved here a bit.  I\u0027m not sure that \"network ref\" is something that would make sense to users or not ...\n\nnot worth a -1 though","commit_id":"43ee5a9763b2239168f510255e282f5eea19248f"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"2c7afce3134419bc5483f92d503ea49f5372087e","unresolved":false,"context_lines":[{"line_number":973,"context_line":"            dns_servers.add(network_ref.get(\u0027dns1\u0027))"},{"line_number":974,"context_line":"        if network_ref.get(\u0027dns2\u0027):"},{"line_number":975,"context_line":"            dns_servers.add(network_ref.get(\u0027dns2\u0027))"},{"line_number":976,"context_line":"    if network_ref[\u0027multi_host\u0027] or dns_servers:"},{"line_number":977,"context_line":"        cmd.append(\u0027--no-hosts\u0027)"},{"line_number":978,"context_line":"    if network_ref[\u0027multi_host\u0027]:"},{"line_number":979,"context_line":"        \u0027--addn-hosts\u003d%s\u0027 % _dhcp_file(dev, \u0027hosts\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FAXY%3D","line":976,"updated":"2013-02-11 21:05:06.000000000","message":"Is the flipped logic, \u0027or\u0027 vs \u0027and not\u0027 desired?  Nothing in this change or the commit message help me understand why this flipped.","commit_id":"43ee5a9763b2239168f510255e282f5eea19248f"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"917c04d60b8f6fac7fb10662089a1f8942f529f1","unresolved":false,"context_lines":[{"line_number":973,"context_line":"            dns_servers.add(network_ref.get(\u0027dns1\u0027))"},{"line_number":974,"context_line":"        if network_ref.get(\u0027dns2\u0027):"},{"line_number":975,"context_line":"            dns_servers.add(network_ref.get(\u0027dns2\u0027))"},{"line_number":976,"context_line":"    if network_ref[\u0027multi_host\u0027] or dns_servers:"},{"line_number":977,"context_line":"        cmd.append(\u0027--no-hosts\u0027)"},{"line_number":978,"context_line":"    if network_ref[\u0027multi_host\u0027]:"},{"line_number":979,"context_line":"        \u0027--addn-hosts\u003d%s\u0027 % _dhcp_file(dev, \u0027hosts\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2B83o%3D","line":976,"in_reply_to":"AAAAM3%2F%2B%2BtE%3D","updated":"2013-02-13 14:26:15.000000000","message":"Gotcha, thanks for the explanation.","commit_id":"43ee5a9763b2239168f510255e282f5eea19248f"},{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"ca22b4a1952b86725724b67b316b2d60e384cabd","unresolved":false,"context_lines":[{"line_number":973,"context_line":"            dns_servers.add(network_ref.get(\u0027dns1\u0027))"},{"line_number":974,"context_line":"        if network_ref.get(\u0027dns2\u0027):"},{"line_number":975,"context_line":"            dns_servers.add(network_ref.get(\u0027dns2\u0027))"},{"line_number":976,"context_line":"    if network_ref[\u0027multi_host\u0027] or dns_servers:"},{"line_number":977,"context_line":"        cmd.append(\u0027--no-hosts\u0027)"},{"line_number":978,"context_line":"    if network_ref[\u0027multi_host\u0027]:"},{"line_number":979,"context_line":"        \u0027--addn-hosts\u003d%s\u0027 % _dhcp_file(dev, \u0027hosts\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2B%2BtE%3D","line":976,"in_reply_to":"AAAAM3%2F%2FAXY%3D","updated":"2013-02-12 16:53:27.000000000","message":"--no-hosts is the same as -h\n\nso --no_hosts was being set in both cases originally.\n\nthe code below adds an additional hosts file for resolving instance names on other hosts, and it only works if it is explicitly configured to be generated via update_dns_entries and/or dns_update_periodic_interval, so there is no reason to disable it when we are using a dns_server.","commit_id":"43ee5a9763b2239168f510255e282f5eea19248f"}]}