)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"ea3851b0107365d654087a18ca71f90f256dbaa0","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Claudiu Belu \u003ccbelu@cloudbasesolutions.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-09-07 03:36:25 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Hyper-V: Fixes snapshoting inexistent VM issue"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Instance destroy and Instance snapshot are locking operations, meaning"},{"line_number":10,"context_line":"that they can only occur sequentially. This is the result of the commit"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"ba15a1d1_dce9bde7","line":7,"updated":"2015-09-16 11:37:57.000000000","message":"inexistent \u003d\u003e existent","commit_id":"0d0e1cd0a1248076972bfc5ea310a535c11ef796"}],"nova/utils.py":[{"author":{"_account_id":12604,"name":"Adelina Tuvenie","email":"atuvenie@cloudbasesolutions.com","username":"atuvenie"},"change_message_id":"7cc1f92e445619ebbab365c2796ba8fa4b441613","unresolved":false,"context_lines":[{"line_number":128,"context_line":"    cfg.BoolOpt(\u0027handle_snapshot_missing_instance\u0027,"},{"line_number":129,"context_line":"                default\u003dTrue,"},{"line_number":130,"context_line":"                help\u003d\"Tempest snapshot API tests creates instances snapshots \""},{"line_number":131,"context_line":"                     \"them and destroyed them, even if the snapshot operation \""},{"line_number":132,"context_line":"                     \"did not complete. This can cause Hyper-V CI to snapshot \""},{"line_number":133,"context_line":"                     \"an instance that doesn\u0027t exist anymore. This config \""},{"line_number":134,"context_line":"                     \"option is not meant for production. See \""}],"source_content_type":"text/x-python","patch_set":6,"id":"fa1b9901_9f7382b4","line":131,"updated":"2015-08-24 10:45:34.000000000","message":"\u0027,\u0027 between \"creates instances\" and \"snapshots them\". Also s/destroyed/destroys","commit_id":"b667d3994efaa11c49e5356b7fc6f40e2db5bf4a"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"93140fbdc974e71c7affeba5957d6445237f353f","unresolved":false,"context_lines":[{"line_number":128,"context_line":"    cfg.BoolOpt(\u0027handle_snapshot_missing_instance\u0027,"},{"line_number":129,"context_line":"                default\u003dTrue,"},{"line_number":130,"context_line":"                help\u003d\"Tempest snapshot API tests creates instances snapshots \""},{"line_number":131,"context_line":"                     \"them and destroyed them, even if the snapshot operation \""},{"line_number":132,"context_line":"                     \"did not complete. This can cause Hyper-V CI to snapshot \""},{"line_number":133,"context_line":"                     \"an instance that doesn\u0027t exist anymore. This config \""},{"line_number":134,"context_line":"                     \"option is not meant for production. See \""}],"source_content_type":"text/x-python","patch_set":6,"id":"fa1b9901_5f43aa6c","line":131,"in_reply_to":"fa1b9901_9f7382b4","updated":"2015-08-24 10:48:48.000000000","message":"Done","commit_id":"b667d3994efaa11c49e5356b7fc6f40e2db5bf4a"}],"nova/virt/hyperv/snapshotops.py":[{"author":{"_account_id":12604,"name":"Adelina Tuvenie","email":"atuvenie@cloudbasesolutions.com","username":"atuvenie"},"change_message_id":"1fbcaf238c757c46a1a81dff592d7405efc1a27e","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        # While the snapshot operation is not synchronized within the manager,"},{"line_number":52,"context_line":"        # attempting to destroy an instance while it\u0027s being snapshoted fails."},{"line_number":53,"context_line":"        LOG.debug(\"Obtaining lock for snapshot.\", instance\u003dinstance)"},{"line_number":54,"context_line":"        @utils.synchronized(instance.uuid)"},{"line_number":55,"context_line":"        def instance_synchronized_snapshot():"},{"line_number":56,"context_line":"            self._snapshot(context, instance, image_id, update_task_state)"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_53a3694f","line":54,"updated":"2015-08-19 12:52:56.000000000","message":"Missing blank line here that causes pep8 to fail.","commit_id":"b6156812ca5bb15d09c4fdfe16bd5aa94a09a61f"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"e60a9392f29b0f0143edfeb771c49164114304b0","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        # check if the instance exists for snapshot."},{"line_number":70,"context_line":"        if not self._vmutils.vm_exists(instance_name):"},{"line_number":71,"context_line":"            # the VM was destroyed before the snapshot operation."},{"line_number":72,"context_line":"            if CONF.workarounds.handle_snapshot_missing_instance:"},{"line_number":73,"context_line":"                raise exception.InstanceNotFound(instance_id\u003dinstance.uuid)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"            LOG.warning(_LW(\"VM does not exist anymore, it might have been \""}],"source_content_type":"text/x-python","patch_set":9,"id":"fa1b9901_fc5721c8","line":72,"updated":"2015-08-24 14:19:51.000000000","message":"do we really need this?","commit_id":"46d808ff2f0487180124d2f65b33545597b88cc1"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"b9a6b94f1e9cddd7e4188b379d607efd633f74b1","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        # check if the instance exists for snapshot."},{"line_number":70,"context_line":"        if not self._vmutils.vm_exists(instance_name):"},{"line_number":71,"context_line":"            # the VM was destroyed before the snapshot operation."},{"line_number":72,"context_line":"            if CONF.workarounds.handle_snapshot_missing_instance:"},{"line_number":73,"context_line":"                raise exception.InstanceNotFound(instance_id\u003dinstance.uuid)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"            LOG.warning(_LW(\"VM does not exist anymore, it might have been \""}],"source_content_type":"text/x-python","patch_set":9,"id":"fa1b9901_3f0588c1","line":72,"in_reply_to":"fa1b9901_fc5721c8","updated":"2015-08-24 15:10:09.000000000","message":"so, the idea is to have CONF.workarounds.handle_snapshot_missing_instance to False in the Hyper-V CI, where we encounter this issue over and over again.\n\nFor production puroposes, this conf option will be set to True, as it is default. The exception should be raised if not found.","commit_id":"46d808ff2f0487180124d2f65b33545597b88cc1"}]}