)]}'
{"nova/compute/monitors/base.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7fc08f109a5090c71badff5a6e28596973c8da9e","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        self.source \u003d None"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    @abc.abstractmethod"},{"line_number":30,"context_line":"    def populate_metric_object(self, name, metric_object):"},{"line_number":31,"context_line":"        \"\"\"Returns the metric object for the supplied metric name."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"        :param name: The name/key for the metric to grab the value for"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_a1c9865c","line":30,"updated":"2015-09-09 14:20:29.000000000","message":"Missing a docstring param for metric_object.","commit_id":"10aeb604ea78a465a9fe4e5a3a2695f8c28d2385"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7fc08f109a5090c71badff5a6e28596973c8da9e","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"        :param name: The name/key for the metric to grab the value for"},{"line_number":34,"context_line":"                     and the metric object to populate."},{"line_number":35,"context_line":"        \"\"\""},{"line_number":36,"context_line":"        raise NotImplementedError(\u0027populate_metric_object\u0027)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    @abc.abstractmethod"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_81bec2ac","line":35,"updated":"2015-09-09 14:20:29.000000000","message":"Is this method supposed to return something?  If so, add a returns docstring explaining that.  Else you could just modify the metric_object by reference.","commit_id":"10aeb604ea78a465a9fe4e5a3a2695f8c28d2385"}],"nova/compute/monitors/cpu/virt_driver.py":[{"author":{"_account_id":9775,"name":"Sudipta Biswas","email":"sbiswas7@in.ibm.com","username":"sudswas"},"change_message_id":"f50900ad0eff8c87414414c0f0fb52a07fbaec91","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        self._data \u003d {}"},{"line_number":41,"context_line":"        self._cpu_stats \u003d {}"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def populate_metric_object(self, name, metric_object):"},{"line_number":44,"context_line":"        self._update_data()"},{"line_number":45,"context_line":"        metric_object.name \u003d name"},{"line_number":46,"context_line":"        metric_object.value \u003d self._data[name]"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_6d88b6c5","line":43,"updated":"2015-08-20 19:38:42.000000000","message":"Does passing the metric_object give us any advantage over instantiating the the same inside this method?","commit_id":"ce68f7be7473a7f1286863e05aaf1ff78be5adf5"}]}