)]}'
{"id":"openstack%2Fnova~214773","triplet_id":"openstack%2Fnova~stable%2Fkilo~Ia3ca5a18c79d62b71b9c042a612d12dd074b245e","project":"openstack/nova","branch":"stable/kilo","topic":"bug/1369627","hashtags":[],"change_id":"Ia3ca5a18c79d62b71b9c042a612d12dd074b245e","subject":"Handle config drives being stored on rbd","status":"ABANDONED","created":"2015-08-19 19:36:25.000000000","updated":"2015-09-07 14:18:30.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"057fc6359110ea54165693be79f2f1a167ee5ca0","_number":214773,"virtual_id_number":214773,"owner":{"_account_id":986,"name":"Rosario Di Somma","email":"rosario.disomma@gmail.com","username":"mr-rods"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"date":"2015-08-24 21:59:54.000000000","_account_id":986,"name":"Rosario Di Somma","email":"rosario.disomma@gmail.com","username":"mr-rods"},{"value":0,"date":"2015-08-19 20:23:46.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":1,"date":"2015-08-19 22:31:13.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"all":[{"value":-1,"date":"2015-08-19 20:27:43.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},{"value":-1,"date":"2015-08-31 23:07:11.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":986,"name":"Rosario Di Somma","email":"rosario.disomma@gmail.com","username":"mr-rods"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"date":"2015-08-19 19:36:26.000000000","_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":986,"name":"Rosario Di Somma","email":"rosario.disomma@gmail.com","username":"mr-rods"},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":986,"name":"Rosario Di Somma","email":"rosario.disomma@gmail.com","username":"mr-rods"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":986,"name":"Rosario Di Somma","email":"rosario.disomma@gmail.com","username":"mr-rods"},{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-08-19 19:36:26.000000000","updated_by":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"reviewer":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"state":"REVIEWER"},{"updated":"2015-08-19 20:23:46.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2015-08-19 22:31:13.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2015-08-31 23:07:11.000000000","updated_by":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"reviewer":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"state":"REVIEWER"}],"messages":[{"id":"bb19ac02b3be4224641dca8936b8207898be3eb5","author":{"_account_id":986,"name":"Rosario Di Somma","email":"rosario.disomma@gmail.com","username":"mr-rods"},"date":"2015-08-19 19:36:25.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"99646cae099f79612fd865971ec2558c971bb319","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2015-08-19 20:23:46.000000000","message":"Patch Set 1:\n\nTesting completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm-recheck. Contact info: kvmpower@linux.vnet.ibm.com. For more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- check-ibm-tempest-dsvm-full http://dal05.objectstorage.softlayer.net/v1/AUTH_3d8e6ecb-f597-448c-8ec2-164e9f710dd6/pkvmci/214773/1/check-ibm-tempest-dsvm-full/4607a9b : SUCCESS in 45m 11s (non-voting)\n- check-ibm-tempest-dsvm-postgres-full http://dal05.objectstorage.softlayer.net/v1/AUTH_3d8e6ecb-f597-448c-8ec2-164e9f710dd6/pkvmci/214773/1/check-ibm-tempest-dsvm-postgres-full/2a02342 : SUCCESS in 43m 38s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"59c1f938ad741178d12855c6048abd0ed8739b10","author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"date":"2015-08-19 20:27:43.000000000","message":"Patch Set 1: Code-Review-1\n\nIsn\u0027t this a feature and therefore not eligible for a backport?","accounts_in_message":[],"_revision_number":1},{"id":"9179cb5c46e45f8f103f67fffe44346ccde62edf","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-19 22:31:13.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-nova-pep8 http://logs.openstack.org/73/214773/1/check/gate-nova-pep8/e366d98/ : SUCCESS in 9m 34s\n- gate-nova-docs http://docs-draft.openstack.org/73/214773/1/check/gate-nova-docs/ee692e3//doc/build/html/ : SUCCESS in 8m 19s\n- gate-nova-python27 http://logs.openstack.org/73/214773/1/check/gate-nova-python27/fff29b5/ : SUCCESS in 12m 17s\n- gate-tempest-dsvm-full http://logs.openstack.org/73/214773/1/check/gate-tempest-dsvm-full/18fdc4b/ : SUCCESS in 51m 15s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/73/214773/1/check/gate-tempest-dsvm-postgres-full/de516d1/ : SUCCESS in 50m 29s\n- gate-tempest-dsvm-neutron-full http://logs.openstack.org/73/214773/1/check/gate-tempest-dsvm-neutron-full/252c1c9/ : SUCCESS in 1h 03m 49s\n- gate-grenade-dsvm http://logs.openstack.org/73/214773/1/check/gate-grenade-dsvm/6966706/ : SUCCESS in 46m 24s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/73/214773/1/check/gate-tempest-dsvm-large-ops/1bf2218/ : SUCCESS in 20m 15s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/73/214773/1/check/gate-tempest-dsvm-neutron-large-ops/c567b20/ : SUCCESS in 19m 13s\n- gate-devstack-dsvm-cells http://logs.openstack.org/73/214773/1/check/gate-devstack-dsvm-cells/fccf2a5/ : SUCCESS in 24m 44s\n- gate-nova-tox-functional http://logs.openstack.org/73/214773/1/check/gate-nova-tox-functional/6442e71/ : SUCCESS in 10m 30s\n- gate-grenade-dsvm-partial-ncpu http://logs.openstack.org/73/214773/1/check/gate-grenade-dsvm-partial-ncpu/cc88c31/ : SUCCESS in 48m 06s\n- gate-tempest-dsvm-ironic-pxe_ssh http://logs.openstack.org/73/214773/1/check/gate-tempest-dsvm-ironic-pxe_ssh/571e6d1/ : SUCCESS in 28m 03s\n- gate-tempest-dsvm-nova-v21-full http://logs.openstack.org/73/214773/1/check/gate-tempest-dsvm-nova-v21-full/161989a/ : SUCCESS in 37m 56s\n- gate-tempest-dsvm-full-ceph http://logs.openstack.org/73/214773/1/check/gate-tempest-dsvm-full-ceph/43f6f62/ : SUCCESS in 37m 59s\n- gate-tempest-dsvm-multinode-full http://logs.openstack.org/73/214773/1/check/gate-tempest-dsvm-multinode-full/647e892/ : SUCCESS in 40m 50s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"78d426b255e121d5188e8ccf4962b7785d6679a8","author":{"_account_id":986,"name":"Rosario Di Somma","email":"rosario.disomma@gmail.com","username":"mr-rods"},"date":"2015-08-24 21:59:54.000000000","message":"Patch Set 1:\n\nHi Michael, thanks for your comment. \nI wouldn’t say that is a feature, without going too much into details, in many cases live migration with shared storage is the only reasonable way to go. The driver doesn’t work as advertised, it fails in a very common configuration and that’s a bug. At DreamHost we use this patch in production (juno) and we’ll continue to use it when we’ll update to kilo but dragging patches for bugs adds to tech debt (which is already high.)\n\nThe bugs that the patch fixes in master were opened 11 months ago (juno). There is a fair chance that someone is facing this bug right now and is in the process to switch to kilo: they will still have to wait a long time before they can get a working driver. I’m pretty sure they will consider this a bug and would be happy to see the backport to kilo merged.\n\nWe build our own packages so it isn’t a big deal for us to patch nova, but I’d like to take a second to speak for all those small openstack deployments that are part of our community and that don’t have the energy to build their own packages or just expect things to work as advertised. They completely rely on the work of the community so a decision not to backport a simple fix like this one will impact operators for another six/nine months.","accounts_in_message":[],"_revision_number":1},{"id":"437dc83289ffc45f107fb588fa2fa3e4b4762fe0","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2015-08-31 23:07:11.000000000","message":"Patch Set 1: Code-Review-1\n\nFrom the reverts it looks like ceph + config drive support wasn\u0027t in kilo given it was all reverted out.  That\u0027s unfortunate but I don\u0027t think we should add that support back in via a backport to a stable branch.\n\nWe know that live migration using block migration works in kilo given we have the multinode job that was passing for it.\n\nI\u0027m also uneasy about the size of this change, which means there could be latent bugs which are just aren\u0027t hitting and then exposes us on stable.\n\nI think if people want to use live migration + ceph in kilo they could pull this down and run with it until they upgrade to liberty - that\u0027s not really new.  It sucks for those that need it, but it also sucks for people when we backport things for one group and break things for another because we were unsure of ourselves.","accounts_in_message":[],"_revision_number":1},{"id":"9bfb585adfba31f209d6b5738eba20a6fae46f67","author":{"_account_id":986,"name":"Rosario Di Somma","email":"rosario.disomma@gmail.com","username":"mr-rods"},"date":"2015-09-07 14:18:30.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"d8d009399edcbd66e3aba44be0fa3c55abc4fe5d","revisions":{"d8d009399edcbd66e3aba44be0fa3c55abc4fe5d":{"kind":"REWORK","_number":1,"created":"2015-08-19 19:36:25.000000000","uploader":{"_account_id":986,"name":"Rosario Di Somma","email":"rosario.disomma@gmail.com","username":"mr-rods"},"ref":"refs/changes/73/214773/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/73/214773/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/73/214773/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/73/214773/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/73/214773/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/73/214773/1"}}},"commit":{"parents":[{"commit":"dd29ea542137d26d4a207fe45e39cef9e712539f","subject":"Merge \"Fix rebuild of an instance with a volume attached\" into stable/kilo","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/dd29ea542137d26d4a207fe45e39cef9e712539f"}]}],"author":{"name":"Michael Still","email":"mikal@stillhq.com","date":"2014-11-25 12:42:47.000000000","tz":180},"committer":{"name":"Rosario Di Somma","email":"rosario.disomma@dreamhost.com","date":"2015-08-19 19:35:34.000000000","tz":-420},"subject":"Handle config drives being stored on rbd","message":"Handle config drives being stored on rbd\n\nrbd is the only example of a currently supported image storage\nbackend where it makes sense to put the config drive in the\nconfigured storage backend instead of local hypervisor disk. I\ndon\u0027t think this makes sense for LVM, where we would be creating\na LV for a tens of megabytes file, which seems like overkill to\nme. The other storage backends use local disk for their data\nalready.\n\nThis use case was covered by the now reverted changes:\n  228d0221763b12f11ecbacde4db38b1151f96e31\n  0b01e846d40f3b343da9ebe1dae89cca8bc2ac66\n  ecce888c469c62374a3cc43e3cede11d8aa1e799\n\nSupport this special case by moving the image to rbd once it has\nbeen created in the local instance directory on the hypervisor.\n\nI\u0027ve tested this change in devstack and it works.\n\nRelated-bug: #1369627\nRelated-bug: #1361840\nRelated-bug: #1246201\n\nCo-Authored-By: Mehdi Abaakouk \u003csileht@redhat.com\u003e\nCo-Authored-By: Dan Smith \u003cdms@danplanet.com\u003e\n\nNote: Unexpectedly the cherry-pick was bringing in some code\n(specifically the `get_model` method) and the related tests which\nbelong to a completely different commit[1] and were causing the\nconflicts reported below. That code has been removed manually.\n\n[1] https://github.com/openstack/nova/commit/c9ad95448937076a354f56483acef0e8dc33fb05\n\nCherry-pick from https://review.openstack.org/#/c/123073\nConflicts:\n\tnova/tests/unit/virt/libvirt/test_imagebackend.py\n\tnova/virt/libvirt/imagebackend.py\n\nChange-Id: Ia3ca5a18c79d62b71b9c042a612d12dd074b245e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/d8d009399edcbd66e3aba44be0fa3c55abc4fe5d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/d8d009399edcbd66e3aba44be0fa3c55abc4fe5d"}]},"parents_data":[{"branch_name":"refs/heads/stable/kilo","commit_id":"dd29ea542137d26d4a207fe45e39cef9e712539f","is_merged_in_target_branch":false}],"branch":"refs/heads/stable/kilo"}},"requirements":[],"submit_records":[],"submit_requirements":[]}