)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},"change_message_id":"1fd1ba57ae9b404ec6ce1932374d137399adcc45","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add status and instance_uuid to bm_deployments"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add \u0027status\u0027 and \u0027instance_uuid\u0027 columns to bm_deployments."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"This patch changes the behaviour of bm_deployments: they are no"},{"line_number":12,"context_line":"longer deleted immediately after completion. Instead, a deployment is"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAAM3%2F%2FCtU%3D","line":9,"updated":"2013-02-09 16:32:56.000000000","message":"Also the FK bm_node_id","commit_id":"96f2ce3fc24e6ccb69d034f9234a5690a2dbb2a8"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"975420d1775d8e975ac22d4ed0b9d49970d075d3","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add status and instance_uuid to bm_deployments"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add \u0027status\u0027 and \u0027instance_uuid\u0027 columns to bm_deployments."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"This patch changes the behaviour of bm_deployments: they are no"},{"line_number":12,"context_line":"longer deleted immediately after completion. Instead, a deployment is"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAAM3%2F%2FCJ8%3D","line":9,"in_reply_to":"AAAAM3%2F%2FCtU%3D","updated":"2013-02-10 17:04:25.000000000","message":"Done","commit_id":"96f2ce3fc24e6ccb69d034f9234a5690a2dbb2a8"}],"bin/nova-baremetal-deploy-helper":[{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"8c954399436ebaa69aa7a571c5c5012b61c84070","unresolved":false,"context_lines":[{"line_number":242,"context_line":"            else:"},{"line_number":243,"context_line":"                # Requests comes here from BareMetalDeploy.post()"},{"line_number":244,"context_line":"                LOG.info(_(\u0027start deployment for node %(node_id)s, \u0027"},{"line_number":245,"context_line":"                           \u0027params %(params)s\u0027) % locals())"},{"line_number":246,"context_line":"                context \u003d nova_context.get_admin_context()"},{"line_number":247,"context_line":"                try:"},{"line_number":248,"context_line":"                    db.bm_node_update(context, node_id,"}],"source_content_type":"application/octet-stream","patch_set":17,"id":"AAAAM3%2F%2BwSM%3D","line":245,"updated":"2013-02-19 22:28:21.000000000","message":"locals() is evil. Please feel guilt.","commit_id":"47920c9bd3a676587817cabf2cbfca0de0ae6893"}],"nova/tests/baremetal/test_nova_baremetal_deploy_helper.py":[{"author":{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},"change_message_id":"1fd1ba57ae9b404ec6ce1932374d137399adcc45","unresolved":false,"context_lines":[{"line_number":17,"context_line":"#    under the License."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import imp"},{"line_number":20,"context_line":"import mox"},{"line_number":21,"context_line":"import os"},{"line_number":22,"context_line":"import sys"},{"line_number":23,"context_line":"import tempfile"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FCtY%3D","line":20,"updated":"2013-02-09 16:32:56.000000000","message":"mox should be down a section","commit_id":"96f2ce3fc24e6ccb69d034f9234a5690a2dbb2a8"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"975420d1775d8e975ac22d4ed0b9d49970d075d3","unresolved":false,"context_lines":[{"line_number":17,"context_line":"#    under the License."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import imp"},{"line_number":20,"context_line":"import mox"},{"line_number":21,"context_line":"import os"},{"line_number":22,"context_line":"import sys"},{"line_number":23,"context_line":"import tempfile"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FCJ4%3D","line":20,"in_reply_to":"AAAAM3%2F%2FCtY%3D","updated":"2013-02-10 17:04:25.000000000","message":"Done","commit_id":"96f2ce3fc24e6ccb69d034f9234a5690a2dbb2a8"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"c2a29b9117cd798ffdce9e8465f698f40a1f5323","unresolved":false,"context_lines":[{"line_number":22,"context_line":"import tempfile"},{"line_number":23,"context_line":"import time"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"import mox"},{"line_number":26,"context_line":"from nova import test"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"from nova.tests.baremetal.db import base as bm_db_base"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAM3%2F%2B7Zs%3D","line":25,"updated":"2013-02-14 03:30:43.000000000","message":"PEP8 - import time, blank line, import mox, blank line, all three nova imports.","commit_id":"e0139444d1c8d3d9fd4ae0348e1b4c61f2208ed9"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"93632ad1ef04af2f83f3da199f250725426541fc","unresolved":false,"context_lines":[{"line_number":22,"context_line":"import tempfile"},{"line_number":23,"context_line":"import time"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"import mox"},{"line_number":26,"context_line":"from nova import test"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"from nova.tests.baremetal.db import base as bm_db_base"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAM3%2F%2B7YM%3D","line":25,"in_reply_to":"AAAAM3%2F%2B7Zs%3D","updated":"2013-02-14 04:01:11.000000000","message":"Done","commit_id":"e0139444d1c8d3d9fd4ae0348e1b4c61f2208ed9"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"c2a29b9117cd798ffdce9e8465f698f40a1f5323","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        for (dep_id, params) in enumerate(params_list):"},{"line_number":132,"context_line":"            bmdh.QUEUE.put((dep_id, params))"},{"line_number":133,"context_line":"        self.wait_queue_empty(1)"},{"line_number":134,"context_line":"        self.assertEqual(params_list, history)"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"class PhysicalWorkTestCase(test.TestCase):"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAM3%2F%2B7Zo%3D","line":134,"updated":"2013-02-14 03:30:43.000000000","message":"Does this one need a VerifyAll call ?","commit_id":"e0139444d1c8d3d9fd4ae0348e1b4c61f2208ed9"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"93632ad1ef04af2f83f3da199f250725426541fc","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        for (dep_id, params) in enumerate(params_list):"},{"line_number":132,"context_line":"            bmdh.QUEUE.put((dep_id, params))"},{"line_number":133,"context_line":"        self.wait_queue_empty(1)"},{"line_number":134,"context_line":"        self.assertEqual(params_list, history)"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"class PhysicalWorkTestCase(test.TestCase):"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAM3%2F%2B7YQ%3D","line":134,"in_reply_to":"AAAAM3%2F%2B7Zo%3D","updated":"2013-02-14 04:01:11.000000000","message":"Done","commit_id":"e0139444d1c8d3d9fd4ae0348e1b4c61f2208ed9"}],"nova/tests/baremetal/test_pxe.py":[{"author":{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},"change_message_id":"1fd1ba57ae9b404ec6ce1932374d137399adcc45","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"\"\"\"Tests for baremetal pxe driver.\"\"\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"import mox"},{"line_number":23,"context_line":"import os"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from testtools import matchers"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FCtg%3D","line":22,"updated":"2013-02-09 16:32:56.000000000","message":"This should be down by testtools, as it\u0027s third-party not stdlib.","commit_id":"96f2ce3fc24e6ccb69d034f9234a5690a2dbb2a8"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"975420d1775d8e975ac22d4ed0b9d49970d075d3","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"\"\"\"Tests for baremetal pxe driver.\"\"\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"import mox"},{"line_number":23,"context_line":"import os"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from testtools import matchers"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FCJ0%3D","line":22,"in_reply_to":"AAAAM3%2F%2FCtg%3D","updated":"2013-02-10 17:04:25.000000000","message":"Done","commit_id":"96f2ce3fc24e6ccb69d034f9234a5690a2dbb2a8"},{"author":{"_account_id":3068,"name":"Arata Notsu","email":"notsu@virtualtech.jp","username":"arata776"},"change_message_id":"3379fbdd55d5d1c92938da69eda427fd8c3d18c8","unresolved":false,"context_lines":[{"line_number":449,"context_line":"        pxe.get_partition_sizes(self.instance).AndReturn((0, 0))"},{"line_number":450,"context_line":"        bm_utils.random_alnum(32).AndReturn(\u0027alnum\u0027)"},{"line_number":451,"context_line":"        pxe.build_pxe_config("},{"line_number":452,"context_line":"                1, \u0027alnum\u0027, iqn, \u0027aaaa\u0027, \u0027bbbb\u0027, \u0027cccc\u0027, \u0027dddd\u0027).\\"},{"line_number":453,"context_line":"                        AndReturn(pxe_config)"},{"line_number":454,"context_line":"        bm_utils.write_to_file(pxe_path, pxe_config)"},{"line_number":455,"context_line":"        for mac in macs:"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAM3%2F%2B9jc%3D","line":452,"updated":"2013-02-13 05:10:57.000000000","message":"It is better to use self.node[\u0027id\u0027] than 1.","commit_id":"cf1a7821ac3318ef1569cde11a089cd83627154a"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"3900343ecea14bea454c6b132d7dedb898aefc88","unresolved":false,"context_lines":[{"line_number":449,"context_line":"        pxe.get_partition_sizes(self.instance).AndReturn((0, 0))"},{"line_number":450,"context_line":"        bm_utils.random_alnum(32).AndReturn(\u0027alnum\u0027)"},{"line_number":451,"context_line":"        pxe.build_pxe_config("},{"line_number":452,"context_line":"                1, \u0027alnum\u0027, iqn, \u0027aaaa\u0027, \u0027bbbb\u0027, \u0027cccc\u0027, \u0027dddd\u0027).\\"},{"line_number":453,"context_line":"                        AndReturn(pxe_config)"},{"line_number":454,"context_line":"        bm_utils.write_to_file(pxe_path, pxe_config)"},{"line_number":455,"context_line":"        for mac in macs:"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAM3%2F%2B9hc%3D","line":452,"in_reply_to":"AAAAM3%2F%2B9jc%3D","updated":"2013-02-13 05:27:20.000000000","message":"Done","commit_id":"cf1a7821ac3318ef1569cde11a089cd83627154a"}],"nova/tests/test_baremetal_migrations.conf":[{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"c2a29b9117cd798ffdce9e8465f698f40a1f5323","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[DEFAULT]"},{"line_number":2,"context_line":"# Set up any number of migration data stores you want, one"},{"line_number":3,"context_line":"# The \"name\" used in the test is the config variable key."},{"line_number":4,"context_line":"#sqlite\u003dsqlite:///test_migrations.db"},{"line_number":5,"context_line":"sqlite\u003dsqlite://"}],"source_content_type":"text/plain","patch_set":10,"id":"AAAAM3%2F%2B7Zg%3D","line":2,"updated":"2013-02-14 03:30:43.000000000","message":"I can\u0027t quite parse this.","commit_id":"e0139444d1c8d3d9fd4ae0348e1b4c61f2208ed9"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"93632ad1ef04af2f83f3da199f250725426541fc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[DEFAULT]"},{"line_number":2,"context_line":"# Set up any number of migration data stores you want, one"},{"line_number":3,"context_line":"# The \"name\" used in the test is the config variable key."},{"line_number":4,"context_line":"#sqlite\u003dsqlite:///test_migrations.db"},{"line_number":5,"context_line":"sqlite\u003dsqlite://"}],"source_content_type":"text/plain","patch_set":10,"id":"AAAAM3%2F%2B7YI%3D","line":2,"in_reply_to":"AAAAM3%2F%2B7Zg%3D","updated":"2013-02-14 04:01:11.000000000","message":"I just copied the file from test_migrations.conf...","commit_id":"e0139444d1c8d3d9fd4ae0348e1b4c61f2208ed9"}],"nova/tests/test_baremetal_migrations.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"26fba4e4844cd9bfaf6ca091d990bd34cd790898","unresolved":false,"context_lines":[{"line_number":117,"context_line":"    return sqlalchemy.Table(name, metadata, autoload\u003dTrue)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"class TestBaremetalMigrations(test.TestCase):"},{"line_number":121,"context_line":"    \"\"\"Test sqlalchemy-migrate migrations.\"\"\""},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    DEFAULT_CONFIG_FILE \u003d os.path.join(os.path.dirname(__file__),"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAM3%2F%2B50Q%3D","line":120,"updated":"2013-02-14 23:09:35.000000000","message":"probably it is better to make this class as subclass of test_migration.BaseMigrationTestCase to avoid copy paste?","commit_id":"7657167b75f736df4cfcb7b2b84cc33f14b1d427"},{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"d5dc73ce3b02ffc519e6a7dfaf83bc9104fa274b","unresolved":false,"context_lines":[{"line_number":117,"context_line":"    return sqlalchemy.Table(name, metadata, autoload\u003dTrue)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"class TestBaremetalMigrations(test.TestCase):"},{"line_number":121,"context_line":"    \"\"\"Test sqlalchemy-migrate migrations.\"\"\""},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    DEFAULT_CONFIG_FILE \u003d os.path.join(os.path.dirname(__file__),"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAM3%2F%2BzPI%3D","line":120,"updated":"2013-02-18 23:18:28.000000000","message":"Oh, wow - son of $DEITY weeps for the sins of the world\n\n~300 lines of copied and pasted code ?","commit_id":"9621daff783a8aa9b6491d046e35ba75cb5d0873"}],"nova/tests/test_migrations.py":[{"author":{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},"change_message_id":"93c6b8843955bc006ae1446114dcd1156f94ba5d","unresolved":false,"context_lines":[{"line_number":126,"context_line":"    return sqlalchemy.Table(name, metadata, autoload\u003dTrue)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"def get_mysql_connection_dict(conn_pieces):"},{"line_number":130,"context_line":"    database \u003d conn_pieces.path.strip(\u0027/\u0027)"},{"line_number":131,"context_line":"    loc_pieces \u003d conn_pieces.netloc.split(\u0027@\u0027)"},{"line_number":132,"context_line":"    host \u003d loc_pieces[1]"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAM3%2F%2Bwk0%3D","line":129,"updated":"2013-02-19 20:48:49.000000000","message":"It doesn\u0027t return a dict, so this is poorly named.  (Same for the next function.)","commit_id":"1a0b6875744cca8921335882e1de45c469a2b3c3"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"63bf763321878c983a3ab7c7c6f0378c2f316de3","unresolved":false,"context_lines":[{"line_number":126,"context_line":"    return sqlalchemy.Table(name, metadata, autoload\u003dTrue)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"def get_mysql_connection_dict(conn_pieces):"},{"line_number":130,"context_line":"    database \u003d conn_pieces.path.strip(\u0027/\u0027)"},{"line_number":131,"context_line":"    loc_pieces \u003d conn_pieces.netloc.split(\u0027@\u0027)"},{"line_number":132,"context_line":"    host \u003d loc_pieces[1]"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAM3%2F%2Bwjo%3D","line":129,"in_reply_to":"AAAAM3%2F%2Bwk0%3D","updated":"2013-02-19 20:54:40.000000000","message":"yep, my bad. it returned a dict in my first revision...","commit_id":"1a0b6875744cca8921335882e1de45c469a2b3c3"},{"author":{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},"change_message_id":"93c6b8843955bc006ae1446114dcd1156f94ba5d","unresolved":false,"context_lines":[{"line_number":136,"context_line":"    if len(auth_pieces) \u003e 1:"},{"line_number":137,"context_line":"        if auth_pieces[1].strip():"},{"line_number":138,"context_line":"            password \u003d \"-p\\\"%s\\\"\" % auth_pieces[1]"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    return [user, password, database, host]"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAM3%2F%2Bwk4%3D","line":139,"updated":"2013-02-19 20:48:49.000000000","message":"Maybe use a tuple instead of a list.","commit_id":"1a0b6875744cca8921335882e1de45c469a2b3c3"},{"author":{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},"change_message_id":"93c6b8843955bc006ae1446114dcd1156f94ba5d","unresolved":false,"context_lines":[{"line_number":292,"context_line":"        total \u003d connection.execute(\"SELECT count(*) \""},{"line_number":293,"context_line":"                                   \"from information_schema.TABLES \""},{"line_number":294,"context_line":"                                   \"where TABLE_SCHEMA\u003d\u0027%(database)s\u0027\" %"},{"line_number":295,"context_line":"                                   locals())"},{"line_number":296,"context_line":"        self.assertTrue(total.scalar() \u003e 0, \"No tables found. Wrong schema?\")"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"        noninnodb \u003d connection.execute(\"SELECT count(*) \""}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAM3%2F%2Bwkw%3D","line":295,"updated":"2013-02-19 20:48:49.000000000","message":"locals() is yucky","commit_id":"1a0b6875744cca8921335882e1de45c469a2b3c3"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"63bf763321878c983a3ab7c7c6f0378c2f316de3","unresolved":false,"context_lines":[{"line_number":292,"context_line":"        total \u003d connection.execute(\"SELECT count(*) \""},{"line_number":293,"context_line":"                                   \"from information_schema.TABLES \""},{"line_number":294,"context_line":"                                   \"where TABLE_SCHEMA\u003d\u0027%(database)s\u0027\" %"},{"line_number":295,"context_line":"                                   locals())"},{"line_number":296,"context_line":"        self.assertTrue(total.scalar() \u003e 0, \"No tables found. Wrong schema?\")"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"        noninnodb \u003d connection.execute(\"SELECT count(*) \""}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAM3%2F%2BwjQ%3D","line":295,"in_reply_to":"AAAAM3%2F%2Bwkw%3D","updated":"2013-02-19 20:54:40.000000000","message":"locals is used many other places in this file, in this same manner... i\u0027d rather not fix them all right now :)","commit_id":"1a0b6875744cca8921335882e1de45c469a2b3c3"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"5d48337c3a983d38db003635e377289b23dddfff","unresolved":false,"context_lines":[{"line_number":322,"context_line":"        connect_string \u003d _get_connect_string(\"postgres\", database\u003ddatabase)"},{"line_number":323,"context_line":"        engine \u003d sqlalchemy.create_engine(connect_string)"},{"line_number":324,"context_line":"        (user, password, database, host) \u003d \\"},{"line_number":325,"context_line":"                get_mysql_connection_info(urlparse.urlparse(conn_string))"},{"line_number":326,"context_line":"        self.engines[database] \u003d engine"},{"line_number":327,"context_line":"        self.test_databases[database] \u003d connect_string"},{"line_number":328,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"AAAAM3%2F%2BwOA%3D","line":325,"updated":"2013-02-19 22:44:24.000000000","message":"bad typo here, should have failed tests but didn\u0027t...","commit_id":"47920c9bd3a676587817cabf2cbfca0de0ae6893"}],"nova/virt/baremetal/db/sqlalchemy/api.py":[{"author":{"_account_id":3068,"name":"Arata Notsu","email":"notsu@virtualtech.jp","username":"arata776"},"change_message_id":"3379fbdd55d5d1c92938da69eda427fd8c3d18c8","unresolved":false,"context_lines":[{"line_number":28,"context_line":"from nova.openstack.common import log as logging"},{"line_number":29,"context_line":"from nova.openstack.common import timeutils"},{"line_number":30,"context_line":"from nova.openstack.common import uuidutils"},{"line_number":31,"context_line":"from nova.virt.baremetal import baremetal_states"},{"line_number":32,"context_line":"from nova.virt.baremetal.db.sqlalchemy import models"},{"line_number":33,"context_line":"from nova.virt.baremetal.db.sqlalchemy import session as db_session"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAM3%2F%2B9io%3D","line":31,"updated":"2013-02-13 05:10:57.000000000","message":"baremetal_states is not used","commit_id":"cf1a7821ac3318ef1569cde11a089cd83627154a"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"3900343ecea14bea454c6b132d7dedb898aefc88","unresolved":false,"context_lines":[{"line_number":28,"context_line":"from nova.openstack.common import log as logging"},{"line_number":29,"context_line":"from nova.openstack.common import timeutils"},{"line_number":30,"context_line":"from nova.openstack.common import uuidutils"},{"line_number":31,"context_line":"from nova.virt.baremetal import baremetal_states"},{"line_number":32,"context_line":"from nova.virt.baremetal.db.sqlalchemy import models"},{"line_number":33,"context_line":"from nova.virt.baremetal.db.sqlalchemy import session as db_session"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAM3%2F%2B9hY%3D","line":31,"in_reply_to":"AAAAM3%2F%2B9io%3D","updated":"2013-02-13 05:27:20.000000000","message":"Done","commit_id":"cf1a7821ac3318ef1569cde11a089cd83627154a"}],"nova/virt/baremetal/db/sqlalchemy/migrate_repo/versions/002_drop_bm_deployments.py":[{"author":{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},"change_message_id":"77fb38f5dc85980ec98af100214b9ac3c439020e","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        Column(\u0027root_mb\u0027, Integer),"},{"line_number":70,"context_line":"        Column(\u0027swap_mb\u0027, Integer),"},{"line_number":71,"context_line":"        mysql_engine\u003d\u0027InnoDB\u0027,"},{"line_number":72,"context_line":"        #mysql_charset\u003d\u0027utf8\u0027"},{"line_number":73,"context_line":"    )"},{"line_number":74,"context_line":"    bm_deployments.create()"}],"source_content_type":"text/x-python","patch_set":17,"id":"AAAAM3%2F%2BwhM%3D","line":72,"updated":"2013-02-19 21:01:16.000000000","message":"Should this commented-out bit remain?","commit_id":"47920c9bd3a676587817cabf2cbfca0de0ae6893"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"8c954399436ebaa69aa7a571c5c5012b61c84070","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        Column(\u0027root_mb\u0027, Integer),"},{"line_number":70,"context_line":"        Column(\u0027swap_mb\u0027, Integer),"},{"line_number":71,"context_line":"        mysql_engine\u003d\u0027InnoDB\u0027,"},{"line_number":72,"context_line":"        #mysql_charset\u003d\u0027utf8\u0027"},{"line_number":73,"context_line":"    )"},{"line_number":74,"context_line":"    bm_deployments.create()"}],"source_content_type":"text/x-python","patch_set":17,"id":"AAAAM3%2F%2BwRs%3D","line":72,"in_reply_to":"AAAAM3%2F%2BwhM%3D","updated":"2013-02-19 22:28:21.000000000","message":"I agree, but this can be tweaked later worst case.","commit_id":"47920c9bd3a676587817cabf2cbfca0de0ae6893"},{"author":{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},"change_message_id":"4b19b1d277f5ec52295ffdb2612303c424e7ec22","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        Column(\u0027root_mb\u0027, Integer),"},{"line_number":70,"context_line":"        Column(\u0027swap_mb\u0027, Integer),"},{"line_number":71,"context_line":"        mysql_engine\u003d\u0027InnoDB\u0027,"},{"line_number":72,"context_line":"        #mysql_charset\u003d\u0027utf8\u0027"},{"line_number":73,"context_line":"    )"},{"line_number":74,"context_line":"    bm_deployments.create()"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAM3%2F%2BwNI%3D","line":72,"updated":"2013-02-19 22:51:25.000000000","message":"Let\u0027s get rid of the commented-out mysql_charset.","commit_id":"a0e31b5f16dd52a1cac5b7c2ad2e6b3440bb73eb"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"3ffb0329d8ecef67f9aac4dfb15cc7bc4306abac","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        Column(\u0027root_mb\u0027, Integer),"},{"line_number":70,"context_line":"        Column(\u0027swap_mb\u0027, Integer),"},{"line_number":71,"context_line":"        mysql_engine\u003d\u0027InnoDB\u0027,"},{"line_number":72,"context_line":"        #mysql_charset\u003d\u0027utf8\u0027"},{"line_number":73,"context_line":"    )"},{"line_number":74,"context_line":"    bm_deployments.create()"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAM3%2F%2BwJo%3D","line":72,"in_reply_to":"AAAAM3%2F%2BwNI%3D","updated":"2013-02-19 23:10:37.000000000","message":"Done","commit_id":"a0e31b5f16dd52a1cac5b7c2ad2e6b3440bb73eb"}],"nova/virt/baremetal/pxe.py":[{"author":{"_account_id":3068,"name":"Arata Notsu","email":"notsu@virtualtech.jp","username":"arata776"},"change_message_id":"3379fbdd55d5d1c92938da69eda427fd8c3d18c8","unresolved":false,"context_lines":[{"line_number":28,"context_line":"from nova.openstack.common.db.sqlalchemy import session as db_session"},{"line_number":29,"context_line":"from nova.openstack.common import fileutils"},{"line_number":30,"context_line":"from nova.openstack.common import log as logging"},{"line_number":31,"context_line":"from nova.virt.baremetal import baremetal_states"},{"line_number":32,"context_line":"from nova.virt.baremetal import base"},{"line_number":33,"context_line":"from nova.virt.baremetal import db"},{"line_number":34,"context_line":"from nova.virt.baremetal import utils as bm_utils"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAM3%2F%2B9ic%3D","line":31,"updated":"2013-02-13 05:10:57.000000000","message":"baremetal_states is not used","commit_id":"cf1a7821ac3318ef1569cde11a089cd83627154a"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"3900343ecea14bea454c6b132d7dedb898aefc88","unresolved":false,"context_lines":[{"line_number":28,"context_line":"from nova.openstack.common.db.sqlalchemy import session as db_session"},{"line_number":29,"context_line":"from nova.openstack.common import fileutils"},{"line_number":30,"context_line":"from nova.openstack.common import log as logging"},{"line_number":31,"context_line":"from nova.virt.baremetal import baremetal_states"},{"line_number":32,"context_line":"from nova.virt.baremetal import base"},{"line_number":33,"context_line":"from nova.virt.baremetal import db"},{"line_number":34,"context_line":"from nova.virt.baremetal import utils as bm_utils"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAM3%2F%2B9hU%3D","line":31,"in_reply_to":"AAAAM3%2F%2B9ic%3D","updated":"2013-02-13 05:27:20.000000000","message":"removed from this patch, but the next one will add it back (and use it)","commit_id":"cf1a7821ac3318ef1569cde11a089cd83627154a"}]}