)]}'
{"nova/virt/libvirt/driver.py":[{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"8b4230cee257973692cedcbf001f4fb6d5d361d9","unresolved":false,"context_lines":[{"line_number":854,"context_line":"        else:"},{"line_number":855,"context_line":"            LOG.info(_(\"Beginning cold snapshot process\"),"},{"line_number":856,"context_line":"                     instance\u003dinstance)"},{"line_number":857,"context_line":"            snapshot_backend.snapshot_create()"},{"line_number":858,"context_line":""},{"line_number":859,"context_line":"        update_task_state(task_state\u003dtask_states.IMAGE_PENDING_UPLOAD)"},{"line_number":860,"context_line":"        snapshot_directory \u003d CONF.libvirt_snapshots_directory"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FDgk%3D","line":857,"updated":"2013-02-08 19:38:27.000000000","message":"This create looks like it is meant to pair with the delete, but if we get interrupted it won\u0027t: the try:finally: only wraps later code. I think you want two try: finallys with the new one to be scoped all around from right after snapshop_backend is allocated.","commit_id":"aceae163bb0b050de1d362401c330dbecd0ae981"},{"author":{"_account_id":1525,"name":"Rafi Khardalian","email":"rafi@metacloud.com","username":"rkhardalian"},"change_message_id":"01e9e92f4d950f6e55aa709a2ca1057e7e61577c","unresolved":false,"context_lines":[{"line_number":854,"context_line":"        else:"},{"line_number":855,"context_line":"            LOG.info(_(\"Beginning cold snapshot process\"),"},{"line_number":856,"context_line":"                     instance\u003dinstance)"},{"line_number":857,"context_line":"            snapshot_backend.snapshot_create()"},{"line_number":858,"context_line":""},{"line_number":859,"context_line":"        update_task_state(task_state\u003dtask_states.IMAGE_PENDING_UPLOAD)"},{"line_number":860,"context_line":"        snapshot_directory \u003d CONF.libvirt_snapshots_directory"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FDeI%3D","line":857,"in_reply_to":"AAAAM3%2F%2FDgk%3D","updated":"2013-02-08 19:58:40.000000000","message":"Good point.  This patch one-for-one replaces the calls in place.  I\u0027ll make sure this is addressed in the next sweep of this code, which will immediately follow this patch.","commit_id":"aceae163bb0b050de1d362401c330dbecd0ae981"}]}