)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"96ed1915dde292c2382137ed34be5e9a078e52ad","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Adds new configuration options:"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"    iptables_top_regex\u003d\u0027\u0027 (Default)"},{"line_number":12,"context_line":"        When set treated as a regular explression to match"},{"line_number":13,"context_line":"        iptables rules that should always be placed at the"},{"line_number":14,"context_line":"        top of the table before the nova chains."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAM3%2F%2B9dI%3D","line":12,"updated":"2013-02-13 06:17:11.000000000","message":"expression","commit_id":"41724e97b9bec6bd21dce45d8dab0140e976ba54"},{"author":{"_account_id":3189,"name":"Chet Burgess","email":"cfb@metacloud.com","username":"cfb-n"},"change_message_id":"0ae4c6870985ba32fb36a9e30f842d52e4d2aa92","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Adds new configuration options:"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"    iptables_top_regex\u003d\u0027\u0027 (Default)"},{"line_number":12,"context_line":"        When set treated as a regular explression to match"},{"line_number":13,"context_line":"        iptables rules that should always be placed at the"},{"line_number":14,"context_line":"        top of the table before the nova chains."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAM3%2F%2B75M%3D","line":12,"in_reply_to":"AAAAM3%2F%2B9dI%3D","updated":"2013-02-13 22:34:44.000000000","message":"Fair enough. I\u0027ll fix this.","commit_id":"41724e97b9bec6bd21dce45d8dab0140e976ba54"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"96ed1915dde292c2382137ed34be5e9a078e52ad","unresolved":false,"context_lines":[{"line_number":22,"context_line":"actually testing the chains we use. In some cases we"},{"line_number":23,"context_line":"were looking for chains that haven\u0027t existed in the"},{"line_number":24,"context_line":"code base for 2 years. I took the oppurtunity to update"},{"line_number":25,"context_line":"all tests to actually test for the chains we care about."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Flags: DocImpact"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAM3%2F%2B9dE%3D","line":25,"updated":"2013-02-13 06:17:11.000000000","message":"Can we somehow have these unit tests fail if the chains they are testing escape again?","commit_id":"41724e97b9bec6bd21dce45d8dab0140e976ba54"},{"author":{"_account_id":3189,"name":"Chet Burgess","email":"cfb@metacloud.com","username":"cfb-n"},"change_message_id":"0ae4c6870985ba32fb36a9e30f842d52e4d2aa92","unresolved":false,"context_lines":[{"line_number":22,"context_line":"actually testing the chains we use. In some cases we"},{"line_number":23,"context_line":"were looking for chains that haven\u0027t existed in the"},{"line_number":24,"context_line":"code base for 2 years. I took the oppurtunity to update"},{"line_number":25,"context_line":"all tests to actually test for the chains we care about."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Flags: DocImpact"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAM3%2F%2B75c%3D","line":25,"in_reply_to":"AAAAM3%2F%2B9dE%3D","updated":"2013-02-13 22:34:44.000000000","message":"That is one of the changes I made. The reason the tests continued to pass even after the code changed is because were were hard coding the chain names and then looking for those hardcoded chains. The code actually generates chain names based upon the running process. The changes to sample_filter and sample_nat are now generated using binary_name. If the code no longer generates a chain we have in our samples the asserts should now fail.","commit_id":"41724e97b9bec6bd21dce45d8dab0140e976ba54"}]}