)]}'
{"nova/tests/functional/api_sample_tests/test_extension_info.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"5e33e79d8aee93954d68701457c2f2049ec16ae6","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    sample_dir \u003d \"extension-info\""},{"line_number":49,"context_line":"    extra_extensions_to_load \u003d [\"os-create-backup\"]"},{"line_number":50,"context_line":"    # NOTE (gmann): run this tests for v21. and v2.1 compatible mode only"},{"line_number":51,"context_line":"    # as there is no \u0027extensions/*\u0027 API in v2."},{"line_number":52,"context_line":"    scenarios \u003d [(\u0027v2_1\u0027, {\u0027_test\u0027: \u0027v2.1\u0027}),"},{"line_number":53,"context_line":"                 (\u0027v2_1_compatible\u0027, {\u0027_test\u0027: \u0027v2.1_compatible\u0027})]"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_ff4f6968","line":51,"updated":"2015-08-21 11:27:01.000000000","message":"it shouldn\u0027t really exist in v2.1 compatible mode, that sounds like a bug.","commit_id":"2ae641a5a5f6093bfaa387fb93675febd8d26fad"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"d83e83b9547255b5e10fa6f1afee97e5aa2c266d","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    sample_dir \u003d \"extension-info\""},{"line_number":49,"context_line":"    extra_extensions_to_load \u003d [\"os-create-backup\"]"},{"line_number":50,"context_line":"    # NOTE (gmann): run this tests for v21. and v2.1 compatible mode only"},{"line_number":51,"context_line":"    # as there is no \u0027extensions/*\u0027 API in v2."},{"line_number":52,"context_line":"    scenarios \u003d [(\u0027v2_1\u0027, {\u0027_test\u0027: \u0027v2.1\u0027}),"},{"line_number":53,"context_line":"                 (\u0027v2_1_compatible\u0027, {\u0027_test\u0027: \u0027v2.1_compatible\u0027})]"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_6926bcbb","line":51,"in_reply_to":"fa1b9901_0a773903","updated":"2015-08-25 12:07:34.000000000","message":"so I don\u0027t think its OK (I want to see us remove this API ASAP, which probably means years), but lets not worry about that here, its a separate change really.","commit_id":"2ae641a5a5f6093bfaa387fb93675febd8d26fad"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0e267e5374c059448550649ca4444332f304830f","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    sample_dir \u003d \"extension-info\""},{"line_number":49,"context_line":"    extra_extensions_to_load \u003d [\"os-create-backup\"]"},{"line_number":50,"context_line":"    # NOTE (gmann): run this tests for v21. and v2.1 compatible mode only"},{"line_number":51,"context_line":"    # as there is no \u0027extensions/*\u0027 API in v2."},{"line_number":52,"context_line":"    scenarios \u003d [(\u0027v2_1\u0027, {\u0027_test\u0027: \u0027v2.1\u0027}),"},{"line_number":53,"context_line":"                 (\u0027v2_1_compatible\u0027, {\u0027_test\u0027: \u0027v2.1_compatible\u0027})]"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_0a773903","line":51,"in_reply_to":"fa1b9901_ff4f6968","updated":"2015-08-24 05:51:41.000000000","message":"humm yea that should not be. As that is just extension detail API, should it be ok?","commit_id":"2ae641a5a5f6093bfaa387fb93675febd8d26fad"}],"nova/tests/functional/api_sample_tests/test_servers.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"d83e83b9547255b5e10fa6f1afee97e5aa2c266d","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def _get_flags(self):"},{"line_number":63,"context_line":"        f \u003d super(ServersSampleBase, self)._get_flags()"},{"line_number":64,"context_line":"        f[\u0027osapi_compute_extension\u0027] \u003d CONF.osapi_compute_extension[:]"},{"line_number":65,"context_line":"        f[\u0027osapi_compute_extension\u0027].append("},{"line_number":66,"context_line":"            \u0027nova.api.openstack.compute.contrib.keypairs.Keypairs\u0027)"},{"line_number":67,"context_line":"        f[\u0027osapi_compute_extension\u0027].append("}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_49e098fa","line":64,"updated":"2015-08-25 12:07:34.000000000","message":"I would love a follow up change to remove all of these CONF things.","commit_id":"2ae641a5a5f6093bfaa387fb93675febd8d26fad"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"28c466eab15f7885f8f959e5cce1ed59c255bb5e","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def _get_flags(self):"},{"line_number":63,"context_line":"        f \u003d super(ServersSampleBase, self)._get_flags()"},{"line_number":64,"context_line":"        f[\u0027osapi_compute_extension\u0027] \u003d CONF.osapi_compute_extension[:]"},{"line_number":65,"context_line":"        f[\u0027osapi_compute_extension\u0027].append("},{"line_number":66,"context_line":"            \u0027nova.api.openstack.compute.contrib.keypairs.Keypairs\u0027)"},{"line_number":67,"context_line":"        f[\u0027osapi_compute_extension\u0027].append("}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_c4a1c9f9","line":64,"in_reply_to":"fa1b9901_49e098fa","updated":"2015-08-26 01:21:26.000000000","message":"Me too. But we need to have those till we remove v2 code or v2 extension things. After that we can cleanup these thing.","commit_id":"2ae641a5a5f6093bfaa387fb93675febd8d26fad"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0b8cfd6281e84cdddcd8587b05a236c37a2753dc","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def _get_flags(self):"},{"line_number":63,"context_line":"        f \u003d super(ServersSampleBase, self)._get_flags()"},{"line_number":64,"context_line":"        f[\u0027osapi_compute_extension\u0027] \u003d CONF.osapi_compute_extension[:]"},{"line_number":65,"context_line":"        f[\u0027osapi_compute_extension\u0027].append("},{"line_number":66,"context_line":"            \u0027nova.api.openstack.compute.contrib.keypairs.Keypairs\u0027)"},{"line_number":67,"context_line":"        f[\u0027osapi_compute_extension\u0027].append("}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_d6dcac48","line":64,"in_reply_to":"fa1b9901_9778d77f","updated":"2015-08-26 23:43:36.000000000","message":"Yea, that we can do. There will be changes in sample files(where we can share lot of sample files among tests). I will follow up on this.\nThanks","commit_id":"2ae641a5a5f6093bfaa387fb93675febd8d26fad"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"6277cdf2c23df5ea6feb8ad16a974633b0c3edf8","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def _get_flags(self):"},{"line_number":63,"context_line":"        f \u003d super(ServersSampleBase, self)._get_flags()"},{"line_number":64,"context_line":"        f[\u0027osapi_compute_extension\u0027] \u003d CONF.osapi_compute_extension[:]"},{"line_number":65,"context_line":"        f[\u0027osapi_compute_extension\u0027].append("},{"line_number":66,"context_line":"            \u0027nova.api.openstack.compute.contrib.keypairs.Keypairs\u0027)"},{"line_number":67,"context_line":"        f[\u0027osapi_compute_extension\u0027].append("}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_9778d77f","line":64,"in_reply_to":"fa1b9901_c4a1c9f9","updated":"2015-08-26 08:59:59.000000000","message":"I think we can just hard code the tests to run all the extensions, all the time, as a starting point.\n\nthere could be issues that brings up, but I think that should work.","commit_id":"2ae641a5a5f6093bfaa387fb93675febd8d26fad"}]}