)]}'
{"nova/virt/libvirt/vif.py":[{"author":{"_account_id":3189,"name":"Chet Burgess","email":"cfb@metacloud.com","username":"cfb-n"},"change_message_id":"cb6a1a8dd603b87989b1a58e3e7512fb39094b38","unresolved":false,"context_lines":[{"line_number":67,"context_line":"            return True"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        if virt_type not in valid_models:"},{"line_number":70,"context_line":"            raise exception.NovaException("},{"line_number":71,"context_line":"                _(\"Unsupported virt type %s\") % virt_type)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        return vif_model in valid_models[virt_type]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FAog%3D","line":70,"updated":"2013-02-11 19:02:50.000000000","message":"I think this should be a specific exception rather then a generic one. This will make it easier for things like horizon and other API clients to detect the specific error and message the users accordingly.","commit_id":"2eb35d26bc2b536251b1dd6b4ca52796fbfc69a1"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"b54eb2fccb817463b7f61a44f8899f40253de618","unresolved":false,"context_lines":[{"line_number":67,"context_line":"            return True"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        if virt_type not in valid_models:"},{"line_number":70,"context_line":"            raise exception.NovaException("},{"line_number":71,"context_line":"                _(\"Unsupported virt type %s\") % virt_type)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        return vif_model in valid_models[virt_type]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2B%2BVU%3D","line":70,"in_reply_to":"AAAAM3%2F%2FAog%3D","updated":"2013-02-12 19:48:34.000000000","message":"Actually this error message would never get back to the apps, since \u0027virt_type\u0027 is not something under control of the user. It comes from CONF.libvirt_type. That said, I introduced a new exception for this anyway.","commit_id":"2eb35d26bc2b536251b1dd6b4ca52796fbfc69a1"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"b54eb2fccb817463b7f61a44f8899f40253de618","unresolved":false,"context_lines":[{"line_number":122,"context_line":"                                           model):"},{"line_number":123,"context_line":"            raise exception.NovaException("},{"line_number":124,"context_line":"                _(\"VIF model %(model)s is not valid for %(virt)s\") %"},{"line_number":125,"context_line":"                {\u0027model\u0027: model, \u0027virt\u0027: CONF.libvirt_type})"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        designer.set_vif_guest_frontend_config("},{"line_number":128,"context_line":"            conf, mapping[\u0027mac\u0027], model, driver)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2B%2BVQ%3D","line":125,"updated":"2013-02-12 19:48:34.000000000","message":"This is the exception that would get back to the user, and I have introduced a special class for it now.","commit_id":"2eb35d26bc2b536251b1dd6b4ca52796fbfc69a1"}]}