)]}'
{"nova/virt/libvirt/driver.py":[{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"f55976b5c2e2c51a19260286ecb48462c2a051bf","unresolved":false,"context_lines":[{"line_number":251,"context_line":"                    \u0027value for this config option is host-arch\u003dmachine-type. \u0027"},{"line_number":252,"context_line":"                    \u0027For example: x86_64\u003dmachinetype1,armv7l\u003dmachinetype2\u0027),"},{"line_number":253,"context_line":"    cfg.ListOpt(\u0027bios_path\u0027,"},{"line_number":254,"context_line":"               help\u003d\u0027For qemu or KVM guests, some ARCHs(such as. arm aarch64)\u0027"},{"line_number":255,"context_line":"              \u0027need external bios rom path\u0027),"},{"line_number":256,"context_line":"    cfg.StrOpt(\u0027sysinfo_serial\u0027,"},{"line_number":257,"context_line":"               default\u003d\u0027auto\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_3ba42a06","line":254,"updated":"2015-08-21 03:52:45.000000000","message":"We add a new option, so I think DocImpact should be added in commit message.\n\nAnd lack a space at the end of this line.","commit_id":"5f664a24cf5a29b4cedce43edd9f448a230ca3ad"},{"author":{"_account_id":16986,"name":"Shuquan Huang","email":"shuquan.huang@live.com","username":"shuquan"},"change_message_id":"13aa84ab73f2c7bc8b2c5133a741654fa5fc8a46","unresolved":false,"context_lines":[{"line_number":251,"context_line":"                    \u0027value for this config option is host-arch\u003dmachine-type. \u0027"},{"line_number":252,"context_line":"                    \u0027For example: x86_64\u003dmachinetype1,armv7l\u003dmachinetype2\u0027),"},{"line_number":253,"context_line":"    cfg.ListOpt(\u0027bios_path\u0027,"},{"line_number":254,"context_line":"               help\u003d\u0027For qemu or KVM guests, some ARCHs(such as. arm aarch64)\u0027"},{"line_number":255,"context_line":"              \u0027need external bios rom path\u0027),"},{"line_number":256,"context_line":"    cfg.StrOpt(\u0027sysinfo_serial\u0027,"},{"line_number":257,"context_line":"               default\u003d\u0027auto\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_8e5c0f1a","line":254,"in_reply_to":"fa1b9901_3ba42a06","updated":"2015-08-21 06:04:20.000000000","message":"Good catch on the space. Thanks. :)","commit_id":"5f664a24cf5a29b4cedce43edd9f448a230ca3ad"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"f55976b5c2e2c51a19260286ecb48462c2a051bf","unresolved":false,"context_lines":[{"line_number":4055,"context_line":"            if caps.host.cpu.arch in (arch.I686, arch.X86_64):"},{"line_number":4056,"context_line":"                guest.sysinfo \u003d self._get_guest_config_sysinfo(instance)"},{"line_number":4057,"context_line":"                guest.os_smbios \u003d vconfig.LibvirtConfigGuestSMBIOS()"},{"line_number":4058,"context_line":"            LOG.warn(_LW(\u0027bios loader: %s,\u0027), CONF.libvirt.bios_path)"},{"line_number":4059,"context_line":"            if CONF.libvirt.bios_path:"},{"line_number":4060,"context_line":"                guest.os_bios \u003d CONF.libvirt.bios_path"},{"line_number":4061,"context_line":"            guest.os_mach_type \u003d self._get_machine_type(image_meta, caps)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_3baf4a7e","line":4058,"updated":"2015-08-21 03:52:45.000000000","message":"The default value of CONF.libvirt.bios_path is None, so I would like to see this line is moved into the following \u0027if\u0027 block, and nothing need to pay attention, so DEBUG log level is enough IMO.\n\ns/%s,/%s/","commit_id":"5f664a24cf5a29b4cedce43edd9f448a230ca3ad"},{"author":{"_account_id":16986,"name":"Shuquan Huang","email":"shuquan.huang@live.com","username":"shuquan"},"change_message_id":"13aa84ab73f2c7bc8b2c5133a741654fa5fc8a46","unresolved":false,"context_lines":[{"line_number":4055,"context_line":"            if caps.host.cpu.arch in (arch.I686, arch.X86_64):"},{"line_number":4056,"context_line":"                guest.sysinfo \u003d self._get_guest_config_sysinfo(instance)"},{"line_number":4057,"context_line":"                guest.os_smbios \u003d vconfig.LibvirtConfigGuestSMBIOS()"},{"line_number":4058,"context_line":"            LOG.warn(_LW(\u0027bios loader: %s,\u0027), CONF.libvirt.bios_path)"},{"line_number":4059,"context_line":"            if CONF.libvirt.bios_path:"},{"line_number":4060,"context_line":"                guest.os_bios \u003d CONF.libvirt.bios_path"},{"line_number":4061,"context_line":"            guest.os_mach_type \u003d self._get_machine_type(image_meta, caps)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_8efdefb2","line":4058,"in_reply_to":"fa1b9901_3baf4a7e","updated":"2015-08-21 06:04:20.000000000","message":"Done","commit_id":"5f664a24cf5a29b4cedce43edd9f448a230ca3ad"},{"author":{"_account_id":14358,"name":"Marian Horban","email":"m.horban@gmail.com","username":"mhorban"},"change_message_id":"93428cc91448ef6dffda7f31fb583683957a4a90","unresolved":false,"context_lines":[{"line_number":250,"context_line":"                    \u0027the \"virsh capabilities\"command. The format of the \u0027"},{"line_number":251,"context_line":"                    \u0027value for this config option is host-arch\u003dmachine-type. \u0027"},{"line_number":252,"context_line":"                    \u0027For example: x86_64\u003dmachinetype1,armv7l\u003dmachinetype2\u0027),"},{"line_number":253,"context_line":"    cfg.ListOpt(\u0027bios_path\u0027,"},{"line_number":254,"context_line":"               help\u003d\u0027For qemu or KVM guests, some ARCHs(such as. arm aarch64) \u0027"},{"line_number":255,"context_line":"                    \u0027need external bios rom path\u0027),"},{"line_number":256,"context_line":"    cfg.StrOpt(\u0027sysinfo_serial\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_e8cfbb53","line":253,"updated":"2015-08-21 08:10:41.000000000","message":"Why this is ListOpt? Looks like it should be StrOpt from description.","commit_id":"4c3a4d3f91eaa1c8d0d017880b117831bb11693a"},{"author":{"_account_id":16986,"name":"Shuquan Huang","email":"shuquan.huang@live.com","username":"shuquan"},"change_message_id":"2ac0ace6465f60d496f1eaeddd936f9ac40b95f6","unresolved":false,"context_lines":[{"line_number":250,"context_line":"                    \u0027the \"virsh capabilities\"command. The format of the \u0027"},{"line_number":251,"context_line":"                    \u0027value for this config option is host-arch\u003dmachine-type. \u0027"},{"line_number":252,"context_line":"                    \u0027For example: x86_64\u003dmachinetype1,armv7l\u003dmachinetype2\u0027),"},{"line_number":253,"context_line":"    cfg.ListOpt(\u0027bios_path\u0027,"},{"line_number":254,"context_line":"               help\u003d\u0027For qemu or KVM guests, some ARCHs(such as. arm aarch64) \u0027"},{"line_number":255,"context_line":"                    \u0027need external bios rom path\u0027),"},{"line_number":256,"context_line":"    cfg.StrOpt(\u0027sysinfo_serial\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_c78e1a27","line":253,"in_reply_to":"fa1b9901_e8cfbb53","updated":"2015-08-24 04:39:25.000000000","message":"Done","commit_id":"4c3a4d3f91eaa1c8d0d017880b117831bb11693a"}]}